[INFO] crate bencoderus 0.1.1 is already in cache
[INFO] extracting crate bencoderus 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/bencoderus/0.1.1
[INFO] extracting crate bencoderus 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bencoderus/0.1.1
[INFO] validating manifest of bencoderus-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bencoderus-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bencoderus-0.1.1
[INFO] finished frobbing bencoderus-0.1.1
[INFO] frobbed toml for bencoderus-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/bencoderus/0.1.1/Cargo.toml
[INFO] started frobbing bencoderus-0.1.1
[INFO] finished frobbing bencoderus-0.1.1
[INFO] frobbed toml for bencoderus-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bencoderus/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bencoderus-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bencoderus/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c4b5928716dd0e197df85e3837d41976944f16bd48448954cd3c97abf53626c1
[INFO] running `"docker" "start" "-a" "c4b5928716dd0e197df85e3837d41976944f16bd48448954cd3c97abf53626c1"`
[INFO] [stderr]     Checking bencoderus v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/libdecode.rs:483:5
[INFO] [stderr]     |
[INFO] [stderr] 483 |     len
[INFO] [stderr]     |     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/libdecode.rs:479:15
[INFO] [stderr]     |
[INFO] [stderr] 479 |       let len = match benc_num {
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 480 | |         Bencoding::Integer(v) => v,
[INFO] [stderr] 481 | |         _ => panic!("unexpected type"),
[INFO] [stderr] 482 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/libdecode.rs:498:5
[INFO] [stderr]     |
[INFO] [stderr] 498 |     return Bencoding::ByteString(buf);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Bencoding::ByteString(buf)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/libdecode.rs:520:5
[INFO] [stderr]     |
[INFO] [stderr] 520 |     return Bencoding::ByteString(buf);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Bencoding::ByteString(buf)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/libdecode.rs:483:5
[INFO] [stderr]     |
[INFO] [stderr] 483 |     len
[INFO] [stderr]     |     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/libdecode.rs:479:15
[INFO] [stderr]     |
[INFO] [stderr] 479 |       let len = match benc_num {
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 480 | |         Bencoding::Integer(v) => v,
[INFO] [stderr] 481 | |         _ => panic!("unexpected type"),
[INFO] [stderr] 482 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/libdecode.rs:498:5
[INFO] [stderr]     |
[INFO] [stderr] 498 |     return Bencoding::ByteString(buf);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Bencoding::ByteString(buf)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/libdecode.rs:520:5
[INFO] [stderr]     |
[INFO] [stderr] 520 |     return Bencoding::ByteString(buf);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Bencoding::ByteString(buf)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]    --> src/libdecode.rs:349:5
[INFO] [stderr]     |
[INFO] [stderr] 349 | /     while let Some(&&curr) = iter.peek() {
[INFO] [stderr] 350 | |         match curr {
[INFO] [stderr] 351 | |             DICTIONARY_START => {
[INFO] [stderr] 352 | |                 return decode_dictionary(&mut iter);
[INFO] [stderr] ...   |
[INFO] [stderr] 363 | |         }
[INFO] [stderr] 364 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/libdecode.rs:441:25
[INFO] [stderr]     |
[INFO] [stderr] 441 |     while let Some(b) = iter.next() {
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: try: `for b in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/libdecode.rs:491:25
[INFO] [stderr]     |
[INFO] [stderr] 491 |     while let Some(b) = iter.next() {
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: try: `for b in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/libdecode.rs:493:9
[INFO] [stderr]     |
[INFO] [stderr] 493 |         decr = decr - 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `decr -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/libdecode.rs:512:25
[INFO] [stderr]     |
[INFO] [stderr] 512 |     while let Some(b) = iter.next() {
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: try: `for b in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/libdecode.rs:514:9
[INFO] [stderr]     |
[INFO] [stderr] 514 |         i = i + 1;
[INFO] [stderr]     |         ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/libdecode.rs:550:29
[INFO] [stderr]     |
[INFO] [stderr] 550 |         while let Some(b) = iter.next() {
[INFO] [stderr]     |                             ^^^^^^^^^^^ help: try: `for b in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `bencoderus`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/libdecode.rs:112:25
[INFO] [stderr]     |
[INFO] [stderr] 112 |             let dp = &d["peers".as_bytes()];
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"peers"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]    --> src/libdecode.rs:349:5
[INFO] [stderr]     |
[INFO] [stderr] 349 | /     while let Some(&&curr) = iter.peek() {
[INFO] [stderr] 350 | |         match curr {
[INFO] [stderr] 351 | |             DICTIONARY_START => {
[INFO] [stderr] 352 | |                 return decode_dictionary(&mut iter);
[INFO] [stderr] ...   |
[INFO] [stderr] 363 | |         }
[INFO] [stderr] 364 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/libdecode.rs:441:25
[INFO] [stderr]     |
[INFO] [stderr] 441 |     while let Some(b) = iter.next() {
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: try: `for b in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/libdecode.rs:491:25
[INFO] [stderr]     |
[INFO] [stderr] 491 |     while let Some(b) = iter.next() {
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: try: `for b in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/libdecode.rs:493:9
[INFO] [stderr]     |
[INFO] [stderr] 493 |         decr = decr - 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `decr -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/libdecode.rs:512:25
[INFO] [stderr]     |
[INFO] [stderr] 512 |     while let Some(b) = iter.next() {
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: try: `for b in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/libdecode.rs:514:9
[INFO] [stderr]     |
[INFO] [stderr] 514 |         i = i + 1;
[INFO] [stderr]     |         ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/libdecode.rs:550:29
[INFO] [stderr]     |
[INFO] [stderr] 550 |         while let Some(b) = iter.next() {
[INFO] [stderr]     |                             ^^^^^^^^^^^ help: try: `for b in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `bencoderus`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "c4b5928716dd0e197df85e3837d41976944f16bd48448954cd3c97abf53626c1"`
[INFO] running `"docker" "rm" "-f" "c4b5928716dd0e197df85e3837d41976944f16bd48448954cd3c97abf53626c1"`
[INFO] [stdout] c4b5928716dd0e197df85e3837d41976944f16bd48448954cd3c97abf53626c1