[INFO] crate benchpmc 1.0.0 is already in cache [INFO] extracting crate benchpmc 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/benchpmc/1.0.0 [INFO] extracting crate benchpmc 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/benchpmc/1.0.0 [INFO] validating manifest of benchpmc-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of benchpmc-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing benchpmc-1.0.0 [INFO] finished frobbing benchpmc-1.0.0 [INFO] frobbed toml for benchpmc-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/benchpmc/1.0.0/Cargo.toml [INFO] started frobbing benchpmc-1.0.0 [INFO] finished frobbing benchpmc-1.0.0 [INFO] frobbed toml for benchpmc-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/benchpmc/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting benchpmc-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/benchpmc/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c5ee6dd4d447185502bbd736f9732d38162e5bfe5f1d4cafe21a3f950e69f6c6 [INFO] running `"docker" "start" "-a" "c5ee6dd4d447185502bbd736f9732d38162e5bfe5f1d4cafe21a3f950e69f6c6"` [INFO] [stderr] Checking benchpmc v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/event/printers/rsd/mod.rs:162:33 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(p.stddev() as f32, 15.811388); [INFO] [stderr] | ^^^^^^^^^ help: consider: `15.811_388` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/event/printers/rsd/mod.rs:165:30 [INFO] [stderr] | [INFO] [stderr] 165 | assert_eq!(p.rsd() as f32, 79.0569415); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `79.056_941_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matchers` [INFO] [stderr] --> src/main.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | matchers: &'a clap::ArgMatches<'a>, [INFO] [stderr] | ^^^^^^^^ help: consider using `_matchers` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `RelativePrinter` [INFO] [stderr] --> src/event/printers/relative.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub struct RelativePrinter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/event/printers/relative.rs:76:2 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn new(absolute: T, relatives: Vec>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/event/printers/rsd/mod.rs:87:2 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn new(counter: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matchers` [INFO] [stderr] --> src/main.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | matchers: &'a clap::ArgMatches<'a>, [INFO] [stderr] | ^^^^^^^^ help: consider using `_matchers` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/runner/exec.rs:77:4 [INFO] [stderr] | [INFO] [stderr] 77 | Err(_) => panic!("fork failed"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:131:54 [INFO] [stderr] | [INFO] [stderr] 131 | let ms = (diff.as_secs() * 1000) + u64::from(diff.subsec_nanos() / 1_000_000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `diff.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `RelativePrinter` [INFO] [stderr] --> src/event/printers/relative.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub struct RelativePrinter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/event/printers/relative.rs:76:2 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn new(absolute: T, relatives: Vec>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/event/printers/rsd/mod.rs:161:3 [INFO] [stderr] | [INFO] [stderr] 161 | assert_eq!(p.variance(), 250.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/event/printers/rsd/mod.rs:161:3 [INFO] [stderr] | [INFO] [stderr] 161 | assert_eq!(p.variance(), 250.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/event/printers/rsd/mod.rs:162:3 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(p.stddev() as f32, 15.811388); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/event/printers/rsd/mod.rs:162:3 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(p.stddev() as f32, 15.811388); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/event/printers/rsd/mod.rs:165:30 [INFO] [stderr] | [INFO] [stderr] 165 | assert_eq!(p.rsd() as f32, 79.0569415); [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `79.056_94` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/event/printers/rsd/mod.rs:165:3 [INFO] [stderr] | [INFO] [stderr] 165 | assert_eq!(p.rsd() as f32, 79.0569415); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/event/printers/rsd/mod.rs:165:3 [INFO] [stderr] | [INFO] [stderr] 165 | assert_eq!(p.rsd() as f32, 79.0569415); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/event/printers/rsd/mod.rs:174:3 [INFO] [stderr] | [INFO] [stderr] 174 | assert_eq!(p.variance(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/event/printers/rsd/mod.rs:174:3 [INFO] [stderr] | [INFO] [stderr] 174 | assert_eq!(p.variance(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/event/printers/rsd/mod.rs:175:3 [INFO] [stderr] | [INFO] [stderr] 175 | assert_eq!(p.stddev(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/event/printers/rsd/mod.rs:175:3 [INFO] [stderr] | [INFO] [stderr] 175 | assert_eq!(p.stddev(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/event/printers/rsd/mod.rs:176:3 [INFO] [stderr] | [INFO] [stderr] 176 | assert_eq!(p.rsd(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/event/printers/rsd/mod.rs:176:3 [INFO] [stderr] | [INFO] [stderr] 176 | assert_eq!(p.rsd(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/event/printers/rsd/mod.rs:185:3 [INFO] [stderr] | [INFO] [stderr] 185 | assert_eq!(p.variance(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/event/printers/rsd/mod.rs:185:3 [INFO] [stderr] | [INFO] [stderr] 185 | assert_eq!(p.variance(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/event/printers/rsd/mod.rs:186:3 [INFO] [stderr] | [INFO] [stderr] 186 | assert_eq!(p.stddev(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/event/printers/rsd/mod.rs:186:3 [INFO] [stderr] | [INFO] [stderr] 186 | assert_eq!(p.stddev(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/event/printers/rsd/mod.rs:187:3 [INFO] [stderr] | [INFO] [stderr] 187 | assert_eq!(p.rsd(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/event/printers/rsd/mod.rs:187:3 [INFO] [stderr] | [INFO] [stderr] 187 | assert_eq!(p.rsd(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/runner/exec.rs:77:4 [INFO] [stderr] | [INFO] [stderr] 77 | Err(_) => panic!("fork failed"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/runner/exec.rs:136:10 [INFO] [stderr] | [INFO] [stderr] 136 | .args(&vec!["test"]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&["test"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/runner/exec.rs:148:10 [INFO] [stderr] | [INFO] [stderr] 148 | .args(&vec!["test"]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&["test"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/runner/exec.rs:160:10 [INFO] [stderr] | [INFO] [stderr] 160 | .args(&vec!["test"]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&["test"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/runner/mod.rs:106:10 [INFO] [stderr] | [INFO] [stderr] 106 | r.run(&mut vec![Box::new(mock_event::new())]).unwrap_err(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Box::new(mock_event::new())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/runner/mod.rs:116:10 [INFO] [stderr] | [INFO] [stderr] 116 | r.run(&mut vec![Box::new(mock_event::new())]).unwrap_err(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Box::new(mock_event::new())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:131:54 [INFO] [stderr] | [INFO] [stderr] 131 | let ms = (diff.as_secs() * 1000) + u64::from(diff.subsec_nanos() / 1_000_000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `diff.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `benchpmc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c5ee6dd4d447185502bbd736f9732d38162e5bfe5f1d4cafe21a3f950e69f6c6"` [INFO] running `"docker" "rm" "-f" "c5ee6dd4d447185502bbd736f9732d38162e5bfe5f1d4cafe21a3f950e69f6c6"` [INFO] [stdout] c5ee6dd4d447185502bbd736f9732d38162e5bfe5f1d4cafe21a3f950e69f6c6