[INFO] crate bellman 0.1.0 is already in cache [INFO] extracting crate bellman 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/bellman/0.1.0 [INFO] extracting crate bellman 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bellman/0.1.0 [INFO] validating manifest of bellman-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bellman-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bellman-0.1.0 [INFO] finished frobbing bellman-0.1.0 [INFO] frobbed toml for bellman-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/bellman/0.1.0/Cargo.toml [INFO] started frobbing bellman-0.1.0 [INFO] finished frobbing bellman-0.1.0 [INFO] frobbed toml for bellman-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bellman/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bellman-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bellman/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5f4af81400ce56fcead76e56da8ceb10cb795207650762878d39c029b5cd4d36 [INFO] running `"docker" "start" "-a" "5f4af81400ce56fcead76e56da8ceb10cb795207650762878d39c029b5cd4d36"` [INFO] [stderr] Checking pairing v0.14.2 [INFO] [stderr] Checking bellman v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/multicore.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | cpus: cpus, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cpus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/domain.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | coeffs: coeffs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `coeffs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/domain.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | exp: exp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `exp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/domain.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | omega: omega, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `omega` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/domain.rs:299:21 [INFO] [stderr] | [INFO] [stderr] 299 | let mut w = E::Fr::one(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/domain.rs:301:25 [INFO] [stderr] | [INFO] [stderr] 301 | let mut t = a[(k+j+m) as usize]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/generator.rs:473:9 [INFO] [stderr] | [INFO] [stderr] 473 | vk: vk, [INFO] [stderr] | ^^^^^^ help: replace it with: `vk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/groth16/prover.rs:242:17 [INFO] [stderr] | [INFO] [stderr] 242 | let mut c = EvaluationDomain::from_coeffs(prover.c)?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | c: c [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | alpha_g1: alpha_g1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `alpha_g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | beta_g1: beta_g1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `beta_g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | beta_g2: beta_g2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `beta_g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | gamma_g2: gamma_g2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `gamma_g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | delta_g1: delta_g1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `delta_g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | delta_g2: delta_g2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `delta_g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | ic: ic [INFO] [stderr] | ^^^^^^ help: replace it with: `ic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | vk: vk, [INFO] [stderr] | ^^^^^^ help: replace it with: `vk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/multicore.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | cpus: cpus, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cpus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/domain.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | coeffs: coeffs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `coeffs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/domain.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | exp: exp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `exp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/domain.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | omega: omega, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `omega` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/domain.rs:299:21 [INFO] [stderr] | [INFO] [stderr] 299 | let mut w = E::Fr::one(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/domain.rs:301:25 [INFO] [stderr] | [INFO] [stderr] 301 | let mut t = a[(k+j+m) as usize]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/groth16/tests/dummy_engine.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | let mut i = 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/generator.rs:473:9 [INFO] [stderr] | [INFO] [stderr] 473 | vk: vk, [INFO] [stderr] | ^^^^^^ help: replace it with: `vk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/groth16/prover.rs:242:17 [INFO] [stderr] | [INFO] [stderr] 242 | let mut c = EvaluationDomain::from_coeffs(prover.c)?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | c: c [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | alpha_g1: alpha_g1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `alpha_g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | beta_g1: beta_g1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `beta_g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | beta_g2: beta_g2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `beta_g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | gamma_g2: gamma_g2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `gamma_g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | delta_g1: delta_g1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `delta_g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | delta_g2: delta_g2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `delta_g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | ic: ic [INFO] [stderr] | ^^^^^^ help: replace it with: `ic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/groth16/mod.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | vk: vk, [INFO] [stderr] | ^^^^^^ help: replace it with: `vk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `multicore::Worker` [INFO] [stderr] --> src/multicore.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Worker { [INFO] [stderr] 30 | | Self::new_with_cpus(num_cpus::get()) [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for multicore::Worker { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name [INFO] [stderr] --> src/domain.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn as_ref(&self) -> &[G] { [INFO] [stderr] 37 | | &self.coeffs [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `as_mut` on this type; consider implementing the `std::convert::AsMut` trait or choosing a less ambiguous name [INFO] [stderr] --> src/domain.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn as_mut(&mut self) -> &mut [G] { [INFO] [stderr] 41 | | &mut self.coeffs [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/domain.rs:295:31 [INFO] [stderr] | [INFO] [stderr] 295 | let w_m = omega.pow(&[(n / (2*m)) as u64]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(n / (2*m))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tmp` [INFO] [stderr] --> src/domain.rs:342:26 [INFO] [stderr] | [INFO] [stderr] 342 | for i in 0..(1 << log_new_n) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 342 | for (i, ) in tmp.iter_mut().enumerate().take((1 << log_new_n)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/groth16/generator.rs:173:1 [INFO] [stderr] | [INFO] [stderr] 173 | / pub fn generate_parameters( [INFO] [stderr] 174 | | circuit: C, [INFO] [stderr] 175 | | g1: E::G1, [INFO] [stderr] 176 | | g2: E::G2, [INFO] [stderr] ... | [INFO] [stderr] 481 | | }) [INFO] [stderr] 482 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/groth16/generator.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | / fn eval( [INFO] [stderr] 302 | | // wNAF window tables [INFO] [stderr] 303 | | g1_wnaf: &Wnaf>, [INFO] [stderr] 304 | | g2_wnaf: &Wnaf>, [INFO] [stderr] ... | [INFO] [stderr] 412 | | }); [INFO] [stderr] 413 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/groth16/verifier.rs:64:11 [INFO] [stderr] | [INFO] [stderr] 64 | ].into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/lib.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | self + (coeff, var) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / if let &SynthesisError::IoError(ref e) = self { [INFO] [stderr] 212 | | write!(f, "I/O error: ")?; [INFO] [stderr] 213 | | e.fmt(f) [INFO] [stderr] 214 | | } else { [INFO] [stderr] 215 | | write!(f, "{}", self.description()) [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 211 | if let SynthesisError::IoError(ref e) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:280:5 [INFO] [stderr] | [INFO] [stderr] 280 | / fn namespace<'a, NR, N>( [INFO] [stderr] 281 | | &'a mut self, [INFO] [stderr] 282 | | name_fn: N [INFO] [stderr] 283 | | ) -> Namespace<'a, E, Self::Root> [INFO] [stderr] ... | [INFO] [stderr] 288 | | Namespace(self.get_root(), PhantomData) [INFO] [stderr] 289 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bellman`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `multicore::Worker` [INFO] [stderr] --> src/multicore.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Worker { [INFO] [stderr] 30 | | Self::new_with_cpus(num_cpus::get()) [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for multicore::Worker { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name [INFO] [stderr] --> src/domain.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn as_ref(&self) -> &[G] { [INFO] [stderr] 37 | | &self.coeffs [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `as_mut` on this type; consider implementing the `std::convert::AsMut` trait or choosing a less ambiguous name [INFO] [stderr] --> src/domain.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn as_mut(&mut self) -> &mut [G] { [INFO] [stderr] 41 | | &mut self.coeffs [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/domain.rs:295:31 [INFO] [stderr] | [INFO] [stderr] 295 | let w_m = omega.pow(&[(n / (2*m)) as u64]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(n / (2*m))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tmp` [INFO] [stderr] --> src/domain.rs:342:26 [INFO] [stderr] | [INFO] [stderr] 342 | for i in 0..(1 << log_new_n) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 342 | for (i, ) in tmp.iter_mut().enumerate().take((1 << log_new_n)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/groth16/tests/dummy_engine.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | Some(self.pow(&[(MODULUS_R.0 as u64) - 2])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(MODULUS_R.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/groth16/tests/dummy_engine.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | FrRepr([(v.0).0 as u64]) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from((v.0).0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/groth16/tests/dummy_engine.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | if repr.0[0] >= (MODULUS_R.0 as u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(MODULUS_R.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/groth16/tests/mod.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / fn test_xordemo() { [INFO] [stderr] 100 | | let g1 = Fr::one(); [INFO] [stderr] 101 | | let g2 = Fr::one(); [INFO] [stderr] 102 | | let alpha = Fr::from_str("48577").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 399 | | ).unwrap()); [INFO] [stderr] 400 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/groth16/generator.rs:173:1 [INFO] [stderr] | [INFO] [stderr] 173 | / pub fn generate_parameters( [INFO] [stderr] 174 | | circuit: C, [INFO] [stderr] 175 | | g1: E::G1, [INFO] [stderr] 176 | | g2: E::G2, [INFO] [stderr] ... | [INFO] [stderr] 481 | | }) [INFO] [stderr] 482 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/groth16/generator.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | / fn eval( [INFO] [stderr] 302 | | // wNAF window tables [INFO] [stderr] 303 | | g1_wnaf: &Wnaf>, [INFO] [stderr] 304 | | g2_wnaf: &Wnaf>, [INFO] [stderr] ... | [INFO] [stderr] 412 | | }); [INFO] [stderr] 413 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/groth16/verifier.rs:64:11 [INFO] [stderr] | [INFO] [stderr] 64 | ].into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/lib.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | self + (coeff, var) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / if let &SynthesisError::IoError(ref e) = self { [INFO] [stderr] 212 | | write!(f, "I/O error: ")?; [INFO] [stderr] 213 | | e.fmt(f) [INFO] [stderr] 214 | | } else { [INFO] [stderr] 215 | | write!(f, "{}", self.description()) [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 211 | if let SynthesisError::IoError(ref e) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:280:5 [INFO] [stderr] | [INFO] [stderr] 280 | / fn namespace<'a, NR, N>( [INFO] [stderr] 281 | | &'a mut self, [INFO] [stderr] 282 | | name_fn: N [INFO] [stderr] 283 | | ) -> Namespace<'a, E, Self::Root> [INFO] [stderr] ... | [INFO] [stderr] 288 | | Namespace(self.get_root(), PhantomData) [INFO] [stderr] 289 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bellman`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5f4af81400ce56fcead76e56da8ceb10cb795207650762878d39c029b5cd4d36"` [INFO] running `"docker" "rm" "-f" "5f4af81400ce56fcead76e56da8ceb10cb795207650762878d39c029b5cd4d36"` [INFO] [stdout] 5f4af81400ce56fcead76e56da8ceb10cb795207650762878d39c029b5cd4d36