[INFO] crate bele 0.4.0 is already in cache [INFO] extracting crate bele 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/bele/0.4.0 [INFO] extracting crate bele 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bele/0.4.0 [INFO] validating manifest of bele-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bele-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bele-0.4.0 [INFO] finished frobbing bele-0.4.0 [INFO] frobbed toml for bele-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/bele/0.4.0/Cargo.toml [INFO] started frobbing bele-0.4.0 [INFO] finished frobbing bele-0.4.0 [INFO] frobbed toml for bele-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bele/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bele-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bele/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a5bb910353cd87c4160e0cd4240d3176f1cf08b73d016f6fc98ce23e32fbf102 [INFO] running `"docker" "start" "-a" "a5bb910353cd87c4160e0cd4240d3176f1cf08b73d016f6fc98ce23e32fbf102"` [INFO] [stderr] Checking kib v1.2.0 [INFO] [stderr] Checking dia-go v0.2.1 [INFO] [stderr] Checking bele v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | pub const CRATE_NAME: &'static str = "BELE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | pub const CRATE_CODE_NAME: &'static str = crate_code_name!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | pub const CRATE_VERSION: &'static str = crate_version!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | pub const UUID: &'static str = "212aa102-3002-48f3-943d-1c96a65215b5"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | pub const TAG: &'static str = concat!(crate_code_name!(), "_817f990f_", crate_version!()); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | const BIN_MARKER: &'static str = r"0b"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | const HEX_MARKER: &'static str = r"0x"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | const U8_MARKER: &'static str = r"u8:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | const I8_MARKER: &'static str = r"i8:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | const U16_MARKER: &'static str = r"u16:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | const I16_MARKER: &'static str = r"i16:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | const U32_MARKER: &'static str = r"u32:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | const I32_MARKER: &'static str = r"i32:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | const U64_MARKER: &'static str = r"u64:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | const I64_MARKER: &'static str = r"i64:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | const U128_MARKER: &'static str = r"u128:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | const I128_MARKER: &'static str = r"i128:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | const USIZE_MARKER: &'static str = r"usize:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:92:22 [INFO] [stderr] | [INFO] [stderr] 92 | const ISIZE_MARKER: &'static str = r"isize:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:93:20 [INFO] [stderr] | [INFO] [stderr] 93 | const F32_MARKER: &'static str = r"f32:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:94:20 [INFO] [stderr] | [INFO] [stderr] 94 | const F64_MARKER: &'static str = r"f64:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:357:44 [INFO] [stderr] | [INFO] [stderr] 357 | (Some(ref marker), Some(ref s)) => return match format!("{}:", marker).as_str() { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 358 | | self::U8_MARKER => parse_single_integer!(u8, s), [INFO] [stderr] 359 | | self::I8_MARKER => parse_single_integer!(i8, s), [INFO] [stderr] 360 | | self::U16_MARKER => parse_single_integer!(u16, s), [INFO] [stderr] ... | [INFO] [stderr] 372 | | _ => Err(Error::new(ErrorKind::InvalidData, format!("Not a number: {}", &s))), [INFO] [stderr] 373 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 357 | (Some(ref marker), Some(ref s)) => match format!("{}:", marker).as_str() { [INFO] [stderr] 358 | self::U8_MARKER => parse_single_integer!(u8, s), [INFO] [stderr] 359 | self::I8_MARKER => parse_single_integer!(i8, s), [INFO] [stderr] 360 | self::U16_MARKER => parse_single_integer!(u16, s), [INFO] [stderr] 361 | self::I16_MARKER => parse_single_integer!(i16, s), [INFO] [stderr] 362 | self::U32_MARKER => parse_single_integer!(u32, s), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | pub const CRATE_NAME: &'static str = "BELE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | pub const CRATE_CODE_NAME: &'static str = crate_code_name!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | pub const CRATE_VERSION: &'static str = crate_version!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | pub const UUID: &'static str = "212aa102-3002-48f3-943d-1c96a65215b5"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | pub const TAG: &'static str = concat!(crate_code_name!(), "_817f990f_", crate_version!()); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | const BIN_MARKER: &'static str = r"0b"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | const HEX_MARKER: &'static str = r"0x"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | const U8_MARKER: &'static str = r"u8:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | const I8_MARKER: &'static str = r"i8:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | const U16_MARKER: &'static str = r"u16:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | const I16_MARKER: &'static str = r"i16:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | const U32_MARKER: &'static str = r"u32:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | const I32_MARKER: &'static str = r"i32:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | const U64_MARKER: &'static str = r"u64:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | const I64_MARKER: &'static str = r"i64:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | const U128_MARKER: &'static str = r"u128:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | const I128_MARKER: &'static str = r"i128:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | const USIZE_MARKER: &'static str = r"usize:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:92:22 [INFO] [stderr] | [INFO] [stderr] 92 | const ISIZE_MARKER: &'static str = r"isize:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:93:20 [INFO] [stderr] | [INFO] [stderr] 93 | const F32_MARKER: &'static str = r"f32:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:94:20 [INFO] [stderr] | [INFO] [stderr] 94 | const F64_MARKER: &'static str = r"f64:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:357:44 [INFO] [stderr] | [INFO] [stderr] 357 | (Some(ref marker), Some(ref s)) => return match format!("{}:", marker).as_str() { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 358 | | self::U8_MARKER => parse_single_integer!(u8, s), [INFO] [stderr] 359 | | self::I8_MARKER => parse_single_integer!(i8, s), [INFO] [stderr] 360 | | self::U16_MARKER => parse_single_integer!(u16, s), [INFO] [stderr] ... | [INFO] [stderr] 372 | | _ => Err(Error::new(ErrorKind::InvalidData, format!("Not a number: {}", &s))), [INFO] [stderr] 373 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 357 | (Some(ref marker), Some(ref s)) => match format!("{}:", marker).as_str() { [INFO] [stderr] 358 | self::U8_MARKER => parse_single_integer!(u8, s), [INFO] [stderr] 359 | self::I8_MARKER => parse_single_integer!(i8, s), [INFO] [stderr] 360 | self::U16_MARKER => parse_single_integer!(u16, s), [INFO] [stderr] 361 | self::I16_MARKER => parse_single_integer!(i16, s), [INFO] [stderr] 362 | self::U32_MARKER => parse_single_integer!(u32, s), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:431:89 [INFO] [stderr] | [INFO] [stderr] 431 | assert_eq!(parse_str(&go, &format!("{}-123456789", I32_MARKER)).unwrap(), hash_of!(-123456789_i32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `123_456_789_i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | go.s(format!("{}", CRATE_NAME)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `CRATE_NAME.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | go.i(format!("Examples:\n\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Examples:\n\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / match result.is_empty() { [INFO] [stderr] 173 | | true => result.push('['), [INFO] [stderr] 174 | | false => result.push_str(", "), [INFO] [stderr] 175 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if result.is_empty() { result.push('[') } else { result.push_str(", ") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | / match result.is_empty() { [INFO] [stderr] 196 | | true => result.push('['), [INFO] [stderr] 197 | | false => result.push_str(", "), [INFO] [stderr] 198 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if result.is_empty() { result.push('[') } else { result.push_str(", ") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 210 [INFO] [stderr] --> src/main.rs:235:1 [INFO] [stderr] | [INFO] [stderr] 235 | / fn parse_str(go: &Go, str_to_parse: &str) -> io::Result { [INFO] [stderr] 236 | | let str_to_parse = str_to_parse.trim().replace('_', ""); [INFO] [stderr] 237 | | [INFO] [stderr] 238 | | macro_rules! print_value { ($ty: ty, $value: expr) => {{ [INFO] [stderr] ... | [INFO] [stderr] 377 | | } [INFO] [stderr] 378 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:339:38 [INFO] [stderr] | [INFO] [stderr] 339 | Ok(v) => match v.is_infinite() && stringify!($ty) == stringify!(f32) { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 340 | | true => Err(Error::new(ErrorKind::InvalidData, format!("Float value is infinite: {}", v))), [INFO] [stderr] 341 | | false => parse_single_float!($ty, $bit_ty, &str_to_parse), [INFO] [stderr] 342 | | }, [INFO] [stderr] | |_____________________________^ help: consider using an if/else expression: `if v.is_infinite() && stringify!($ty) == stringify!(f32) { parse_floats!(f32, u32, f64, u64) } else { parse_floats!(f32, u32, f64, u64) }` [INFO] [stderr] ... [INFO] [stderr] 375 | parse_floats!(f32, u32, f64, u64) [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | go.s(format!("{}", CRATE_NAME)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `CRATE_NAME.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | go.i(format!("Examples:\n\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Examples:\n\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / match result.is_empty() { [INFO] [stderr] 173 | | true => result.push('['), [INFO] [stderr] 174 | | false => result.push_str(", "), [INFO] [stderr] 175 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if result.is_empty() { result.push('[') } else { result.push_str(", ") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | / match result.is_empty() { [INFO] [stderr] 196 | | true => result.push('['), [INFO] [stderr] 197 | | false => result.push_str(", "), [INFO] [stderr] 198 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if result.is_empty() { result.push('[') } else { result.push_str(", ") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 210 [INFO] [stderr] --> src/main.rs:235:1 [INFO] [stderr] | [INFO] [stderr] 235 | / fn parse_str(go: &Go, str_to_parse: &str) -> io::Result { [INFO] [stderr] 236 | | let str_to_parse = str_to_parse.trim().replace('_', ""); [INFO] [stderr] 237 | | [INFO] [stderr] 238 | | macro_rules! print_value { ($ty: ty, $value: expr) => {{ [INFO] [stderr] ... | [INFO] [stderr] 377 | | } [INFO] [stderr] 378 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:339:38 [INFO] [stderr] | [INFO] [stderr] 339 | Ok(v) => match v.is_infinite() && stringify!($ty) == stringify!(f32) { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 340 | | true => Err(Error::new(ErrorKind::InvalidData, format!("Float value is infinite: {}", v))), [INFO] [stderr] 341 | | false => parse_single_float!($ty, $bit_ty, &str_to_parse), [INFO] [stderr] 342 | | }, [INFO] [stderr] | |_____________________________^ help: consider using an if/else expression: `if v.is_infinite() && stringify!($ty) == stringify!(f32) { parse_floats!(f32, u32, f64, u64) } else { parse_floats!(f32, u32, f64, u64) }` [INFO] [stderr] ... [INFO] [stderr] 375 | parse_floats!(f32, u32, f64, u64) [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/main.rs:381:1 [INFO] [stderr] | [INFO] [stderr] 381 | / fn test_parse_str() { [INFO] [stderr] 382 | | let go = Go::default(); [INFO] [stderr] 383 | | [INFO] [stderr] 384 | | // Auto-detection [INFO] [stderr] ... | [INFO] [stderr] 433 | | assert_eq!(parse_str(&go, &format!("{}456", F64_MARKER)).unwrap(), hash_of_float!(456_f64)); [INFO] [stderr] 434 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.68s [INFO] running `"docker" "inspect" "a5bb910353cd87c4160e0cd4240d3176f1cf08b73d016f6fc98ce23e32fbf102"` [INFO] running `"docker" "rm" "-f" "a5bb910353cd87c4160e0cd4240d3176f1cf08b73d016f6fc98ce23e32fbf102"` [INFO] [stdout] a5bb910353cd87c4160e0cd4240d3176f1cf08b73d016f6fc98ce23e32fbf102