[INFO] crate beamdpr 0.2.3 is already in cache
[INFO] extracting crate beamdpr 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/beamdpr/0.2.3
[INFO] extracting crate beamdpr 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/beamdpr/0.2.3
[INFO] validating manifest of beamdpr-0.2.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of beamdpr-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing beamdpr-0.2.3
[INFO] finished frobbing beamdpr-0.2.3
[INFO] frobbed toml for beamdpr-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/beamdpr/0.2.3/Cargo.toml
[INFO] started frobbing beamdpr-0.2.3
[INFO] finished frobbing beamdpr-0.2.3
[INFO] frobbed toml for beamdpr-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/beamdpr/0.2.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting beamdpr-0.2.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/beamdpr/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cf6856af6a341e4479d592eb49fd7ba5f40a38a32e4f8d2079590ba99784162b
[INFO] running `"docker" "start" "-a" "cf6856af6a341e4479d592eb49fd7ba5f40a38a32e4f8d2079590ba99784162b"`
[INFO] [stderr]     Checking beamdpr v0.2.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |             mode: mode,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `mode`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:158:13
[INFO] [stderr]     |
[INFO] [stderr] 158 |             reader: reader,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:159:13
[INFO] [stderr]     |
[INFO] [stderr] 159 |             header: header,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:210:13
[INFO] [stderr]     |
[INFO] [stderr] 210 |             writer: writer,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `writer`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |             mode: mode,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `mode`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:158:13
[INFO] [stderr]     |
[INFO] [stderr] 158 |             reader: reader,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:159:13
[INFO] [stderr]     |
[INFO] [stderr] 159 |             header: header,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:210:13
[INFO] [stderr]     |
[INFO] [stderr] 210 |             writer: writer,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `writer`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:266:22
[INFO] [stderr]     |
[INFO] [stderr] 266 |         self.latch & 0xfffffe
[INFO] [stderr]     |                      ^^^^^^^^ help: consider: `0x00ff_fffe`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:269:22
[INFO] [stderr]     |
[INFO] [stderr] 269 |         self.latch & 0xf000000
[INFO] [stderr]     |                      ^^^^^^^^^ help: consider: `0x0f00_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:296:9
[INFO] [stderr]     |
[INFO] [stderr] 296 |         return self.total_energy.is_sign_negative();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.total_energy.is_sign_negative()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:266:22
[INFO] [stderr]     |
[INFO] [stderr] 266 |         self.latch & 0xfffffe
[INFO] [stderr]     |                      ^^^^^^^^ help: consider: `0x00ff_fffe`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:269:22
[INFO] [stderr]     |
[INFO] [stderr] 269 |         self.latch & 0xf000000
[INFO] [stderr]     |                      ^^^^^^^^^ help: consider: `0x0f00_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:296:9
[INFO] [stderr]     |
[INFO] [stderr] 296 |         return self.total_energy.is_sign_negative();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.total_energy.is_sign_negative()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024`
[INFO] [stderr]   --> src/lib.rs:20:32
[INFO] [stderr]    |
[INFO] [stderr] 20 | const BUFFER_CAPACITY: usize = 1 * 1024 * 1024;
[INFO] [stderr]    |                                ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/lib.rs:243:17
[INFO] [stderr]     |
[INFO] [stderr] 243 |         assert!(&self.mode == &other.mode, "Merge mode mismatch");
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 243 |         assert!(self.mode == other.mode, "Merge mode mismatch");
[INFO] [stderr]     |                 ^^^^^^^^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:345:13
[INFO] [stderr]     |
[INFO] [stderr] 345 | /             match reader.next() {
[INFO] [stderr] 346 | |                 Some(record) => records.push(record.unwrap()),
[INFO] [stderr] 347 | |                 None => (),
[INFO] [stderr] 348 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Some(record) = reader.next() { records.push(record.unwrap()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:377:11
[INFO] [stderr]     |
[INFO] [stderr] 377 |     while readers.len() != 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!readers.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:380:13
[INFO] [stderr]     |
[INFO] [stderr] 380 | /             match reader.next() {
[INFO] [stderr] 381 | |                 Some(record) => try!(writer.write(&record.unwrap())),
[INFO] [stderr] 382 | |                 None => (),
[INFO] [stderr] 383 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Some(record) = reader.next() { try!(writer.write(&record.unwrap())) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:395:13
[INFO] [stderr]     |
[INFO] [stderr] 395 |     assert!(input_paths.len() > 0, "Cannot combine zero files");
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input_paths.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:455:13
[INFO] [stderr]     |
[INFO] [stderr] 455 |     assert!(ipaths.len() > 0, "Cannot combine zero files");
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ipaths.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:499:5
[INFO] [stderr]     |
[INFO] [stderr] 499 | /     let ofile;
[INFO] [stderr] 500 | |     if input_path == output_path {
[INFO] [stderr] 501 | |         println!("Translating {} in place by ({}, {})",
[INFO] [stderr] 502 | |                  input_path.display(),
[INFO] [stderr] ...   |
[INFO] [stderr] 512 | |         ofile = try!(File::create(output_path));
[INFO] [stderr] 513 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 499 |     let ofile = if input_path == output_path { ..; match $ expr {
[INFO] [stderr] 500 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 501 | :: Err ( err ) => {
[INFO] [stderr] 502 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 503 | $ crate :: convert :: From :: from ( err ) ) } } } else { ..; match $ expr {
[INFO] [stderr] 504 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:532:5
[INFO] [stderr]     |
[INFO] [stderr] 532 | /     let ofile;
[INFO] [stderr] 533 | |     if input_path == output_path {
[INFO] [stderr] 534 | |         println!("Transforming {} in place", input_path.display());
[INFO] [stderr] 535 | |         ofile = try!(OpenOptions::new().write(true).create(true).open(output_path));
[INFO] [stderr] ...   |
[INFO] [stderr] 541 | |         ofile = try!(File::create(output_path));
[INFO] [stderr] 542 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 532 |     let ofile = if input_path == output_path { ..; match $ expr {
[INFO] [stderr] 533 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 534 | :: Err ( err ) => {
[INFO] [stderr] 535 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 536 | $ crate :: convert :: From :: from ( err ) ) } } } else { ..; match $ expr {
[INFO] [stderr] 537 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:564:5
[INFO] [stderr]     |
[INFO] [stderr] 564 | /     let output_file;
[INFO] [stderr] 565 | |     if input_path == output_path {
[INFO] [stderr] 566 | |         println!("Reweighting in-place");
[INFO] [stderr] 567 | |         output_file = try!(OpenOptions::new().write(true).create(true).open(output_path));
[INFO] [stderr] ...   |
[INFO] [stderr] 570 | |         output_file = try!(File::create(output_path));
[INFO] [stderr] 571 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 564 |     let output_file = if input_path == output_path { ..; match $ expr {
[INFO] [stderr] 565 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 566 | :: Err ( err ) => {
[INFO] [stderr] 567 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 568 | $ crate :: convert :: From :: from ( err ) ) } } } else { ..; match $ expr {
[INFO] [stderr] 569 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:587:5
[INFO] [stderr]     |
[INFO] [stderr] 587 | /     let ofile2;
[INFO] [stderr] 588 | |     if input_path == output_path {
[INFO] [stderr] 589 | |         ofile2 = try!(OpenOptions::new().write(true).create(true).open(output_path));
[INFO] [stderr] 590 | |     } else {
[INFO] [stderr] 591 | |         ofile2 = try!(File::create(output_path));
[INFO] [stderr] 592 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 587 |     let ofile2 = if input_path == output_path { match $ expr {
[INFO] [stderr] 588 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 589 | :: Err ( err ) => {
[INFO] [stderr] 590 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 591 | $ crate :: convert :: From :: from ( err ) ) } } } else { match $ expr {
[INFO] [stderr] 592 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024`
[INFO] [stderr]   --> src/lib.rs:20:32
[INFO] [stderr]    |
[INFO] [stderr] 20 | const BUFFER_CAPACITY: usize = 1 * 1024 * 1024;
[INFO] [stderr]    |                                ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/lib.rs:243:17
[INFO] [stderr]     |
[INFO] [stderr] 243 |         assert!(&self.mode == &other.mode, "Merge mode mismatch");
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 243 |         assert!(self.mode == other.mode, "Merge mode mismatch");
[INFO] [stderr]     |                 ^^^^^^^^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:345:13
[INFO] [stderr]     |
[INFO] [stderr] 345 | /             match reader.next() {
[INFO] [stderr] 346 | |                 Some(record) => records.push(record.unwrap()),
[INFO] [stderr] 347 | |                 None => (),
[INFO] [stderr] 348 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Some(record) = reader.next() { records.push(record.unwrap()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:377:11
[INFO] [stderr]     |
[INFO] [stderr] 377 |     while readers.len() != 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!readers.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:380:13
[INFO] [stderr]     |
[INFO] [stderr] 380 | /             match reader.next() {
[INFO] [stderr] 381 | |                 Some(record) => try!(writer.write(&record.unwrap())),
[INFO] [stderr] 382 | |                 None => (),
[INFO] [stderr] 383 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Some(record) = reader.next() { try!(writer.write(&record.unwrap())) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:395:13
[INFO] [stderr]     |
[INFO] [stderr] 395 |     assert!(input_paths.len() > 0, "Cannot combine zero files");
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input_paths.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:455:13
[INFO] [stderr]     |
[INFO] [stderr] 455 |     assert!(ipaths.len() > 0, "Cannot combine zero files");
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ipaths.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/bin.rs:212:9
[INFO] [stderr]     |
[INFO] [stderr] 212 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/bin.rs:228:13
[INFO] [stderr]     |
[INFO] [stderr] 228 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:499:5
[INFO] [stderr]     |
[INFO] [stderr] 499 | /     let ofile;
[INFO] [stderr] 500 | |     if input_path == output_path {
[INFO] [stderr] 501 | |         println!("Translating {} in place by ({}, {})",
[INFO] [stderr] 502 | |                  input_path.display(),
[INFO] [stderr] ...   |
[INFO] [stderr] 512 | |         ofile = try!(File::create(output_path));
[INFO] [stderr] 513 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 499 |     let ofile = if input_path == output_path { ..; match $ expr {
[INFO] [stderr] 500 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 501 | :: Err ( err ) => {
[INFO] [stderr] 502 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 503 | $ crate :: convert :: From :: from ( err ) ) } } } else { ..; match $ expr {
[INFO] [stderr] 504 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:532:5
[INFO] [stderr]     |
[INFO] [stderr] 532 | /     let ofile;
[INFO] [stderr] 533 | |     if input_path == output_path {
[INFO] [stderr] 534 | |         println!("Transforming {} in place", input_path.display());
[INFO] [stderr] 535 | |         ofile = try!(OpenOptions::new().write(true).create(true).open(output_path));
[INFO] [stderr] ...   |
[INFO] [stderr] 541 | |         ofile = try!(File::create(output_path));
[INFO] [stderr] 542 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 532 |     let ofile = if input_path == output_path { ..; match $ expr {
[INFO] [stderr] 533 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 534 | :: Err ( err ) => {
[INFO] [stderr] 535 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 536 | $ crate :: convert :: From :: from ( err ) ) } } } else { ..; match $ expr {
[INFO] [stderr] 537 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:564:5
[INFO] [stderr]     |
[INFO] [stderr] 564 | /     let output_file;
[INFO] [stderr] 565 | |     if input_path == output_path {
[INFO] [stderr] 566 | |         println!("Reweighting in-place");
[INFO] [stderr] 567 | |         output_file = try!(OpenOptions::new().write(true).create(true).open(output_path));
[INFO] [stderr] ...   |
[INFO] [stderr] 570 | |         output_file = try!(File::create(output_path));
[INFO] [stderr] 571 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 564 |     let output_file = if input_path == output_path { ..; match $ expr {
[INFO] [stderr] 565 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 566 | :: Err ( err ) => {
[INFO] [stderr] 567 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 568 | $ crate :: convert :: From :: from ( err ) ) } } } else { ..; match $ expr {
[INFO] [stderr] 569 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:587:5
[INFO] [stderr]     |
[INFO] [stderr] 587 | /     let ofile2;
[INFO] [stderr] 588 | |     if input_path == output_path {
[INFO] [stderr] 589 | |         ofile2 = try!(OpenOptions::new().write(true).create(true).open(output_path));
[INFO] [stderr] 590 | |     } else {
[INFO] [stderr] 591 | |         ofile2 = try!(File::create(output_path));
[INFO] [stderr] 592 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 587 |     let ofile2 = if input_path == output_path { match $ expr {
[INFO] [stderr] 588 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 589 | :: Err ( err ) => {
[INFO] [stderr] 590 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 591 | $ crate :: convert :: From :: from ( err ) ) } } } else { match $ expr {
[INFO] [stderr] 592 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/bin.rs:212:9
[INFO] [stderr]     |
[INFO] [stderr] 212 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/bin.rs:228:13
[INFO] [stderr]     |
[INFO] [stderr] 228 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/egsphsp.rs:35:54
[INFO] [stderr]    |
[INFO] [stderr] 35 |     assert!(reader.header.max_energy.approx_eq_ulps(&0.19944459, 2),
[INFO] [stderr]    |                                                      ^^^^^^^^^^ help: consider: `0.199_444_59`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/egsphsp.rs:37:54
[INFO] [stderr]    |
[INFO] [stderr] 37 |     assert!(reader.header.min_energy.approx_eq_ulps(&0.012462342, 2),
[INFO] [stderr]    |                                                      ^^^^^^^^^^^ help: consider: `0.012_462_342`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/egsphsp.rs:52:54
[INFO] [stderr]    |
[INFO] [stderr] 52 |     assert!(reader.header.max_energy.approx_eq_ulps(&0.19944459, 2),
[INFO] [stderr]    |                                                      ^^^^^^^^^^ help: consider: `0.199_444_59`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/egsphsp.rs:54:54
[INFO] [stderr]    |
[INFO] [stderr] 54 |     assert!(reader.header.min_energy.approx_eq_ulps(&0.012462342, 2),
[INFO] [stderr]    |                                                      ^^^^^^^^^^^ help: consider: `0.012_462_342`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/egsphsp.rs:69:54
[INFO] [stderr]    |
[INFO] [stderr] 69 |     assert!(reader.header.max_energy.approx_eq_ulps(&0.19944459, 2),
[INFO] [stderr]    |                                                      ^^^^^^^^^^ help: consider: `0.199_444_59`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/egsphsp.rs:71:54
[INFO] [stderr]    |
[INFO] [stderr] 71 |     assert!(reader.header.min_energy.approx_eq_ulps(&0.012462342, 2),
[INFO] [stderr]    |                                                      ^^^^^^^^^^^ help: consider: `0.012_462_342`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> tests/egsphsp.rs:127:20
[INFO] [stderr]     |
[INFO] [stderr] 127 |         let path = String::from(format!("test_data/source{}.egsphsp1", i));
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("test_data/source{}.egsphsp1", i)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/bin.rs:16:56
[INFO] [stderr]    |
[INFO] [stderr] 16 |     s.trim().trim_left_matches("(").trim_right_matches(")").trim().parse::<f32>().unwrap()
[INFO] [stderr]    |                                                        ^^^ help: try using a char instead: `')'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/bin.rs:16:32
[INFO] [stderr]    |
[INFO] [stderr] 16 |     s.trim().trim_left_matches("(").trim_right_matches(")").trim().parse::<f32>().unwrap()
[INFO] [stderr]    |                                ^^^ help: try using a char instead: `'('`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/bin.rs:215:17
[INFO] [stderr]     |
[INFO] [stderr] 215 | /                 match field {
[INFO] [stderr] 216 | |                     &"weight" => print!("{:<16}", record.get_weight()),
[INFO] [stderr] 217 | |                     &"energy" => print!("{:<16}", record.total_energy()),
[INFO] [stderr] 218 | |                     &"x" => print!("{:<16}", record.x_cm),
[INFO] [stderr] ...   |
[INFO] [stderr] 225 | |                     _ => panic!("Unknown field {}", field)
[INFO] [stderr] 226 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 215 |                 match *field {
[INFO] [stderr] 216 |                     "weight" => print!("{:<16}", record.get_weight()),
[INFO] [stderr] 217 |                     "energy" => print!("{:<16}", record.total_energy()),
[INFO] [stderr] 218 |                     "x" => print!("{:<16}", record.x_cm),
[INFO] [stderr] 219 |                     "y" => print!("{:<16}", record.y_cm),
[INFO] [stderr] 220 |                     "x_cos" => print!("{:<16}", record.x_cos),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/bin.rs:16:56
[INFO] [stderr]    |
[INFO] [stderr] 16 |     s.trim().trim_left_matches("(").trim_right_matches(")").trim().parse::<f32>().unwrap()
[INFO] [stderr]    |                                                        ^^^ help: try using a char instead: `')'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/bin.rs:16:32
[INFO] [stderr]    |
[INFO] [stderr] 16 |     s.trim().trim_left_matches("(").trim_right_matches(")").trim().parse::<f32>().unwrap()
[INFO] [stderr]    |                                ^^^ help: try using a char instead: `'('`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/bin.rs:215:17
[INFO] [stderr]     |
[INFO] [stderr] 215 | /                 match field {
[INFO] [stderr] 216 | |                     &"weight" => print!("{:<16}", record.get_weight()),
[INFO] [stderr] 217 | |                     &"energy" => print!("{:<16}", record.total_energy()),
[INFO] [stderr] 218 | |                     &"x" => print!("{:<16}", record.x_cm),
[INFO] [stderr] ...   |
[INFO] [stderr] 225 | |                     _ => panic!("Unknown field {}", field)
[INFO] [stderr] 226 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 215 |                 match *field {
[INFO] [stderr] 216 |                     "weight" => print!("{:<16}", record.get_weight()),
[INFO] [stderr] 217 |                     "energy" => print!("{:<16}", record.total_energy()),
[INFO] [stderr] 218 |                     "x" => print!("{:<16}", record.x_cm),
[INFO] [stderr] 219 |                     "y" => print!("{:<16}", record.y_cm),
[INFO] [stderr] 220 |                     "x_cos" => print!("{:<16}", record.x_cos),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.30s
[INFO] running `"docker" "inspect" "cf6856af6a341e4479d592eb49fd7ba5f40a38a32e4f8d2079590ba99784162b"`
[INFO] running `"docker" "rm" "-f" "cf6856af6a341e4479d592eb49fd7ba5f40a38a32e4f8d2079590ba99784162b"`
[INFO] [stdout] cf6856af6a341e4479d592eb49fd7ba5f40a38a32e4f8d2079590ba99784162b