[INFO] crate beam_file 0.2.4 is already in cache [INFO] extracting crate beam_file 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/beam_file/0.2.4 [INFO] extracting crate beam_file 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/beam_file/0.2.4 [INFO] validating manifest of beam_file-0.2.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of beam_file-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing beam_file-0.2.4 [INFO] finished frobbing beam_file-0.2.4 [INFO] frobbed toml for beam_file-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/beam_file/0.2.4/Cargo.toml [INFO] started frobbing beam_file-0.2.4 [INFO] finished frobbing beam_file-0.2.4 [INFO] frobbed toml for beam_file-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/beam_file/0.2.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting beam_file-0.2.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/beam_file/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bc7cf0e37dd582fec1d50cc49b5f630eeda21f325675e1104bea49fe55b3539a [INFO] running `"docker" "start" "-a" "bc7cf0e37dd582fec1d50cc49b5f630eeda21f325675e1104bea49fe55b3539a"` [INFO] [stderr] Checking beam_file v0.2.4 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chunk.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | fn decode_data(id: &Id, reader: R) -> Result [INFO] [stderr] | ^^^ help: consider passing by value instead: `Id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chunk.rs:712:30 [INFO] [stderr] | [INFO] [stderr] 712 | pub fn new(chunk_id: &Id, data_size: u32) -> Self { [INFO] [stderr] | ^^^ help: consider passing by value instead: `Id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chunk.rs:735:35 [INFO] [stderr] | [INFO] [stderr] 735 | pub fn check_chunk_id(passed: &Id, expected: &Id) -> ::Result<()> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `Id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chunk.rs:735:50 [INFO] [stderr] | [INFO] [stderr] 735 | pub fn check_chunk_id(passed: &Id, expected: &Id) -> ::Result<()> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `Id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chunk.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | fn decode_data(id: &Id, reader: R) -> Result [INFO] [stderr] | ^^^ help: consider passing by value instead: `Id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chunk.rs:712:30 [INFO] [stderr] | [INFO] [stderr] 712 | pub fn new(chunk_id: &Id, data_size: u32) -> Self { [INFO] [stderr] | ^^^ help: consider passing by value instead: `Id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chunk.rs:735:35 [INFO] [stderr] | [INFO] [stderr] 735 | pub fn check_chunk_id(passed: &Id, expected: &Id) -> ::Result<()> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `Id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chunk.rs:735:50 [INFO] [stderr] | [INFO] [stderr] 735 | pub fn check_chunk_id(passed: &Id, expected: &Id) -> ::Result<()> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `Id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.09s [INFO] running `"docker" "inspect" "bc7cf0e37dd582fec1d50cc49b5f630eeda21f325675e1104bea49fe55b3539a"` [INFO] running `"docker" "rm" "-f" "bc7cf0e37dd582fec1d50cc49b5f630eeda21f325675e1104bea49fe55b3539a"` [INFO] [stdout] bc7cf0e37dd582fec1d50cc49b5f630eeda21f325675e1104bea49fe55b3539a