[INFO] crate bcrypt-bsd 0.1.3 is already in cache [INFO] extracting crate bcrypt-bsd 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/bcrypt-bsd/0.1.3 [INFO] extracting crate bcrypt-bsd 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bcrypt-bsd/0.1.3 [INFO] validating manifest of bcrypt-bsd-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bcrypt-bsd-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bcrypt-bsd-0.1.3 [INFO] finished frobbing bcrypt-bsd-0.1.3 [INFO] frobbed toml for bcrypt-bsd-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/bcrypt-bsd/0.1.3/Cargo.toml [INFO] started frobbing bcrypt-bsd-0.1.3 [INFO] finished frobbing bcrypt-bsd-0.1.3 [INFO] frobbed toml for bcrypt-bsd-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bcrypt-bsd/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bcrypt-bsd-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bcrypt-bsd/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0209fdcb359976422e73ce36f16e7e698c53c2dd28a4fee9d480e38f7ca73505 [INFO] running `"docker" "start" "-a" "0209fdcb359976422e73ce36f16e7e698c53c2dd28a4fee9d480e38f7ca73505"` [INFO] [stderr] Compiling bcrypt-bsd v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'gcc::Build': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> src/build.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | gcc::Build::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'gcc::Build::new': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> src/build.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | gcc::Build::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:62:8 [INFO] [stderr] | [INFO] [stderr] 62 | if password.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn to_str<'a>(bytes: &'a [u8]) -> Result<&'a str, CryptError> { [INFO] [stderr] 91 | | match CStr::from_bytes_with_nul(bytes) { [INFO] [stderr] 92 | | Ok(c_str) => { [INFO] [stderr] 93 | | match c_str.to_str() { [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:166:49 [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(to_str(&[114, 117, 115, 116, 097, 099, 101, 097, 110, 0]).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(to_str(&[114, 117, 115, 116, 97, 099, 101, 097, 110, 0]).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(to_str(&[114, 117, 115, 116, 0o97, 099, 101, 097, 110, 0]).unwrap(), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:166:54 [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(to_str(&[114, 117, 115, 116, 097, 099, 101, 097, 110, 0]).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(to_str(&[114, 117, 115, 116, 097, 99, 101, 097, 110, 0]).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(to_str(&[114, 117, 115, 116, 097, 0o99, 101, 097, 110, 0]).unwrap(), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:166:64 [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(to_str(&[114, 117, 115, 116, 097, 099, 101, 097, 110, 0]).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(to_str(&[114, 117, 115, 116, 097, 099, 101, 97, 110, 0]).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(to_str(&[114, 117, 115, 116, 097, 099, 101, 0o97, 110, 0]).unwrap(), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:168:46 [INFO] [stderr] | [INFO] [stderr] 168 | assert!(to_str(&[114, 117, 115, 116, 097, 099, 101, 097, 110]).is_err()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 168 | assert!(to_str(&[114, 117, 115, 116, 97, 099, 101, 097, 110]).is_err()); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 168 | assert!(to_str(&[114, 117, 115, 116, 0o97, 099, 101, 097, 110]).is_err()); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:168:51 [INFO] [stderr] | [INFO] [stderr] 168 | assert!(to_str(&[114, 117, 115, 116, 097, 099, 101, 097, 110]).is_err()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 168 | assert!(to_str(&[114, 117, 115, 116, 097, 99, 101, 097, 110]).is_err()); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 168 | assert!(to_str(&[114, 117, 115, 116, 097, 0o99, 101, 097, 110]).is_err()); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:168:61 [INFO] [stderr] | [INFO] [stderr] 168 | assert!(to_str(&[114, 117, 115, 116, 097, 099, 101, 097, 110]).is_err()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 168 | assert!(to_str(&[114, 117, 115, 116, 097, 099, 101, 97, 110]).is_err()); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 168 | assert!(to_str(&[114, 117, 115, 116, 097, 099, 101, 0o97, 110]).is_err()); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:169:46 [INFO] [stderr] | [INFO] [stderr] 169 | assert!(to_str(&[114, 117, 115, 116, 097, 099, 101, 097, 0, 110, 0]).is_err()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 169 | assert!(to_str(&[114, 117, 115, 116, 97, 099, 101, 097, 0, 110, 0]).is_err()); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 169 | assert!(to_str(&[114, 117, 115, 116, 0o97, 099, 101, 097, 0, 110, 0]).is_err()); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:169:51 [INFO] [stderr] | [INFO] [stderr] 169 | assert!(to_str(&[114, 117, 115, 116, 097, 099, 101, 097, 0, 110, 0]).is_err()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 169 | assert!(to_str(&[114, 117, 115, 116, 097, 99, 101, 097, 0, 110, 0]).is_err()); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 169 | assert!(to_str(&[114, 117, 115, 116, 097, 0o99, 101, 097, 0, 110, 0]).is_err()); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:169:61 [INFO] [stderr] | [INFO] [stderr] 169 | assert!(to_str(&[114, 117, 115, 116, 097, 099, 101, 097, 0, 110, 0]).is_err()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 169 | assert!(to_str(&[114, 117, 115, 116, 097, 099, 101, 97, 0, 110, 0]).is_err()); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 169 | assert!(to_str(&[114, 117, 115, 116, 097, 099, 101, 0o97, 0, 110, 0]).is_err()); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:62:8 [INFO] [stderr] | [INFO] [stderr] 62 | if password.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn to_str<'a>(bytes: &'a [u8]) -> Result<&'a str, CryptError> { [INFO] [stderr] 91 | | match CStr::from_bytes_with_nul(bytes) { [INFO] [stderr] 92 | | Ok(c_str) => { [INFO] [stderr] 93 | | match c_str.to_str() { [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.87s [INFO] running `"docker" "inspect" "0209fdcb359976422e73ce36f16e7e698c53c2dd28a4fee9d480e38f7ca73505"` [INFO] running `"docker" "rm" "-f" "0209fdcb359976422e73ce36f16e7e698c53c2dd28a4fee9d480e38f7ca73505"` [INFO] [stdout] 0209fdcb359976422e73ce36f16e7e698c53c2dd28a4fee9d480e38f7ca73505