[INFO] crate batteryd 0.1.1 is already in cache [INFO] extracting crate batteryd 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/batteryd/0.1.1 [INFO] extracting crate batteryd 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/batteryd/0.1.1 [INFO] validating manifest of batteryd-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of batteryd-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing batteryd-0.1.1 [INFO] finished frobbing batteryd-0.1.1 [INFO] frobbed toml for batteryd-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/batteryd/0.1.1/Cargo.toml [INFO] started frobbing batteryd-0.1.1 [INFO] finished frobbing batteryd-0.1.1 [INFO] frobbed toml for batteryd-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/batteryd/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting batteryd-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/batteryd/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36d9c792e579422c5770eed20570bfae3f0bae1d3fc4d7dcfd23846eb1b991ff [INFO] running `"docker" "start" "-a" "36d9c792e579422c5770eed20570bfae3f0bae1d3fc4d7dcfd23846eb1b991ff"` [INFO] [stderr] Checking batteryd v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `File` [INFO] [stderr] --> src/battery.rs:2:28 [INFO] [stderr] | [INFO] [stderr] 2 | use std::fs::{OpenOptions, File}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | fn battery_charging(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | fn battery_full(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:28:35 [INFO] [stderr] | [INFO] [stderr] 28 | fn battery_discharging(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | fn battery_low(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | fn battery_critical(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | fn battery_missing(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `index` [INFO] [stderr] --> src/battery.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | index: u32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `battery` [INFO] [stderr] --> src/estimation.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | battery: &'b Battery, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for crate [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / #![warn(missing_docs)] [INFO] [stderr] 2 | | [INFO] [stderr] 3 | | #[macro_use] [INFO] [stderr] 4 | | extern crate log; [INFO] [stderr] ... | [INFO] [stderr] 15 | | env!("CARGO_PKG_VERSION").to_string() [INFO] [stderr] 16 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![warn(missing_docs)] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a module [INFO] [stderr] --> src/lib.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub mod battery; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a variant [INFO] [stderr] --> src/battery.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Missing, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a variant [INFO] [stderr] --> src/battery.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | Discharging, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a variant [INFO] [stderr] --> src/battery.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Charging, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a variant [INFO] [stderr] --> src/battery.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Full, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `File` [INFO] [stderr] --> src/battery.rs:2:28 [INFO] [stderr] | [INFO] [stderr] 2 | use std::fs::{OpenOptions, File}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `battery::Battery` [INFO] [stderr] --> src/battery.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> Self { [INFO] [stderr] 60 | | Self::with_index(0) [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/battery.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/battery.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn with_index(index: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/battery.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn is_charging(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/battery.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn is_full(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/battery.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn status(&self) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/battery.rs:96:54 [INFO] [stderr] | [INFO] [stderr] 96 | OsStatus::from_str(&self.read_file("status").unwrap_or("Missing".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Missing".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/battery.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn is_present(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/battery.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn capacity(&self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a module [INFO] [stderr] --> src/lib.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub mod estimation; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a struct [INFO] [stderr] --> src/estimation.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub struct BatteryEstimator<'b> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/estimation.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new(battery: &'b Battery) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a module [INFO] [stderr] --> src/lib.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub mod events; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a struct [INFO] [stderr] --> src/events.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub struct BatteryEventPublisher<'b, 'r, T: 'r + BatteryEventSubscriber> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a trait [INFO] [stderr] --> src/events.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | pub trait BatteryEventSubscriber { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a trait method [INFO] [stderr] --> src/events.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | fn battery_charging(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a trait method [INFO] [stderr] --> src/events.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | fn battery_full(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a trait method [INFO] [stderr] --> src/events.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | fn battery_discharging(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a trait method [INFO] [stderr] --> src/events.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | fn battery_low(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a trait method [INFO] [stderr] --> src/events.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | fn battery_critical(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a trait method [INFO] [stderr] --> src/events.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | fn battery_missing(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/events.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn new(battery: &'b Battery, receiver: &'r T) -> BatteryEventPublisher<'b, 'r, T> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/events.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn run(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a module [INFO] [stderr] --> src/lib.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub mod notifications; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for an enum [INFO] [stderr] --> src/notifications.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub enum Urgency { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a variant [INFO] [stderr] --> src/notifications.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Low, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a variant [INFO] [stderr] --> src/notifications.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Normal, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a variant [INFO] [stderr] --> src/notifications.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Critical, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a struct [INFO] [stderr] --> src/notifications.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | pub struct NotificationOptions { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `notifications::NotificationOptions` [INFO] [stderr] --> src/notifications.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Self { [INFO] [stderr] 30 | | NotificationOptions { [INFO] [stderr] 31 | | title: String::new(), [INFO] [stderr] 32 | | text: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for notifications::NotificationOptions { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/notifications.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/notifications.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn title(&mut self, title: S) -> &mut Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/notifications.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn text(&mut self, text: S) -> &mut Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/notifications.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn icon(&mut self, icon: S) -> &mut Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/notifications.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn urgency(&mut self, urgency: Urgency) -> &mut Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/notifications.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn expire_time(&mut self, milliseconds: u32) -> &mut Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/notifications.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn eternal(&mut self) -> &mut Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/notifications.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn show(&self) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a module [INFO] [stderr] --> src/lib.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub mod notifier; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a struct [INFO] [stderr] --> src/notifier.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct Notifier {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `notifier::Notifier` [INFO] [stderr] --> src/notifier.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Notifier {} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/notifier.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a module [INFO] [stderr] --> src/lib.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub mod system; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | fn battery_charging(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | fn battery_full(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:28:35 [INFO] [stderr] | [INFO] [stderr] 28 | fn battery_discharging(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | fn battery_low(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | fn battery_critical(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `battery` [INFO] [stderr] --> src/events.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | fn battery_missing(&self, battery: &Battery) {} [INFO] [stderr] | ^^^^^^^ help: consider using `_battery` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `index` [INFO] [stderr] --> src/battery.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | index: u32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `battery` [INFO] [stderr] --> src/estimation.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | battery: &'b Battery, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `battery::Battery` [INFO] [stderr] --> src/battery.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> Self { [INFO] [stderr] 60 | | Self::with_index(0) [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/battery.rs:96:54 [INFO] [stderr] | [INFO] [stderr] 96 | OsStatus::from_str(&self.read_file("status").unwrap_or("Missing".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Missing".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `notifications::NotificationOptions` [INFO] [stderr] --> src/notifications.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Self { [INFO] [stderr] 30 | | NotificationOptions { [INFO] [stderr] 31 | | title: String::new(), [INFO] [stderr] 32 | | text: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for notifications::NotificationOptions { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `notifier::Notifier` [INFO] [stderr] --> src/notifier.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Notifier {} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.77s [INFO] running `"docker" "inspect" "36d9c792e579422c5770eed20570bfae3f0bae1d3fc4d7dcfd23846eb1b991ff"` [INFO] running `"docker" "rm" "-f" "36d9c792e579422c5770eed20570bfae3f0bae1d3fc4d7dcfd23846eb1b991ff"` [INFO] [stdout] 36d9c792e579422c5770eed20570bfae3f0bae1d3fc4d7dcfd23846eb1b991ff