[INFO] crate bat 0.9.0 is already in cache [INFO] extracting crate bat 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/bat/0.9.0 [INFO] extracting crate bat 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bat/0.9.0 [INFO] validating manifest of bat-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bat-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bat-0.9.0 [INFO] finished frobbing bat-0.9.0 [INFO] frobbed toml for bat-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/bat/0.9.0/Cargo.toml [INFO] started frobbing bat-0.9.0 [INFO] finished frobbing bat-0.9.0 [INFO] frobbed toml for bat-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bat/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bat-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bat/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 82f9fda96b8c6ff1a6717e587310128475127f0d5e7721d04b0f48907893799a [INFO] running `"docker" "start" "-a" "82f9fda96b8c6ff1a6717e587310128475127f0d5e7721d04b0f48907893799a"` [INFO] [stderr] Checking wild v2.0.1 [INFO] [stderr] Checking predicates v1.0.0 [INFO] [stderr] Compiling textwrap v0.10.0 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking plist v0.3.0 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Compiling clap v2.32.0 [INFO] [stderr] Checking escargot v0.3.1 [INFO] [stderr] Checking syntect v3.0.2 [INFO] [stderr] Checking assert_cmd v0.10.2 [INFO] [stderr] Compiling bat v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/printer.rs:320:17 [INFO] [stderr] | [INFO] [stderr] 320 | write!(handle, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/printer.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | write!(handle, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/printer.rs:320:17 [INFO] [stderr] | [INFO] [stderr] 320 | write!(handle, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/printer.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | write!(handle, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `BatTester` [INFO] [stderr] --> tests/tester.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Self { [INFO] [stderr] 25 | | let temp_dir = create_sample_directory().expect("sample directory"); [INFO] [stderr] 26 | | [INFO] [stderr] 27 | | let root = env::current_exe() [INFO] [stderr] ... | [INFO] [stderr] 38 | | BatTester { temp_dir, exe } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | impl Default for BatTester { [INFO] [stderr] 24 | fn default() -> Self { [INFO] [stderr] 25 | Self::new() [INFO] [stderr] 26 | } [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/app.rs:151:24 [INFO] [stderr] | [INFO] [stderr] 151 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 152 | | if self.interactive_output { [INFO] [stderr] 153 | | PagingMode::QuitIfOneScreen [INFO] [stderr] 154 | | } else { [INFO] [stderr] 155 | | PagingMode::Never [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | } else if self.interactive_output { [INFO] [stderr] 152 | PagingMode::QuitIfOneScreen [INFO] [stderr] 153 | } else { [INFO] [stderr] 154 | PagingMode::Never [INFO] [stderr] 155 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/assets.rs:195:17 [INFO] [stderr] | [INFO] [stderr] 195 | syntax [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/assets.rs:194:30 [INFO] [stderr] | [INFO] [stderr] 194 | let syntax = ext_syntax.or(line_syntax); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/line_range.rs:114:16 [INFO] [stderr] | [INFO] [stderr] 114 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 115 | | if self.ranges.iter().any(|r| r.is_inside(line)) { [INFO] [stderr] 116 | | RangeCheckResult::InRange [INFO] [stderr] 117 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 114 | } else if self.ranges.iter().any(|r| r.is_inside(line)) { [INFO] [stderr] 115 | RangeCheckResult::InRange [INFO] [stderr] 116 | } else { [INFO] [stderr] 117 | if line < self.largest_upper_bound { [INFO] [stderr] 118 | RangeCheckResult::OutsideRange [INFO] [stderr] 119 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/line_range.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 118 | | if line < self.largest_upper_bound { [INFO] [stderr] 119 | | RangeCheckResult::OutsideRange [INFO] [stderr] 120 | | } else { [INFO] [stderr] 121 | | RangeCheckResult::AfterLastRange [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 117 | } else if line < self.largest_upper_bound { [INFO] [stderr] 118 | RangeCheckResult::OutsideRange [INFO] [stderr] 119 | } else { [INFO] [stderr] 120 | RangeCheckResult::AfterLastRange [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/app.rs:151:24 [INFO] [stderr] | [INFO] [stderr] 151 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 152 | | if self.interactive_output { [INFO] [stderr] 153 | | PagingMode::QuitIfOneScreen [INFO] [stderr] 154 | | } else { [INFO] [stderr] 155 | | PagingMode::Never [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | } else if self.interactive_output { [INFO] [stderr] 152 | PagingMode::QuitIfOneScreen [INFO] [stderr] 153 | } else { [INFO] [stderr] 154 | PagingMode::Never [INFO] [stderr] 155 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/assets.rs:195:17 [INFO] [stderr] | [INFO] [stderr] 195 | syntax [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/assets.rs:194:30 [INFO] [stderr] | [INFO] [stderr] 194 | let syntax = ext_syntax.or(line_syntax); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/line_range.rs:114:16 [INFO] [stderr] | [INFO] [stderr] 114 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 115 | | if self.ranges.iter().any(|r| r.is_inside(line)) { [INFO] [stderr] 116 | | RangeCheckResult::InRange [INFO] [stderr] 117 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 114 | } else if self.ranges.iter().any(|r| r.is_inside(line)) { [INFO] [stderr] 115 | RangeCheckResult::InRange [INFO] [stderr] 116 | } else { [INFO] [stderr] 117 | if line < self.largest_upper_bound { [INFO] [stderr] 118 | RangeCheckResult::OutsideRange [INFO] [stderr] 119 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/line_range.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 118 | | if line < self.largest_upper_bound { [INFO] [stderr] 119 | | RangeCheckResult::OutsideRange [INFO] [stderr] 120 | | } else { [INFO] [stderr] 121 | | RangeCheckResult::AfterLastRange [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 117 | } else if line < self.largest_upper_bound { [INFO] [stderr] 118 | RangeCheckResult::OutsideRange [INFO] [stderr] 119 | } else { [INFO] [stderr] 120 | RangeCheckResult::AfterLastRange [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/app.rs:119:33 [INFO] [stderr] | [INFO] [stderr] 119 | .unwrap_or_else(|| get_args_from_config_file()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `get_args_from_config_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:165:51 [INFO] [stderr] | [INFO] [stderr] 165 | let parts: Vec<_> = from_to.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:212:38 [INFO] [stderr] | [INFO] [stderr] 212 | if w.starts_with("+") || w.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:212:60 [INFO] [stderr] | [INFO] [stderr] 212 | if w.starts_with("+") || w.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:216:50 [INFO] [stderr] | [INFO] [stderr] 216 | let new_width: i32 = old_width as i32 + delta as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(old_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:216:69 [INFO] [stderr] | [INFO] [stderr] 216 | let new_width: i32 = old_width as i32 + delta as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/app.rs:251:18 [INFO] [stderr] | [INFO] [stderr] 251 | .unwrap_or(String::from(BAT_THEME_DEFAULT)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(BAT_THEME_DEFAULT))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/app.rs:258:18 [INFO] [stderr] | [INFO] [stderr] 258 | .unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:300:36 [INFO] [stderr] | [INFO] [stderr] 300 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/app.rs:315:22 [INFO] [stderr] | [INFO] [stderr] 315 | .unwrap_or(vec![OutputComponent::Full]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![OutputComponent::Full])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:309:36 [INFO] [stderr] | [INFO] [stderr] 309 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/assets.rs:43:12 [INFO] [stderr] | [INFO] [stderr] 43 | if !res.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `res.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/clap_app.rs:112:54 [INFO] [stderr] | [INFO] [stderr] 112 | let mut invalid_vals = val.split(",").filter(|style| { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:16:10 [INFO] [stderr] | [INFO] [stderr] 16 | .unwrap_or(PROJECT_DIRS.config_dir().join("config")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PROJECT_DIRS.config_dir().join("config"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:25:6 [INFO] [stderr] | [INFO] [stderr] 25 | .unwrap_or(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / fn get_args_from_str<'a>(content: &'a str) -> Result, shell_words::ParseError> { [INFO] [stderr] 33 | | let args_per_line = content [INFO] [stderr] 34 | | .split('\n') [INFO] [stderr] 35 | | .map(|line| line.trim()) [INFO] [stderr] ... | [INFO] [stderr] 45 | | .collect()) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config.rs:37:42 [INFO] [stderr] | [INFO] [stderr] 37 | .filter(|line| !line.starts_with("#")) [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/app.rs:119:33 [INFO] [stderr] | [INFO] [stderr] 119 | .unwrap_or_else(|| get_args_from_config_file()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `get_args_from_config_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/controller.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | fn print_file_ranges<'a, P: Printer>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:165:51 [INFO] [stderr] | [INFO] [stderr] 165 | let parts: Vec<_> = from_to.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:212:38 [INFO] [stderr] | [INFO] [stderr] 212 | if w.starts_with("+") || w.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:212:60 [INFO] [stderr] | [INFO] [stderr] 212 | if w.starts_with("+") || w.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:216:50 [INFO] [stderr] | [INFO] [stderr] 216 | let new_width: i32 = old_width as i32 + delta as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(old_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:216:69 [INFO] [stderr] | [INFO] [stderr] 216 | let new_width: i32 = old_width as i32 + delta as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/app.rs:251:18 [INFO] [stderr] | [INFO] [stderr] 251 | .unwrap_or(String::from(BAT_THEME_DEFAULT)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(BAT_THEME_DEFAULT))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/app.rs:258:18 [INFO] [stderr] | [INFO] [stderr] 258 | .unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:300:36 [INFO] [stderr] | [INFO] [stderr] 300 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/app.rs:315:22 [INFO] [stderr] | [INFO] [stderr] 315 | .unwrap_or(vec![OutputComponent::Full]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![OutputComponent::Full])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:309:36 [INFO] [stderr] | [INFO] [stderr] 309 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/assets.rs:43:12 [INFO] [stderr] | [INFO] [stderr] 43 | if !res.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `res.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/clap_app.rs:112:54 [INFO] [stderr] | [INFO] [stderr] 112 | let mut invalid_vals = val.split(",").filter(|style| { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:16:10 [INFO] [stderr] | [INFO] [stderr] 16 | .unwrap_or(PROJECT_DIRS.config_dir().join("config")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PROJECT_DIRS.config_dir().join("config"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:25:6 [INFO] [stderr] | [INFO] [stderr] 25 | .unwrap_or(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / fn get_args_from_str<'a>(content: &'a str) -> Result, shell_words::ParseError> { [INFO] [stderr] 33 | | let args_per_line = content [INFO] [stderr] 34 | | .split('\n') [INFO] [stderr] 35 | | .map(|line| line.trim()) [INFO] [stderr] ... | [INFO] [stderr] 45 | | .collect()) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config.rs:37:42 [INFO] [stderr] | [INFO] [stderr] 37 | .filter(|line| !line.starts_with("#")) [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `line_range::LineRange` [INFO] [stderr] --> src/line_range.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> LineRange { [INFO] [stderr] 15 | | LineRange { [INFO] [stderr] 16 | | lower: usize::min_value(), [INFO] [stderr] 17 | | upper: usize::max_value(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/controller.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | fn print_file_ranges<'a, P: Printer>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `line_range::LineRange` [INFO] [stderr] --> src/line_range.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> LineRange { [INFO] [stderr] 15 | | LineRange { [INFO] [stderr] 16 | | lower: usize::min_value(), [INFO] [stderr] 17 | | upper: usize::max_value(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/output.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | .unwrap_or(String::from("less")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("less"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/output.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | .or(pager_from_env.ok()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| pager_from_env.ok())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/printer.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | handle.write(line_buffer)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/output.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | .unwrap_or(String::from("less")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("less"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/output.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | .or(pager_from_env.ok()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| pager_from_env.ok())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/printer.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | handle.write(line_buffer)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/printer.rs:260:18 [INFO] [stderr] | [INFO] [stderr] 260 | .unwrap_or("Invalid UTF-16LE".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Invalid UTF-16LE".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/printer.rs:263:18 [INFO] [stderr] | [INFO] [stderr] 263 | .unwrap_or("Invalid UTF-16BE".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Invalid UTF-16BE".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `replace_nonprintable` doesn't need a mutable reference [INFO] [stderr] --> src/printer.rs:268:41 [INFO] [stderr] | [INFO] [stderr] 268 | line = replace_nonprintable(&mut line, self.config.tab_width); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/style.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn components(&self, interactive_terminal: bool) -> &'static [OutputComponent] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `syntax_mapping::SyntaxMapping` [INFO] [stderr] --> src/syntax_mapping.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> SyntaxMapping { [INFO] [stderr] 9 | | SyntaxMapping(HashMap::new()) [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/printer.rs:260:18 [INFO] [stderr] | [INFO] [stderr] 260 | .unwrap_or("Invalid UTF-16LE".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Invalid UTF-16LE".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/printer.rs:263:18 [INFO] [stderr] | [INFO] [stderr] 263 | .unwrap_or("Invalid UTF-16BE".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Invalid UTF-16BE".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `replace_nonprintable` doesn't need a mutable reference [INFO] [stderr] --> src/printer.rs:268:41 [INFO] [stderr] | [INFO] [stderr] 268 | line = replace_nonprintable(&mut line, self.config.tab_width); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/style.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn components(&self, interactive_terminal: bool) -> &'static [OutputComponent] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `syntax_mapping::SyntaxMapping` [INFO] [stderr] --> src/syntax_mapping.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> SyntaxMapping { [INFO] [stderr] 9 | | SyntaxMapping(HashMap::new()) [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match error { [INFO] [stderr] 70 | | &Error(ErrorKind::Io(ref io_error), _) [INFO] [stderr] 71 | | if io_error.kind() == super::io::ErrorKind::BrokenPipe => [INFO] [stderr] 72 | | { [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *error { [INFO] [stderr] 70 | Error(ErrorKind::Io(ref io_error), _) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match error { [INFO] [stderr] 70 | | &Error(ErrorKind::Io(ref io_error), _) [INFO] [stderr] 71 | | if io_error.kind() == super::io::ErrorKind::BrokenPipe => [INFO] [stderr] 72 | | { [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *error { [INFO] [stderr] 70 | Error(ErrorKind::Io(ref io_error), _) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bat`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bat`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "82f9fda96b8c6ff1a6717e587310128475127f0d5e7721d04b0f48907893799a"` [INFO] running `"docker" "rm" "-f" "82f9fda96b8c6ff1a6717e587310128475127f0d5e7721d04b0f48907893799a"` [INFO] [stdout] 82f9fda96b8c6ff1a6717e587310128475127f0d5e7721d04b0f48907893799a