[INFO] crate basic_scheduler 0.1.1 is already in cache [INFO] extracting crate basic_scheduler 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/basic_scheduler/0.1.1 [INFO] extracting crate basic_scheduler 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/basic_scheduler/0.1.1 [INFO] validating manifest of basic_scheduler-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of basic_scheduler-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing basic_scheduler-0.1.1 [INFO] finished frobbing basic_scheduler-0.1.1 [INFO] frobbed toml for basic_scheduler-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/basic_scheduler/0.1.1/Cargo.toml [INFO] started frobbing basic_scheduler-0.1.1 [INFO] finished frobbing basic_scheduler-0.1.1 [INFO] frobbed toml for basic_scheduler-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/basic_scheduler/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting basic_scheduler-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/basic_scheduler/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1ba4f4ddc827d50010bc212ce583db5957ea62b896b695126daf1cc3a292e080 [INFO] running `"docker" "start" "-a" "1ba4f4ddc827d50010bc212ce583db5957ea62b896b695126daf1cc3a292e080"` [INFO] [stderr] Checking basic_scheduler v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/events.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | task: task [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `task` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/events.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | task: task [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `task` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/lib.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Scheduler` [INFO] [stderr] --> src/lib.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | let (tx,rx) = channel(); [INFO] [stderr] 25 | | Scheduler { [INFO] [stderr] 26 | | stuff: vec!(), [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for Scheduler { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self.new_items_rx.recv_timeout(time_to_next.to_std().unwrap()) { [INFO] [stderr] 48 | | Ok(evt) => { [INFO] [stderr] 49 | | //println!("PING"); [INFO] [stderr] 50 | | let mut new_evts: Vec<_> = [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | if let Ok(evt) = self.new_items_rx.recv_timeout(time_to_next.to_std().unwrap()) { [INFO] [stderr] 48 | //println!("PING"); [INFO] [stderr] 49 | let mut new_evts: Vec<_> = [INFO] [stderr] 50 | self.new_items_rx.try_iter().fold(vec![evt], |mut acc, x| { [INFO] [stderr] 51 | acc.push(x); [INFO] [stderr] 52 | acc [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match evt.execute() { [INFO] [stderr] 70 | | Some(d) => { [INFO] [stderr] 71 | | // reschedule [INFO] [stderr] 72 | | self.insert(ScheduledEvent { [INFO] [stderr] ... | [INFO] [stderr] 77 | | None => {} // Nothing to reschedule [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | if let Some(d) = evt.execute() { [INFO] [stderr] 70 | // reschedule [INFO] [stderr] 71 | self.insert(ScheduledEvent { [INFO] [stderr] 72 | when_next: Utc::now() + d, [INFO] [stderr] 73 | what: evt, [INFO] [stderr] 74 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | if self.stuff.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.stuff.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:90:24 [INFO] [stderr] | [INFO] [stderr] 90 | let next = self.stuff [INFO] [stderr] | ________________________^ [INFO] [stderr] 91 | | .get(0) [INFO] [stderr] 92 | | .unwrap() [INFO] [stderr] | |_________________________^ help: try this: `&self.stuff[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Scheduler` [INFO] [stderr] --> src/lib.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | let (tx,rx) = channel(); [INFO] [stderr] 25 | | Scheduler { [INFO] [stderr] 26 | | stuff: vec!(), [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for Scheduler { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self.new_items_rx.recv_timeout(time_to_next.to_std().unwrap()) { [INFO] [stderr] 48 | | Ok(evt) => { [INFO] [stderr] 49 | | //println!("PING"); [INFO] [stderr] 50 | | let mut new_evts: Vec<_> = [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | if let Ok(evt) = self.new_items_rx.recv_timeout(time_to_next.to_std().unwrap()) { [INFO] [stderr] 48 | //println!("PING"); [INFO] [stderr] 49 | let mut new_evts: Vec<_> = [INFO] [stderr] 50 | self.new_items_rx.try_iter().fold(vec![evt], |mut acc, x| { [INFO] [stderr] 51 | acc.push(x); [INFO] [stderr] 52 | acc [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match evt.execute() { [INFO] [stderr] 70 | | Some(d) => { [INFO] [stderr] 71 | | // reschedule [INFO] [stderr] 72 | | self.insert(ScheduledEvent { [INFO] [stderr] ... | [INFO] [stderr] 77 | | None => {} // Nothing to reschedule [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | if let Some(d) = evt.execute() { [INFO] [stderr] 70 | // reschedule [INFO] [stderr] 71 | self.insert(ScheduledEvent { [INFO] [stderr] 72 | when_next: Utc::now() + d, [INFO] [stderr] 73 | what: evt, [INFO] [stderr] 74 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | if self.stuff.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.stuff.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:90:24 [INFO] [stderr] | [INFO] [stderr] 90 | let next = self.stuff [INFO] [stderr] | ________________________^ [INFO] [stderr] 91 | | .get(0) [INFO] [stderr] 92 | | .unwrap() [INFO] [stderr] | |_________________________^ help: try this: `&self.stuff[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.23s [INFO] running `"docker" "inspect" "1ba4f4ddc827d50010bc212ce583db5957ea62b896b695126daf1cc3a292e080"` [INFO] running `"docker" "rm" "-f" "1ba4f4ddc827d50010bc212ce583db5957ea62b896b695126daf1cc3a292e080"` [INFO] [stdout] 1ba4f4ddc827d50010bc212ce583db5957ea62b896b695126daf1cc3a292e080