[INFO] crate basic-otp 0.1.1 is already in cache [INFO] extracting crate basic-otp 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/basic-otp/0.1.1 [INFO] extracting crate basic-otp 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/basic-otp/0.1.1 [INFO] validating manifest of basic-otp-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of basic-otp-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing basic-otp-0.1.1 [INFO] finished frobbing basic-otp-0.1.1 [INFO] frobbed toml for basic-otp-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/basic-otp/0.1.1/Cargo.toml [INFO] started frobbing basic-otp-0.1.1 [INFO] finished frobbing basic-otp-0.1.1 [INFO] frobbed toml for basic-otp-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/basic-otp/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting basic-otp-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/basic-otp/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f32b00d5ddf96c981bac6f540d33d6db2b5f424f069a3b1c97c7e053b9e3621b [INFO] running `"docker" "start" "-a" "f32b00d5ddf96c981bac6f540d33d6db2b5f424f069a3b1c97c7e053b9e3621b"` [INFO] [stderr] Checking basic-otp v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:19:56 [INFO] [stderr] | [INFO] [stderr] 19 | let s_num = rdr.read_u32::().unwrap() & 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:35:51 [INFO] [stderr] | [INFO] [stderr] 35 | let slot = (now.as_secs()/TIME_STEP) as i64 + slot_offset as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(slot_offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:19:56 [INFO] [stderr] | [INFO] [stderr] 19 | let s_num = rdr.read_u32::().unwrap() & 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | const KEY : &'static [u8] = b"12345678901234567890"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:59:42 [INFO] [stderr] | [INFO] [stderr] 59 | assert_eq!(hotp(KEY, 0, DIGITS), 755224); [INFO] [stderr] | ^^^^^^ help: consider: `755_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:60:42 [INFO] [stderr] | [INFO] [stderr] 60 | assert_eq!(hotp(KEY, 1, DIGITS), 287082); [INFO] [stderr] | ^^^^^^ help: consider: `287_082` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:61:42 [INFO] [stderr] | [INFO] [stderr] 61 | assert_eq!(hotp(KEY, 2, DIGITS), 359152); [INFO] [stderr] | ^^^^^^ help: consider: `359_152` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:62:42 [INFO] [stderr] | [INFO] [stderr] 62 | assert_eq!(hotp(KEY, 3, DIGITS), 969429); [INFO] [stderr] | ^^^^^^ help: consider: `969_429` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | assert_eq!(hotp(KEY, 4, DIGITS), 338314); [INFO] [stderr] | ^^^^^^ help: consider: `338_314` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:64:42 [INFO] [stderr] | [INFO] [stderr] 64 | assert_eq!(hotp(KEY, 5, DIGITS), 254676); [INFO] [stderr] | ^^^^^^ help: consider: `254_676` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:65:42 [INFO] [stderr] | [INFO] [stderr] 65 | assert_eq!(hotp(KEY, 6, DIGITS), 287922); [INFO] [stderr] | ^^^^^^ help: consider: `287_922` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:35:51 [INFO] [stderr] | [INFO] [stderr] 35 | let slot = (now.as_secs()/TIME_STEP) as i64 + slot_offset as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(slot_offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.62s [INFO] running `"docker" "inspect" "f32b00d5ddf96c981bac6f540d33d6db2b5f424f069a3b1c97c7e053b9e3621b"` [INFO] running `"docker" "rm" "-f" "f32b00d5ddf96c981bac6f540d33d6db2b5f424f069a3b1c97c7e053b9e3621b"` [INFO] [stdout] f32b00d5ddf96c981bac6f540d33d6db2b5f424f069a3b1c97c7e053b9e3621b