[INFO] crate basenc 0.1.0 is already in cache [INFO] extracting crate basenc 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/basenc/0.1.0 [INFO] extracting crate basenc 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/basenc/0.1.0 [INFO] validating manifest of basenc-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of basenc-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing basenc-0.1.0 [INFO] finished frobbing basenc-0.1.0 [INFO] frobbed toml for basenc-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/basenc/0.1.0/Cargo.toml [INFO] started frobbing basenc-0.1.0 [INFO] finished frobbing basenc-0.1.0 [INFO] frobbed toml for basenc-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/basenc/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting basenc-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/basenc/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 50d0371c8e7bd984f0e435b3da27454a48a7f07f98b9e034ce48f7ed9b5861c3 [INFO] running `"docker" "start" "-a" "50d0371c8e7bd984f0e435b3da27454a48a7f07f98b9e034ce48f7ed9b5861c3"` [INFO] [stderr] Checking basenc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/base64/encode.rs:164:4 [INFO] [stderr] | [INFO] [stderr] 164 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/base64/encode.rs:165:4 [INFO] [stderr] | [INFO] [stderr] 165 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/base64/decode.rs:108:4 [INFO] [stderr] | [INFO] [stderr] 108 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/base64/decode.rs:109:4 [INFO] [stderr] | [INFO] [stderr] 109 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/hex/encode.rs:76:4 [INFO] [stderr] | [INFO] [stderr] 76 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/hex/encode.rs:77:4 [INFO] [stderr] | [INFO] [stderr] 77 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/hex/decode.rs:19:4 [INFO] [stderr] | [INFO] [stderr] 19 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/hex/decode.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/base64/encode.rs:164:4 [INFO] [stderr] | [INFO] [stderr] 164 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/base64/encode.rs:165:4 [INFO] [stderr] | [INFO] [stderr] 165 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/base64/decode.rs:108:4 [INFO] [stderr] | [INFO] [stderr] 108 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/base64/decode.rs:109:4 [INFO] [stderr] | [INFO] [stderr] 109 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/hex/encode.rs:76:4 [INFO] [stderr] | [INFO] [stderr] 76 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/hex/encode.rs:77:4 [INFO] [stderr] | [INFO] [stderr] 77 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/hex/decode.rs:19:4 [INFO] [stderr] | [INFO] [stderr] 19 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/details/hex/decode.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/buf.rs:91:19 [INFO] [stderr] | [INFO] [stderr] 91 | unsafe fn commit(mut self, len: usize) -> Self::Output { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/buf.rs:188:19 [INFO] [stderr] | [INFO] [stderr] 188 | unsafe fn commit(mut self, len: usize) -> Self::Output { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/buf.rs:209:19 [INFO] [stderr] | [INFO] [stderr] 209 | unsafe fn commit(mut self, len: usize) -> Self::Output { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/details/base64/encode.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 196 | for (i, ) in buf.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/details/base64/decode.rs:128:26 [INFO] [stderr] | [INFO] [stderr] 128 | buf = (buf << 6) | (byte as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/details/base64/decode.rs:155:6 [INFO] [stderr] | [INFO] [stderr] 155 | buf = buf << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buf <<= 6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/details/base64/decode.rs:161:6 [INFO] [stderr] | [INFO] [stderr] 161 | buf = buf << 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `buf <<= 12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/details/base64/mod.rs:141:27 [INFO] [stderr] | [INFO] [stderr] 141 | pub struct EncoderT(iter::FlatMap< [INFO] [stderr] | ___________________________^ [INFO] [stderr] 142 | | encode::ChunkAdapter, C>, [INFO] [stderr] 143 | | encode::Chars, [INFO] [stderr] 144 | | fn(encode::Chars) -> encode::Chars [INFO] [stderr] 145 | | >); [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/details/base64/mod.rs:171:27 [INFO] [stderr] | [INFO] [stderr] 171 | pub struct DecoderT(iter::FlatMap< [INFO] [stderr] | ___________________________^ [INFO] [stderr] 172 | | iter::Map< [INFO] [stderr] 173 | | decode::ChunkAdapter, C>, [INFO] [stderr] 174 | | fn(Result) -> super::ResultFlatMap, [INFO] [stderr] ... | [INFO] [stderr] 177 | | fn(super::ResultFlatMap) -> super::ResultFlatMap, [INFO] [stderr] 178 | | >); [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/details/base64/mod.rs:233:7 [INFO] [stderr] | [INFO] [stderr] 233 | *ptr.offset(index as isize) = chr as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/details/base64/mod.rs:256:7 [INFO] [stderr] | [INFO] [stderr] 256 | *ptr.offset(index as isize) = item?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/details/hex/mod.rs:133:27 [INFO] [stderr] | [INFO] [stderr] 133 | pub struct EncoderT(::core::iter::FlatMap, encode::Chars, fn(encode::Chars) -> encode::Chars>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/details/hex/mod.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | *ptr.offset(index as isize) = chars.high() as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/details/hex/mod.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | *ptr.offset(index as isize) = item?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | self.as_mut_ptr().offset(self.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:89:3 [INFO] [stderr] | [INFO] [stderr] 89 | self.as_mut_ptr().offset(self.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | from_raw_parts(self.as_ptr().offset(start as isize), len) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | vec.as_mut_ptr().offset(vec.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(vec.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:186:3 [INFO] [stderr] | [INFO] [stderr] 186 | vec.as_mut_ptr().offset(vec.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(vec.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:193:38 [INFO] [stderr] | [INFO] [stderr] 193 | from_utf8_unchecked(from_raw_parts(vec.as_ptr().offset(start as isize), len)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_ptr().add(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:207:3 [INFO] [stderr] | [INFO] [stderr] 207 | self.as_mut_ptr().offset(self.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:212:38 [INFO] [stderr] | [INFO] [stderr] 212 | from_utf8_unchecked(from_raw_parts(self.as_ptr().offset(start as isize), len)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/buf.rs:91:19 [INFO] [stderr] | [INFO] [stderr] 91 | unsafe fn commit(mut self, len: usize) -> Self::Output { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/buf.rs:188:19 [INFO] [stderr] | [INFO] [stderr] 188 | unsafe fn commit(mut self, len: usize) -> Self::Output { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/buf.rs:209:19 [INFO] [stderr] | [INFO] [stderr] 209 | unsafe fn commit(mut self, len: usize) -> Self::Output { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/details/base64/encode.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 196 | for (i, ) in buf.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/details/base64/decode.rs:128:26 [INFO] [stderr] | [INFO] [stderr] 128 | buf = (buf << 6) | (byte as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/details/base64/decode.rs:155:6 [INFO] [stderr] | [INFO] [stderr] 155 | buf = buf << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buf <<= 6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/details/base64/decode.rs:161:6 [INFO] [stderr] | [INFO] [stderr] 161 | buf = buf << 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `buf <<= 12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/details/base64/mod.rs:141:27 [INFO] [stderr] | [INFO] [stderr] 141 | pub struct EncoderT(iter::FlatMap< [INFO] [stderr] | ___________________________^ [INFO] [stderr] 142 | | encode::ChunkAdapter, C>, [INFO] [stderr] 143 | | encode::Chars, [INFO] [stderr] 144 | | fn(encode::Chars) -> encode::Chars [INFO] [stderr] 145 | | >); [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/details/base64/mod.rs:171:27 [INFO] [stderr] | [INFO] [stderr] 171 | pub struct DecoderT(iter::FlatMap< [INFO] [stderr] | ___________________________^ [INFO] [stderr] 172 | | iter::Map< [INFO] [stderr] 173 | | decode::ChunkAdapter, C>, [INFO] [stderr] 174 | | fn(Result) -> super::ResultFlatMap, [INFO] [stderr] ... | [INFO] [stderr] 177 | | fn(super::ResultFlatMap) -> super::ResultFlatMap, [INFO] [stderr] 178 | | >); [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/details/base64/mod.rs:233:7 [INFO] [stderr] | [INFO] [stderr] 233 | *ptr.offset(index as isize) = chr as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/details/base64/mod.rs:256:7 [INFO] [stderr] | [INFO] [stderr] 256 | *ptr.offset(index as isize) = item?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/details/base64/tests.rs:101:49 [INFO] [stderr] | [INFO] [stderr] 101 | println!("{}: ({}, &{:?})", name, base, &table[base..end + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `base..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/details/hex/mod.rs:133:27 [INFO] [stderr] | [INFO] [stderr] 133 | pub struct EncoderT(::core::iter::FlatMap, encode::Chars, fn(encode::Chars) -> encode::Chars>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/details/hex/mod.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | *ptr.offset(index as isize) = chars.high() as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/details/hex/mod.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | *ptr.offset(index as isize) = item?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/details/hex/tests.rs:50:49 [INFO] [stderr] | [INFO] [stderr] 50 | println!("{}: ({}, &{:?})", name, base, &table[base..end + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `base..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | self.as_mut_ptr().offset(self.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:89:3 [INFO] [stderr] | [INFO] [stderr] 89 | self.as_mut_ptr().offset(self.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | from_raw_parts(self.as_ptr().offset(start as isize), len) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | vec.as_mut_ptr().offset(vec.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(vec.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:186:3 [INFO] [stderr] | [INFO] [stderr] 186 | vec.as_mut_ptr().offset(vec.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(vec.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:193:38 [INFO] [stderr] | [INFO] [stderr] 193 | from_utf8_unchecked(from_raw_parts(vec.as_ptr().offset(start as isize), len)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_ptr().add(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:207:3 [INFO] [stderr] | [INFO] [stderr] 207 | self.as_mut_ptr().offset(self.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(self.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buf.rs:212:38 [INFO] [stderr] | [INFO] [stderr] 212 | from_utf8_unchecked(from_raw_parts(self.as_ptr().offset(start as isize), len)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.52s [INFO] running `"docker" "inspect" "50d0371c8e7bd984f0e435b3da27454a48a7f07f98b9e034ce48f7ed9b5861c3"` [INFO] running `"docker" "rm" "-f" "50d0371c8e7bd984f0e435b3da27454a48a7f07f98b9e034ce48f7ed9b5861c3"` [INFO] [stdout] 50d0371c8e7bd984f0e435b3da27454a48a7f07f98b9e034ce48f7ed9b5861c3