[INFO] crate base64-url 1.1.7 is already in cache [INFO] extracting crate base64-url 1.1.7 into work/ex/clippy-test-run/sources/stable/reg/base64-url/1.1.7 [INFO] extracting crate base64-url 1.1.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/base64-url/1.1.7 [INFO] validating manifest of base64-url-1.1.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of base64-url-1.1.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing base64-url-1.1.7 [INFO] finished frobbing base64-url-1.1.7 [INFO] frobbed toml for base64-url-1.1.7 written to work/ex/clippy-test-run/sources/stable/reg/base64-url/1.1.7/Cargo.toml [INFO] started frobbing base64-url-1.1.7 [INFO] finished frobbing base64-url-1.1.7 [INFO] frobbed toml for base64-url-1.1.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/base64-url/1.1.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting base64-url-1.1.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/base64-url/1.1.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e1202e2fae80d6974a3ec6c8ab99b6bb145536ef6e9101f58522a4a41a0bb63f [INFO] running `"docker" "start" "-a" "e1202e2fae80d6974a3ec6c8ab99b6bb145536ef6e9101f58522a4a41a0bb63f"` [INFO] [stderr] Checking base64-url v1.1.7 (/opt/crater/workdir) [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `len` [INFO] [stderr] --> src/decode.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | (len + 3 / 4) * 3 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `len` [INFO] [stderr] --> src/decode.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | (len + 3 / 4) * 3 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/unescape.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | assert_eq!("https://magiclen.org".as_bytes().to_vec(), base64::decode(&base64_url::unsafe_unescape("aHR0cHM6Ly9tYWdpY2xlbi5vcmc")).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"https://magiclen.org"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/decode.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | assert_eq!("https://magiclen.org".as_bytes().to_vec(), base64_url::decode("aHR0cHM6Ly9tYWdpY2xlbi5vcmc").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"https://magiclen.org"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/decode.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | let url = "https://magiclen.org/".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"https://magiclen.org/"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/decode.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | assert_eq!("https://magiclen.org/articles".as_bytes().to_vec(), base64_url::decode_and_push_to_vec("YXJ0aWNsZXM", url).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"https://magiclen.org/articles"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.86s [INFO] running `"docker" "inspect" "e1202e2fae80d6974a3ec6c8ab99b6bb145536ef6e9101f58522a4a41a0bb63f"` [INFO] running `"docker" "rm" "-f" "e1202e2fae80d6974a3ec6c8ab99b6bb145536ef6e9101f58522a4a41a0bb63f"` [INFO] [stdout] e1202e2fae80d6974a3ec6c8ab99b6bb145536ef6e9101f58522a4a41a0bb63f