[INFO] crate base64 0.10.0 is already in cache [INFO] extracting crate base64 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/base64/0.10.0 [INFO] extracting crate base64 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/base64/0.10.0 [INFO] validating manifest of base64-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of base64-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing base64-0.10.0 [INFO] finished frobbing base64-0.10.0 [INFO] frobbed toml for base64-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/base64/0.10.0/Cargo.toml [INFO] started frobbing base64-0.10.0 [INFO] finished frobbing base64-0.10.0 [INFO] frobbed toml for base64-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/base64/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting base64-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/base64/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9aadb927b8e438bbf43704a9e73a3e85b222536c701928055531e8eb32942779 [INFO] running `"docker" "start" "-a" "9aadb927b8e438bbf43704a9e73a3e85b222536c701928055531e8eb32942779"` [INFO] [stderr] Checking base64 v0.10.0 (/opt/crater/workdir) [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:54:47 [INFO] [stderr] | [INFO] [stderr] 54| unused_results, variant_size_differences, warnings, unsafe_code [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::deprecated_cfg_attr)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:69:1 [INFO] [stderr] | [INFO] [stderr] 69 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:328:1 [INFO] [stderr] | [INFO] [stderr] 328 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:395:1 [INFO] [stderr] | [INFO] [stderr] 395 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:654:1 [INFO] [stderr] | [INFO] [stderr] 654 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:721:1 [INFO] [stderr] | [INFO] [stderr] 721 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:54:47 [INFO] [stderr] | [INFO] [stderr] 54| unused_results, variant_size_differences, warnings, unsafe_code [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::deprecated_cfg_attr)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:69:1 [INFO] [stderr] | [INFO] [stderr] 69 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:328:1 [INFO] [stderr] | [INFO] [stderr] 328 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:395:1 [INFO] [stderr] | [INFO] [stderr] 395 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:654:1 [INFO] [stderr] | [INFO] [stderr] 654 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tables.rs:721:1 [INFO] [stderr] | [INFO] [stderr] 721 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/write/encoder.rs:226:22 [INFO] [stderr] | [INFO] [stderr] 226 | Ok(_) => return Ok(extra_input_read_len + input_chunks_to_encode_len), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(extra_input_read_len + input_chunks_to_encode_len)` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:54:47 [INFO] [stderr] | [INFO] [stderr] 54 | unused_results, variant_size_differences, warnings, unsafe_code [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/write/encoder.rs:230:17 [INFO] [stderr] | [INFO] [stderr] 230 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:3:29 [INFO] [stderr] | [INFO] [stderr] 3 | pub const STANDARD_ENCODE: &'static [u8; 64] = &[ [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 64]` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:54:47 [INFO] [stderr] | [INFO] [stderr] 54| unused_results, variant_size_differences, warnings, unsafe_code [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::const_static_lifetime)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:70:29 [INFO] [stderr] | [INFO] [stderr] 70 | pub const STANDARD_DECODE: &'static [u8; 256] = &[ [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[u8; 256]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:329:29 [INFO] [stderr] | [INFO] [stderr] 329 | pub const URL_SAFE_ENCODE: &'static [u8; 64] = &[ [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:396:29 [INFO] [stderr] | [INFO] [stderr] 396 | pub const URL_SAFE_DECODE: &'static [u8; 256] = &[ [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[u8; 256]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:655:26 [INFO] [stderr] | [INFO] [stderr] 655 | pub const CRYPT_ENCODE: &'static [u8; 64] = &[ [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:722:26 [INFO] [stderr] | [INFO] [stderr] 722 | pub const CRYPT_DECODE: &'static [u8; 256] = &[ [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[u8; 256]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/encode.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return String::from_utf8(buf).expect("Invalid UTF8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(buf).expect("Invalid UTF8")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: aborting due to 15 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `base64`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/chunked_encoder.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:54:47 [INFO] [stderr] | [INFO] [stderr] 54 | unused_results, variant_size_differences, warnings, unsafe_code [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/write/encoder.rs:226:22 [INFO] [stderr] | [INFO] [stderr] 226 | Ok(_) => return Ok(extra_input_read_len + input_chunks_to_encode_len), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(extra_input_read_len + input_chunks_to_encode_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/write/encoder.rs:230:17 [INFO] [stderr] | [INFO] [stderr] 230 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:3:29 [INFO] [stderr] | [INFO] [stderr] 3 | pub const STANDARD_ENCODE: &'static [u8; 64] = &[ [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 64]` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:54:47 [INFO] [stderr] | [INFO] [stderr] 54| unused_results, variant_size_differences, warnings, unsafe_code [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::const_static_lifetime)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:70:29 [INFO] [stderr] | [INFO] [stderr] 70 | pub const STANDARD_DECODE: &'static [u8; 256] = &[ [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[u8; 256]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:329:29 [INFO] [stderr] | [INFO] [stderr] 329 | pub const URL_SAFE_ENCODE: &'static [u8; 64] = &[ [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:396:29 [INFO] [stderr] | [INFO] [stderr] 396 | pub const URL_SAFE_DECODE: &'static [u8; 256] = &[ [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[u8; 256]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:655:26 [INFO] [stderr] | [INFO] [stderr] 655 | pub const CRYPT_ENCODE: &'static [u8; 64] = &[ [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tables.rs:722:26 [INFO] [stderr] | [INFO] [stderr] 722 | pub const CRYPT_DECODE: &'static [u8; 256] = &[ [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[u8; 256]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/encode.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return String::from_utf8(buf).expect("Invalid UTF8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(buf).expect("Invalid UTF8")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `base64`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9aadb927b8e438bbf43704a9e73a3e85b222536c701928055531e8eb32942779"` [INFO] running `"docker" "rm" "-f" "9aadb927b8e438bbf43704a9e73a3e85b222536c701928055531e8eb32942779"` [INFO] [stdout] 9aadb927b8e438bbf43704a9e73a3e85b222536c701928055531e8eb32942779