[INFO] crate base-x 0.2.3 is already in cache [INFO] extracting crate base-x 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/base-x/0.2.3 [INFO] extracting crate base-x 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/base-x/0.2.3 [INFO] validating manifest of base-x-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of base-x-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing base-x-0.2.3 [INFO] finished frobbing base-x-0.2.3 [INFO] frobbed toml for base-x-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/base-x/0.2.3/Cargo.toml [INFO] started frobbing base-x-0.2.3 [INFO] finished frobbing base-x-0.2.3 [INFO] frobbed toml for base-x-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/base-x/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting base-x-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/base-x/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de25dda37a350afcce2e4f58e22adb78c739c88e45573ae5774c993885e4874f [INFO] running `"docker" "start" "-a" "de25dda37a350afcce2e4f58e22adb78c739c88e45573ae5774c993885e4874f"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking base-x v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bigint.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | chunks: chunks [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chunks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bigint.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | chunks: chunks [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chunks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bigint.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | chunks: chunks [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chunks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bigint.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | chunks: chunks [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chunks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/alphabet.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/alphabet.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:37:37 [INFO] [stderr] | [INFO] [stderr] 37 | carry = (carry << 32) | *chunk as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*chunk)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:38:31 [INFO] [stderr] | [INFO] [stderr] 38 | *chunk = (carry / divider as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(divider)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | carry %= divider as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(divider)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bigint.rs:42:35 [INFO] [stderr] | [INFO] [stderr] 42 | if self.chunks[0] == 0 && self.chunks.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.chunks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:61:26 [INFO] [stderr] | [INFO] [stderr] 61 | carry = (*chunk as u64 * multiplicator as u64) + addition as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*chunk)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:61:42 [INFO] [stderr] | [INFO] [stderr] 61 | carry = (*chunk as u64 * multiplicator as u64) + addition as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(multiplicator)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:61:66 [INFO] [stderr] | [INFO] [stderr] 61 | carry = (*chunk as u64 * multiplicator as u64) + addition as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(addition)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | carry += *chunk as u64 * multiplicator as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*chunk)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:67:42 [INFO] [stderr] | [INFO] [stderr] 67 | carry += *chunk as u64 * multiplicator as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(multiplicator)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/bigint.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 108 | let mut bytes = Vec::with_capacity(len); [INFO] [stderr] | ----------------------- help: consider replace allocation with: `vec![0; len]` [INFO] [stderr] 109 | bytes.set_len(len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unsafe_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | big.mul_add(base, $carry as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 41 | / decode!( [INFO] [stderr] 42 | | alphabet, [INFO] [stderr] 43 | | input, [INFO] [stderr] 44 | | bytes, [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 18 | big.mul_add(base, u32::from(match lookup[c as usize] { [INFO] [stderr] 19 | 0xFF => return Err(DecodeError), [INFO] [stderr] 20 | index => index [INFO] [stderr] 21 | })); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/encoder.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | out.iter().rev().map(|char| *char).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `out.iter().rev().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `base-x`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bigint.rs:163:37 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(big.chunks, vec![0x0000DEAD, 0x00000013, 0x37AD0000, 0x0000DEAD]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_DEAD` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bigint.rs:163:49 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(big.chunks, vec![0x0000DEAD, 0x00000013, 0x37AD0000, 0x0000DEAD]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0013` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bigint.rs:163:61 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(big.chunks, vec![0x0000DEAD, 0x00000013, 0x37AD0000, 0x0000DEAD]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x37AD_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bigint.rs:163:73 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(big.chunks, vec![0x0000DEAD, 0x00000013, 0x37AD0000, 0x0000DEAD]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_DEAD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bigint.rs:169:26 [INFO] [stderr] | [INFO] [stderr] 169 | chunks: vec![0x136AD712,0x84322759] [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x136A_D712` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bigint.rs:169:37 [INFO] [stderr] | [INFO] [stderr] 169 | chunks: vec![0x136AD712,0x84322759] [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8432_2759` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bigint.rs:175:28 [INFO] [stderr] | [INFO] [stderr] 175 | assert_eq!(merged, 0x136AD71284322759 / 58); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x136A_D712_8432_2759` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bigint.rs:176:32 [INFO] [stderr] | [INFO] [stderr] 176 | assert_eq!(rem as u64, 0x136AD71284322759 % 58); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x136A_D712_8432_2759` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bigint.rs:182:26 [INFO] [stderr] | [INFO] [stderr] 182 | chunks: vec![0x000AD712,0x84322759] [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_D712` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bigint.rs:182:37 [INFO] [stderr] | [INFO] [stderr] 182 | chunks: vec![0x000AD712,0x84322759] [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8432_2759` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bigint.rs:188:29 [INFO] [stderr] | [INFO] [stderr] 188 | assert_eq!(merged, (0x000AD71284322759 * 58) + 37); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x000A_D712_8432_2759` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/alphabet.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/alphabet.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:37:37 [INFO] [stderr] | [INFO] [stderr] 37 | carry = (carry << 32) | *chunk as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*chunk)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:38:31 [INFO] [stderr] | [INFO] [stderr] 38 | *chunk = (carry / divider as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(divider)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | carry %= divider as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(divider)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bigint.rs:42:35 [INFO] [stderr] | [INFO] [stderr] 42 | if self.chunks[0] == 0 && self.chunks.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.chunks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:61:26 [INFO] [stderr] | [INFO] [stderr] 61 | carry = (*chunk as u64 * multiplicator as u64) + addition as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*chunk)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:61:42 [INFO] [stderr] | [INFO] [stderr] 61 | carry = (*chunk as u64 * multiplicator as u64) + addition as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(multiplicator)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:61:66 [INFO] [stderr] | [INFO] [stderr] 61 | carry = (*chunk as u64 * multiplicator as u64) + addition as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(addition)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | carry += *chunk as u64 * multiplicator as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*chunk)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:67:42 [INFO] [stderr] | [INFO] [stderr] 67 | carry += *chunk as u64 * multiplicator as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(multiplicator)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/bigint.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 108 | let mut bytes = Vec::with_capacity(len); [INFO] [stderr] | ----------------------- help: consider replace allocation with: `vec![0; len]` [INFO] [stderr] 109 | bytes.set_len(len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unsafe_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | let merged = ((big.chunks[0] as u64) << 32) | big.chunks[1] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(big.chunks[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:173:55 [INFO] [stderr] | [INFO] [stderr] 173 | let merged = ((big.chunks[0] as u64) << 32) | big.chunks[1] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(big.chunks[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:176:20 [INFO] [stderr] | [INFO] [stderr] 176 | assert_eq!(rem as u64, 0x136AD71284322759 % 58); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(rem)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:186:23 [INFO] [stderr] | [INFO] [stderr] 186 | let merged = ((big.chunks[0] as u64) << 32) | big.chunks[1] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(big.chunks[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bigint.rs:186:55 [INFO] [stderr] | [INFO] [stderr] 186 | let merged = ((big.chunks[0] as u64) << 32) | big.chunks[1] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(big.chunks[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | big.mul_add(base, $carry as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 41 | / decode!( [INFO] [stderr] 42 | | alphabet, [INFO] [stderr] 43 | | input, [INFO] [stderr] 44 | | bytes, [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 18 | big.mul_add(base, u32::from(match lookup[c as usize] { [INFO] [stderr] 19 | 0xFF => return Err(DecodeError), [INFO] [stderr] 20 | index => index [INFO] [stderr] 21 | })); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/encoder.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | out.iter().rev().map(|char| *char).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `out.iter().rev().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `base-x`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "de25dda37a350afcce2e4f58e22adb78c739c88e45573ae5774c993885e4874f"` [INFO] running `"docker" "rm" "-f" "de25dda37a350afcce2e4f58e22adb78c739c88e45573ae5774c993885e4874f"` [INFO] [stdout] de25dda37a350afcce2e4f58e22adb78c739c88e45573ae5774c993885e4874f