[INFO] crate barnes 0.1.2 is already in cache
[INFO] extracting crate barnes 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/barnes/0.1.2
[INFO] extracting crate barnes 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/barnes/0.1.2
[INFO] validating manifest of barnes-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of barnes-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing barnes-0.1.2
[INFO] finished frobbing barnes-0.1.2
[INFO] frobbed toml for barnes-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/barnes/0.1.2/Cargo.toml
[INFO] started frobbing barnes-0.1.2
[INFO] finished frobbing barnes-0.1.2
[INFO] frobbed toml for barnes-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/barnes/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting barnes-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/barnes/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6dc98a98f5dcab38ebcbab4cf2d02cce8a6b06a884cabf08d8aaf3b59348ffd7
[INFO] running `"docker" "start" "-a" "6dc98a98f5dcab38ebcbab4cf2d02cce8a6b06a884cabf08d8aaf3b59348ffd7"`
[INFO] [stderr]     Checking barnes v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:11:11
[INFO] [stderr]    |
[INFO] [stderr] 11 |         Point { x:x, y:y, name:&name }
[INFO] [stderr]    |                 ^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:11:16
[INFO] [stderr]    |
[INFO] [stderr] 11 |         Point { x:x, y:y, name:&name }
[INFO] [stderr]    |                      ^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:25:11
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Region{ nw:nw, ne:ne, sw:sw, se:se }
[INFO] [stderr]    |                 ^^^^^ help: replace it with: `nw`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:25:18
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Region{ nw:nw, ne:ne, sw:sw, se:se }
[INFO] [stderr]    |                        ^^^^^ help: replace it with: `ne`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Region{ nw:nw, ne:ne, sw:sw, se:se }
[INFO] [stderr]    |                               ^^^^^ help: replace it with: `sw`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:25:32
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Region{ nw:nw, ne:ne, sw:sw, se:se }
[INFO] [stderr]    |                                      ^^^^^ help: replace it with: `se`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:44:12
[INFO] [stderr]    |
[INFO] [stderr] 44 |         Square { x:x, y:y, lenght:lenght, weight: 0, point: None, bucket: None, region: None}
[INFO] [stderr]    |                  ^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:44:17
[INFO] [stderr]    |
[INFO] [stderr] 44 |         Square { x:x, y:y, lenght:lenght, weight: 0, point: None, bucket: None, region: None}
[INFO] [stderr]    |                       ^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:44:22
[INFO] [stderr]    |
[INFO] [stderr] 44 |         Square { x:x, y:y, lenght:lenght, weight: 0, point: None, bucket: None, region: None}
[INFO] [stderr]    |                            ^^^^^^^^^^^^^ help: replace it with: `lenght`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:11:11
[INFO] [stderr]    |
[INFO] [stderr] 11 |         Point { x:x, y:y, name:&name }
[INFO] [stderr]    |                 ^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:11:16
[INFO] [stderr]    |
[INFO] [stderr] 11 |         Point { x:x, y:y, name:&name }
[INFO] [stderr]    |                      ^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:25:11
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Region{ nw:nw, ne:ne, sw:sw, se:se }
[INFO] [stderr]    |                 ^^^^^ help: replace it with: `nw`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:25:18
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Region{ nw:nw, ne:ne, sw:sw, se:se }
[INFO] [stderr]    |                        ^^^^^ help: replace it with: `ne`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Region{ nw:nw, ne:ne, sw:sw, se:se }
[INFO] [stderr]    |                               ^^^^^ help: replace it with: `sw`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:25:32
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Region{ nw:nw, ne:ne, sw:sw, se:se }
[INFO] [stderr]    |                                      ^^^^^ help: replace it with: `se`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:44:12
[INFO] [stderr]    |
[INFO] [stderr] 44 |         Square { x:x, y:y, lenght:lenght, weight: 0, point: None, bucket: None, region: None}
[INFO] [stderr]    |                  ^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:44:17
[INFO] [stderr]    |
[INFO] [stderr] 44 |         Square { x:x, y:y, lenght:lenght, weight: 0, point: None, bucket: None, region: None}
[INFO] [stderr]    |                       ^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:44:22
[INFO] [stderr]    |
[INFO] [stderr] 44 |         Square { x:x, y:y, lenght:lenght, weight: 0, point: None, bucket: None, region: None}
[INFO] [stderr]    |                            ^^^^^^^^^^^^^ help: replace it with: `lenght`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/tree.rs:12:2
[INFO] [stderr]    |
[INFO] [stderr] 12 |     limit
[INFO] [stderr]    |     ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/tree.rs:11:14
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let limit = bucket_size / (thread * 10);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/tree.rs:48:2
[INFO] [stderr]    |
[INFO] [stderr] 48 |     square
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/tree.rs:47:15
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let square = assign(square, nw_point, nw_region);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]   --> src/tree.rs:51:1
[INFO] [stderr]    |
[INFO] [stderr] 51 | / fn create_region_no_thread(nw:Square,nw_bucket:Vec<Point>, ne:Square,ne_bucket:Vec<Point>, sw:Square,sw_bucket:Vec<Point>, se:Square,se_bucket:Vec<Point>) -> Region {
[INFO] [stderr] 52 | |     let nw = compute_assign(nw, nw_bucket);
[INFO] [stderr] 53 | |     let ne = compute_assign(ne, ne_bucket);
[INFO] [stderr] 54 | |     let sw = compute_assign(sw, sw_bucket);
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |     Region::new(nw, ne, sw, se)
[INFO] [stderr] 58 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]   --> src/tree.rs:60:1
[INFO] [stderr]    |
[INFO] [stderr] 60 | / fn create_region_thread(nw:Square,nw_bucket:Vec<Point>, ne:Square,ne_bucket:Vec<Point>, sw:Square,sw_bucket:Vec<Point>, se:Square,se_bucket:Vec<Point>) -> Region {
[INFO] [stderr] 61 | |     
[INFO] [stderr] 62 | |     let nw_t = thread::spawn(move || {
[INFO] [stderr] 63 | |         compute_assign(nw, nw_bucket)
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |          se_t.join().unwrap())
[INFO] [stderr] 79 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/tree.rs:102:5
[INFO] [stderr]     |
[INFO] [stderr] 102 |     if bucket.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bucket.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `create_region` doesn't need a mutable reference
[INFO] [stderr]    --> src/tree.rs:110:29
[INFO] [stderr]     |
[INFO] [stderr] 110 |     let region = create_region(&mut self_square, bucket);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/tree.rs:12:2
[INFO] [stderr]    |
[INFO] [stderr] 12 |     limit
[INFO] [stderr]    |     ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/tree.rs:11:14
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let limit = bucket_size / (thread * 10);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/tree.rs:48:2
[INFO] [stderr]    |
[INFO] [stderr] 48 |     square
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/tree.rs:47:15
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let square = assign(square, nw_point, nw_region);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]   --> src/tree.rs:51:1
[INFO] [stderr]    |
[INFO] [stderr] 51 | / fn create_region_no_thread(nw:Square,nw_bucket:Vec<Point>, ne:Square,ne_bucket:Vec<Point>, sw:Square,sw_bucket:Vec<Point>, se:Square,se_bucket:Vec<Point>) -> Region {
[INFO] [stderr] 52 | |     let nw = compute_assign(nw, nw_bucket);
[INFO] [stderr] 53 | |     let ne = compute_assign(ne, ne_bucket);
[INFO] [stderr] 54 | |     let sw = compute_assign(sw, sw_bucket);
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |     Region::new(nw, ne, sw, se)
[INFO] [stderr] 58 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]   --> src/tree.rs:60:1
[INFO] [stderr]    |
[INFO] [stderr] 60 | / fn create_region_thread(nw:Square,nw_bucket:Vec<Point>, ne:Square,ne_bucket:Vec<Point>, sw:Square,sw_bucket:Vec<Point>, se:Square,se_bucket:Vec<Point>) -> Region {
[INFO] [stderr] 61 | |     
[INFO] [stderr] 62 | |     let nw_t = thread::spawn(move || {
[INFO] [stderr] 63 | |         compute_assign(nw, nw_bucket)
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |          se_t.join().unwrap())
[INFO] [stderr] 79 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/tree.rs:102:5
[INFO] [stderr]     |
[INFO] [stderr] 102 |     if bucket.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bucket.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `create_region` doesn't need a mutable reference
[INFO] [stderr]    --> src/tree.rs:110:29
[INFO] [stderr]     |
[INFO] [stderr] 110 |     let region = create_region(&mut self_square, bucket);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.20s
[INFO] running `"docker" "inspect" "6dc98a98f5dcab38ebcbab4cf2d02cce8a6b06a884cabf08d8aaf3b59348ffd7"`
[INFO] running `"docker" "rm" "-f" "6dc98a98f5dcab38ebcbab4cf2d02cce8a6b06a884cabf08d8aaf3b59348ffd7"`
[INFO] [stdout] 6dc98a98f5dcab38ebcbab4cf2d02cce8a6b06a884cabf08d8aaf3b59348ffd7