[INFO] crate barcoders 0.10.0 is already in cache [INFO] extracting crate barcoders 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/barcoders/0.10.0 [INFO] extracting crate barcoders 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/barcoders/0.10.0 [INFO] validating manifest of barcoders-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of barcoders-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing barcoders-0.10.0 [INFO] finished frobbing barcoders-0.10.0 [INFO] frobbed toml for barcoders-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/barcoders/0.10.0/Cargo.toml [INFO] started frobbing barcoders-0.10.0 [INFO] finished frobbing barcoders-0.10.0 [INFO] frobbed toml for barcoders-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/barcoders/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting barcoders-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/barcoders/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5429991ffebeb32af909f43cc40a8a547d18f0f687b8fcb9665c03c4543e2126 [INFO] running `"docker" "start" "-a" "5429991ffebeb32af909f43cc40a8a547d18f0f687b8fcb9665c03c4543e2126"` [INFO] [stderr] Checking barcoders v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sym/code39.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | checksum: checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `checksum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sym/code39.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | checksum: checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `checksum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/sym/code128.rs:260:33 [INFO] [stderr] | [INFO] [stderr] 260 | .zip((0..self.0.len() as i32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/sym/code128.rs:260:33 [INFO] [stderr] | [INFO] [stderr] 260 | .zip((0..self.0.len() as i32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/sym/code128.rs:260:33 [INFO] [stderr] | [INFO] [stderr] 260 | .zip((0..self.0.len() as i32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/sym/code128.rs:260:33 [INFO] [stderr] | [INFO] [stderr] 260 | .zip((0..self.0.len() as i32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/ean13.rs:94:45 [INFO] [stderr] | [INFO] [stderr] 94 | fn char_encoding(&self, side: usize, d: &u8) -> [u8; 7] { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sym/ean13.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | (0..10).into_iter().map(|i| char::from_digit(i, 10).unwrap()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/ean8.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | fn char_encoding(&self, side: usize, d: &u8) -> [u8; 7] { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sym/ean8.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | (0..10).into_iter().map(|i| char::from_digit(i, 10).unwrap()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/ean_supp.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | fn char_encoding(&self, side: usize, d: &u8) -> [u8; 7] { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sym/ean_supp.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | (0..10).into_iter().map(|i| char::from_digit(i, 10).unwrap()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/sym/code39.rs:69:28 [INFO] [stderr] | [INFO] [stderr] 69 | let index = indices.fold(0, |acc, i| acc + i) % CHARS.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/code39.rs:84:32 [INFO] [stderr] | [INFO] [stderr] 84 | fn char_encoding(&self, c: &char) -> [u8; 12] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sym/code93.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | fn checksum_char(&self, data: &Vec, weight_threshold: usize) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sym/code11.rs:51:35 [INFO] [stderr] | [INFO] [stderr] 51 | fn checksum_char(&self, data: &Vec, weight_threshold: usize) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/code128.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | fn unit(&self, n: usize) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/code128.rs:174:14 [INFO] [stderr] | [INFO] [stderr] 174 | fn index(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/code128.rs:183:15 [INFO] [stderr] | [INFO] [stderr] 183 | fn lookup(&self, s: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/codabar.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | fn lookup(&self) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/tf.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | fn char_encoding(&self, d: &u8) -> Vec { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/tf.rs:111:30 [INFO] [stderr] | [INFO] [stderr] 111 | fn char_widths(&self, d: &u8) -> &'static str { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sym/tf.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | (0..10).into_iter().map(|i| char::from_digit(i, 10).unwrap()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/sym/helpers.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | .flat_map(|b| b.into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/ean13.rs:94:45 [INFO] [stderr] | [INFO] [stderr] 94 | fn char_encoding(&self, side: usize, d: &u8) -> [u8; 7] { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sym/ean13.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | (0..10).into_iter().map(|i| char::from_digit(i, 10).unwrap()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sym/ean13.rs:161:55 [INFO] [stderr] | [INFO] [stderr] 161 | let chars = v.iter().map(|d| char::from_digit(*d as u32, 10).unwrap()); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*d)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/ean8.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | fn char_encoding(&self, side: usize, d: &u8) -> [u8; 7] { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sym/ean8.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | (0..10).into_iter().map(|i| char::from_digit(i, 10).unwrap()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sym/ean8.rs:116:55 [INFO] [stderr] | [INFO] [stderr] 116 | let chars = v.iter().map(|d| char::from_digit(*d as u32, 10).unwrap()); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/ean_supp.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | fn char_encoding(&self, side: usize, d: &u8) -> [u8; 7] { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sym/ean_supp.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | (0..10).into_iter().map(|i| char::from_digit(i, 10).unwrap()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sym/ean_supp.rs:149:55 [INFO] [stderr] | [INFO] [stderr] 149 | let chars = v.iter().map(|d| char::from_digit(*d as u32, 10).unwrap()); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/sym/code39.rs:69:28 [INFO] [stderr] | [INFO] [stderr] 69 | let index = indices.fold(0, |acc, i| acc + i) % CHARS.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/code39.rs:84:32 [INFO] [stderr] | [INFO] [stderr] 84 | fn char_encoding(&self, c: &char) -> [u8; 12] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sym/code39.rs:139:55 [INFO] [stderr] | [INFO] [stderr] 139 | let chars = v.iter().map(|d| char::from_digit(*d as u32, 10).unwrap()); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sym/code93.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | fn checksum_char(&self, data: &Vec, weight_threshold: usize) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sym/code93.rs:146:55 [INFO] [stderr] | [INFO] [stderr] 146 | let chars = v.iter().map(|d| char::from_digit(*d as u32, 10).unwrap()); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sym/code11.rs:51:35 [INFO] [stderr] | [INFO] [stderr] 51 | fn checksum_char(&self, data: &Vec, weight_threshold: usize) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sym/code11.rs:145:55 [INFO] [stderr] | [INFO] [stderr] 145 | let chars = v.iter().map(|d| char::from_digit(*d as u32, 10).unwrap()); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/code128.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | fn unit(&self, n: usize) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/code128.rs:174:14 [INFO] [stderr] | [INFO] [stderr] 174 | fn index(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/code128.rs:183:15 [INFO] [stderr] | [INFO] [stderr] 183 | fn lookup(&self, s: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sym/code128.rs:301:55 [INFO] [stderr] | [INFO] [stderr] 301 | let chars = v.iter().map(|d| char::from_digit(*d as u32, 10).unwrap()); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/codabar.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | fn lookup(&self) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sym/codabar.rs:134:55 [INFO] [stderr] | [INFO] [stderr] 134 | let chars = v.iter().map(|d| char::from_digit(*d as u32, 10).unwrap()); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/tf.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | fn char_encoding(&self, d: &u8) -> Vec { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sym/tf.rs:111:30 [INFO] [stderr] | [INFO] [stderr] 111 | fn char_widths(&self, d: &u8) -> &'static str { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/sym/tf.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | (0..10).into_iter().map(|i| char::from_digit(i, 10).unwrap()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sym/tf.rs:168:55 [INFO] [stderr] | [INFO] [stderr] 168 | let chars = v.iter().map(|d| char::from_digit(*d as u32, 10).unwrap()); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/sym/helpers.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | .flat_map(|b| b.into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.00s [INFO] running `"docker" "inspect" "5429991ffebeb32af909f43cc40a8a547d18f0f687b8fcb9665c03c4543e2126"` [INFO] running `"docker" "rm" "-f" "5429991ffebeb32af909f43cc40a8a547d18f0f687b8fcb9665c03c4543e2126"` [INFO] [stdout] 5429991ffebeb32af909f43cc40a8a547d18f0f687b8fcb9665c03c4543e2126