[INFO] crate bao_bin 0.5.0 is already in cache [INFO] extracting crate bao_bin 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/bao_bin/0.5.0 [INFO] extracting crate bao_bin 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bao_bin/0.5.0 [INFO] validating manifest of bao_bin-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bao_bin-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bao_bin-0.5.0 [INFO] finished frobbing bao_bin-0.5.0 [INFO] frobbed toml for bao_bin-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/bao_bin/0.5.0/Cargo.toml [INFO] started frobbing bao_bin-0.5.0 [INFO] finished frobbing bao_bin-0.5.0 [INFO] frobbed toml for bao_bin-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bao_bin/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bao_bin-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bao_bin/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] daaaa0387a482b7942853871a9c70adf8c4bcda7e4bddd63b3c235ea563936e3 [INFO] running `"docker" "start" "-a" "daaaa0387a482b7942853871a9c70adf8c4bcda7e4bddd63b3c235ea563936e3"` [INFO] [stderr] Compiling winapi v0.3.6 [INFO] [stderr] Checking copy_in_place v0.2.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking blake2b_simd v0.4.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking shared_child v0.3.3 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking duct v0.11.1 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking bao v0.5.0 [INFO] [stderr] Checking bao_bin v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:196:12 [INFO] [stderr] | [INFO] [stderr] 196 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 197 | | if let Some(offset) = args.flag_start { [INFO] [stderr] 198 | | file_reader = bao::decode::Reader::new(input.require_file()?, &hash); [INFO] [stderr] 199 | | file_reader.seek(io::SeekFrom::Start(offset))?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 196 | } else if let Some(offset) = args.flag_start { [INFO] [stderr] 197 | file_reader = bao::decode::Reader::new(input.require_file()?, &hash); [INFO] [stderr] 198 | file_reader.seek(io::SeekFrom::Start(offset))?; [INFO] [stderr] 199 | reader = &mut file_reader; [INFO] [stderr] 200 | } else { [INFO] [stderr] 201 | generic_reader = bao::decode::Reader::new(input, &hash); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | / let mut extractor; [INFO] [stderr] 221 | | if args.flag_outboard.is_some() { [INFO] [stderr] 222 | | outboard = open_input(&args.flag_outboard)?; [INFO] [stderr] 223 | | extractor = bao::encode::SliceExtractor::new_outboard( [INFO] [stderr] ... | [INFO] [stderr] 231 | | bao::encode::SliceExtractor::new(input.require_file()?, args.arg_start, args.arg_count); [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 220 | let extractor = if args.flag_outboard.is_some() { ..; bao::encode::SliceExtractor::new_outboard( [INFO] [stderr] 221 | input.require_file()?, [INFO] [stderr] 222 | outboard.require_file()?, [INFO] [stderr] 223 | args.arg_start, [INFO] [stderr] 224 | args.arg_count, [INFO] [stderr] 225 | ) } else { bao::encode::SliceExtractor::new(input.require_file()?, args.arg_start, args.arg_count) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:196:12 [INFO] [stderr] | [INFO] [stderr] 196 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 197 | | if let Some(offset) = args.flag_start { [INFO] [stderr] 198 | | file_reader = bao::decode::Reader::new(input.require_file()?, &hash); [INFO] [stderr] 199 | | file_reader.seek(io::SeekFrom::Start(offset))?; [INFO] [stderr] ... | [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 196 | } else if let Some(offset) = args.flag_start { [INFO] [stderr] 197 | file_reader = bao::decode::Reader::new(input.require_file()?, &hash); [INFO] [stderr] 198 | file_reader.seek(io::SeekFrom::Start(offset))?; [INFO] [stderr] 199 | reader = &mut file_reader; [INFO] [stderr] 200 | } else { [INFO] [stderr] 201 | generic_reader = bao::decode::Reader::new(input, &hash); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:264:41 [INFO] [stderr] | [INFO] [stderr] 264 | Input::Stdin => Err(err_msg(format!("input must be a real file"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"input must be a real file".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:301:43 [INFO] [stderr] | [INFO] [stderr] 301 | Output::Stdout => Err(err_msg(format!("output must be a real file"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"output must be a real file".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:344:58 [INFO] [stderr] | [INFO] [stderr] 344 | } else if metadata.len() > isize::max_value() as u64 { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 345 | | // Too long to safely map. https://github.com/danburkert/memmap-rs/issues/69 [INFO] [stderr] 346 | | None [INFO] [stderr] 347 | | } else if metadata.len() == 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:341:31 [INFO] [stderr] | [INFO] [stderr] 341 | Ok(if !metadata.is_file() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 342 | | // Not a real file. [INFO] [stderr] 343 | | None [INFO] [stderr] 344 | | } else if metadata.len() > isize::max_value() as u64 { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | if target_len > u64::max_value() as u128 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(u64::max_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:377:35 [INFO] [stderr] | [INFO] [stderr] 377 | } else if metadata.len() != 0 { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 378 | | // The output file hasn't been truncated. Likely opened in append mode. [INFO] [stderr] 379 | | None [INFO] [stderr] 380 | | } else if target_len == 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:374:31 [INFO] [stderr] | [INFO] [stderr] 374 | Ok(if !metadata.is_file() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 375 | | // Not a real file. [INFO] [stderr] 376 | | None [INFO] [stderr] 377 | | } else if metadata.len() != 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bao_bin`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | / let mut extractor; [INFO] [stderr] 221 | | if args.flag_outboard.is_some() { [INFO] [stderr] 222 | | outboard = open_input(&args.flag_outboard)?; [INFO] [stderr] 223 | | extractor = bao::encode::SliceExtractor::new_outboard( [INFO] [stderr] ... | [INFO] [stderr] 231 | | bao::encode::SliceExtractor::new(input.require_file()?, args.arg_start, args.arg_count); [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 220 | let extractor = if args.flag_outboard.is_some() { ..; bao::encode::SliceExtractor::new_outboard( [INFO] [stderr] 221 | input.require_file()?, [INFO] [stderr] 222 | outboard.require_file()?, [INFO] [stderr] 223 | args.arg_start, [INFO] [stderr] 224 | args.arg_count, [INFO] [stderr] 225 | ) } else { bao::encode::SliceExtractor::new(input.require_file()?, args.arg_start, args.arg_count) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:264:41 [INFO] [stderr] | [INFO] [stderr] 264 | Input::Stdin => Err(err_msg(format!("input must be a real file"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"input must be a real file".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:301:43 [INFO] [stderr] | [INFO] [stderr] 301 | Output::Stdout => Err(err_msg(format!("output must be a real file"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"output must be a real file".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:344:58 [INFO] [stderr] | [INFO] [stderr] 344 | } else if metadata.len() > isize::max_value() as u64 { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 345 | | // Too long to safely map. https://github.com/danburkert/memmap-rs/issues/69 [INFO] [stderr] 346 | | None [INFO] [stderr] 347 | | } else if metadata.len() == 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:341:31 [INFO] [stderr] | [INFO] [stderr] 341 | Ok(if !metadata.is_file() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 342 | | // Not a real file. [INFO] [stderr] 343 | | None [INFO] [stderr] 344 | | } else if metadata.len() > isize::max_value() as u64 { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | if target_len > u64::max_value() as u128 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(u64::max_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:377:35 [INFO] [stderr] | [INFO] [stderr] 377 | } else if metadata.len() != 0 { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 378 | | // The output file hasn't been truncated. Likely opened in append mode. [INFO] [stderr] 379 | | None [INFO] [stderr] 380 | | } else if target_len == 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:374:31 [INFO] [stderr] | [INFO] [stderr] 374 | Ok(if !metadata.is_file() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 375 | | // Not a real file. [INFO] [stderr] 376 | | None [INFO] [stderr] 377 | | } else if metadata.len() != 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bao_bin`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "daaaa0387a482b7942853871a9c70adf8c4bcda7e4bddd63b3c235ea563936e3"` [INFO] running `"docker" "rm" "-f" "daaaa0387a482b7942853871a9c70adf8c4bcda7e4bddd63b3c235ea563936e3"` [INFO] [stdout] daaaa0387a482b7942853871a9c70adf8c4bcda7e4bddd63b3c235ea563936e3