[INFO] crate bamrescue 0.1.0 is already in cache [INFO] extracting crate bamrescue 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/bamrescue/0.1.0 [INFO] extracting crate bamrescue 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bamrescue/0.1.0 [INFO] validating manifest of bamrescue-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bamrescue-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bamrescue-0.1.0 [INFO] finished frobbing bamrescue-0.1.0 [INFO] frobbed toml for bamrescue-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/bamrescue/0.1.0/Cargo.toml [INFO] started frobbing bamrescue-0.1.0 [INFO] finished frobbing bamrescue-0.1.0 [INFO] frobbed toml for bamrescue-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bamrescue/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bamrescue-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bamrescue/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 640902c49a8bbcbd6031ca9145ffd5c70b1d53053cbddecd874195bd0b557807 [INFO] running `"docker" "start" "-a" "640902c49a8bbcbd6031ca9145ffd5c70b1d53053cbddecd874195bd0b557807"` [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking bamrescue v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:403:13 [INFO] [stderr] | [INFO] [stderr] 403 | header_bytes: header_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header_bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | deflated_payload_bytes: deflated_payload_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `deflated_payload_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | inflated_payload_crc32: inflated_payload_crc32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inflated_payload_crc32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | inflated_payload_size: inflated_payload_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inflated_payload_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:403:13 [INFO] [stderr] | [INFO] [stderr] 403 | header_bytes: header_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header_bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | deflated_payload_bytes: deflated_payload_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `deflated_payload_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | inflated_payload_crc32: inflated_payload_crc32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inflated_payload_crc32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | inflated_payload_size: inflated_payload_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inflated_payload_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return option_env!("CARGO_PKG_VERSION").unwrap_or("unknown"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `option_env!("CARGO_PKG_VERSION").unwrap_or("unknown")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return option_env!("CARGO_PKG_VERSION").unwrap_or("unknown"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `option_env!("CARGO_PKG_VERSION").unwrap_or("unknown")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `current_block_corrupted` is never read [INFO] [stderr] --> src/lib.rs:209:66 [INFO] [stderr] | [INFO] [stderr] 209 | fail!(fail_fast, results, previous_block, false, current_block_corrupted, false, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `current_block_corrupted` is never read [INFO] [stderr] --> src/lib.rs:420:62 [INFO] [stderr] | [INFO] [stderr] 420 | fail!(fail_fast, results, previous_block, false, current_block_corrupted, false, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `reader` [INFO] [stderr] --> src/lib.rs:449:15 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn rescue(reader: &mut Rescuable, writer: &mut Write, logger: &slog::Logger) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_reader` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `writer` [INFO] [stderr] --> src/lib.rs:449:39 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn rescue(reader: &mut Rescuable, writer: &mut Write, logger: &slog::Logger) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_writer` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `header_bytes` [INFO] [stderr] --> src/lib.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | header_bytes: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 90 [INFO] [stderr] --> src/lib.rs:178:1 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn check(reader: &mut Rescuable, fail_fast: bool, threads: usize, logger: &slog::Logger) -> Results { [INFO] [stderr] 179 | | info!(logger, "Checking integrity…"); [INFO] [stderr] 180 | | [INFO] [stderr] 181 | | let mut results = Results { [INFO] [stderr] ... | [INFO] [stderr] 446 | | results [INFO] [stderr] 447 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / let pool; [INFO] [stderr] 191 | | if threads == 0 { [INFO] [stderr] 192 | | pool = futures_cpupool::CpuPool::new_num_cpus(); [INFO] [stderr] 193 | | } else { [INFO] [stderr] 194 | | pool = futures_cpupool::CpuPool::new(threads); [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let pool = if threads == 0 { futures_cpupool::CpuPool::new_num_cpus() } else { futures_cpupool::CpuPool::new(threads) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:414:5 [INFO] [stderr] | [INFO] [stderr] 414 | / let mut last_inflated_payload_size = 0u32; [INFO] [stderr] 415 | | if threads == 1 { [INFO] [stderr] 416 | | let payload_status = check_payload(&previous_block).unwrap(); [INFO] [stderr] 417 | | if payload_status.corrupted { [INFO] [stderr] ... | [INFO] [stderr] 437 | | } [INFO] [stderr] 438 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let last_inflated_payload_size = if threads == 1 { ..; payload_status.inflated_payload_size } else { ..; 0u32 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:208:44 [INFO] [stderr] | [INFO] [stderr] 208 | results.bad_blocks_size += payload_status.inflated_payload_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(payload_status.inflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: value assigned to `current_block_corrupted` is never read [INFO] [stderr] --> src/lib.rs:209:66 [INFO] [stderr] | [INFO] [stderr] 209 | fail!(fail_fast, results, previous_block, false, current_block_corrupted, false, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `current_block_corrupted` is never read [INFO] [stderr] --> src/lib.rs:420:62 [INFO] [stderr] | [INFO] [stderr] 420 | fail!(fail_fast, results, previous_block, false, current_block_corrupted, false, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `reader` [INFO] [stderr] --> src/lib.rs:449:15 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn rescue(reader: &mut Rescuable, writer: &mut Write, logger: &slog::Logger) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_reader` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `writer` [INFO] [stderr] --> src/lib.rs:449:39 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn rescue(reader: &mut Rescuable, writer: &mut Write, logger: &slog::Logger) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_writer` instead [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:330:53 [INFO] [stderr] | [INFO] [stderr] 330 | match reader.seek(SeekFrom::Current(extra_subfield_size as i64)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(extra_subfield_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:358:44 [INFO] [stderr] | [INFO] [stderr] 358 | results.bad_blocks_size += payload_status.inflated_payload_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(payload_status.inflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:372:59 [INFO] [stderr] | [INFO] [stderr] 372 | let mut deflated_payload_reader = reader.take(deflated_payload_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(deflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:411:32 [INFO] [stderr] | [INFO] [stderr] 411 | results.blocks_size += inflated_payload_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(inflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:419:40 [INFO] [stderr] | [INFO] [stderr] 419 | results.bad_blocks_size += payload_status.inflated_payload_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(payload_status.inflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:433:44 [INFO] [stderr] | [INFO] [stderr] 433 | results.bad_blocks_size += payload_status.inflated_payload_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(payload_status.inflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `header_bytes` [INFO] [stderr] --> src/lib.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | header_bytes: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 90 [INFO] [stderr] --> src/lib.rs:178:1 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn check(reader: &mut Rescuable, fail_fast: bool, threads: usize, logger: &slog::Logger) -> Results { [INFO] [stderr] 179 | | info!(logger, "Checking integrity…"); [INFO] [stderr] 180 | | [INFO] [stderr] 181 | | let mut results = Results { [INFO] [stderr] ... | [INFO] [stderr] 446 | | results [INFO] [stderr] 447 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / let pool; [INFO] [stderr] 191 | | if threads == 0 { [INFO] [stderr] 192 | | pool = futures_cpupool::CpuPool::new_num_cpus(); [INFO] [stderr] 193 | | } else { [INFO] [stderr] 194 | | pool = futures_cpupool::CpuPool::new(threads); [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let pool = if threads == 0 { futures_cpupool::CpuPool::new_num_cpus() } else { futures_cpupool::CpuPool::new(threads) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:414:5 [INFO] [stderr] | [INFO] [stderr] 414 | / let mut last_inflated_payload_size = 0u32; [INFO] [stderr] 415 | | if threads == 1 { [INFO] [stderr] 416 | | let payload_status = check_payload(&previous_block).unwrap(); [INFO] [stderr] 417 | | if payload_status.corrupted { [INFO] [stderr] ... | [INFO] [stderr] 437 | | } [INFO] [stderr] 438 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let last_inflated_payload_size = if threads == 1 { ..; payload_status.inflated_payload_size } else { ..; 0u32 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:208:44 [INFO] [stderr] | [INFO] [stderr] 208 | results.bad_blocks_size += payload_status.inflated_payload_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(payload_status.inflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:330:53 [INFO] [stderr] | [INFO] [stderr] 330 | match reader.seek(SeekFrom::Current(extra_subfield_size as i64)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(extra_subfield_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:358:44 [INFO] [stderr] | [INFO] [stderr] 358 | results.bad_blocks_size += payload_status.inflated_payload_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(payload_status.inflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:372:59 [INFO] [stderr] | [INFO] [stderr] 372 | let mut deflated_payload_reader = reader.take(deflated_payload_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(deflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:411:32 [INFO] [stderr] | [INFO] [stderr] 411 | results.blocks_size += inflated_payload_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(inflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:419:40 [INFO] [stderr] | [INFO] [stderr] 419 | results.bad_blocks_size += payload_status.inflated_payload_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(payload_status.inflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:433:44 [INFO] [stderr] | [INFO] [stderr] 433 | results.bad_blocks_size += payload_status.inflated_payload_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(payload_status.inflated_payload_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/mod.rs:136:11 [INFO] [stderr] | [INFO] [stderr] 136 | ], 5, 907060870, 0, None, None) [INFO] [stderr] | ^^^^^^^^^ help: consider: `907_060_870` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/mod.rs:142:11 [INFO] [stderr] | [INFO] [stderr] 142 | ], 5, 907060870, 0, Some(gzip_extra_subfields()), None) [INFO] [stderr] | ^^^^^^^^^ help: consider: `907_060_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/mod.rs:148:11 [INFO] [stderr] | [INFO] [stderr] 148 | ], 5, 907060870, 0, None, Some(gzip_extra_subfields())) [INFO] [stderr] | ^^^^^^^^^ help: consider: `907_060_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/mod.rs:154:11 [INFO] [stderr] | [INFO] [stderr] 154 | ], 5, 907060870, 0, Some(gzip_extra_subfields()), Some(gzip_extra_subfields())) [INFO] [stderr] | ^^^^^^^^^ help: consider: `907_060_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/mod.rs:160:11 [INFO] [stderr] | [INFO] [stderr] 160 | ], 5, 907060870, 0, Some(gzip_extra_similar_subfields()), None) [INFO] [stderr] | ^^^^^^^^^ help: consider: `907_060_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/mod.rs:166:11 [INFO] [stderr] | [INFO] [stderr] 166 | ], 5, 907060870, 0, None, Some(gzip_extra_similar_subfields())) [INFO] [stderr] | ^^^^^^^^^ help: consider: `907_060_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/mod.rs:172:11 [INFO] [stderr] | [INFO] [stderr] 172 | ], 5, 907060870, 0, Some(gzip_extra_similar_subfields()), Some(gzip_extra_similar_subfields())) [INFO] [stderr] | ^^^^^^^^^ help: consider: `907_060_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/mod.rs:178:11 [INFO] [stderr] | [INFO] [stderr] 178 | ], 5, 907060870, 0, None, None) [INFO] [stderr] | ^^^^^^^^^ help: consider: `907_060_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/mod.rs:184:12 [INFO] [stderr] | [INFO] [stderr] 184 | ], 25, 907060870, 0, None, None) [INFO] [stderr] | ^^^^^^^^^ help: consider: `907_060_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/mod.rs:190:12 [INFO] [stderr] | [INFO] [stderr] 190 | ], 25, 907060870, -5i32, None, None) [INFO] [stderr] | ^^^^^^^^^ help: consider: `907_060_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/mod.rs:196:12 [INFO] [stderr] | [INFO] [stderr] 196 | ], 25, 907060870, 5i32, None, None) [INFO] [stderr] | ^^^^^^^^^ help: consider: `907_060_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> tests/common/mod.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | data.write_u16::((19i32 + extra_field_size as i32 + deflated_payload.len() as i32 + bgzf_size_delta) as u16).unwrap(); // bgzf block size, minus 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(extra_field_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | docopts.argv(std::env::args().into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `std::env::args()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | docopts.argv(std::env::args().into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `std::env::args()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.94s [INFO] running `"docker" "inspect" "640902c49a8bbcbd6031ca9145ffd5c70b1d53053cbddecd874195bd0b557807"` [INFO] running `"docker" "rm" "-f" "640902c49a8bbcbd6031ca9145ffd5c70b1d53053cbddecd874195bd0b557807"` [INFO] [stdout] 640902c49a8bbcbd6031ca9145ffd5c70b1d53053cbddecd874195bd0b557807