[INFO] crate badtouch 0.6.1 is already in cache [INFO] extracting crate badtouch 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/badtouch/0.6.1 [INFO] extracting crate badtouch 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/badtouch/0.6.1 [INFO] validating manifest of badtouch-0.6.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of badtouch-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing badtouch-0.6.1 [INFO] finished frobbing badtouch-0.6.1 [INFO] frobbed toml for badtouch-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/badtouch/0.6.1/Cargo.toml [INFO] started frobbing badtouch-0.6.1 [INFO] finished frobbing badtouch-0.6.1 [INFO] frobbed toml for badtouch-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/badtouch/0.6.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting badtouch-0.6.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/badtouch/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae217f403f3e4768c62732ba4cb6a70116b8b593ae0a550495ff36c9340cf96b [INFO] running `"docker" "start" "-a" "ae217f403f3e4768c62732ba4cb6a70116b8b593ae0a550495ff36c9340cf96b"` [INFO] [stderr] Compiling lua52-sys v0.1.2 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking tendril v0.4.1 [INFO] [stderr] Checking lber v0.1.6 [INFO] [stderr] Checking regex v1.0.6 [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Checking tokio-tls v0.2.1 [INFO] [stderr] Checking twox-hash v1.1.2 [INFO] [stderr] Checking bcrypt v0.2.2 [INFO] [stderr] Checking getch v0.2.0 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Compiling markup5ever v0.7.5 [INFO] [stderr] Compiling cssparser-macros v0.3.5 [INFO] [stderr] Compiling selectors v0.20.0 [INFO] [stderr] Checking mysql_common v0.12.0 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking cssparser v0.24.1 [INFO] [stderr] Checking hlua-badtouch v0.4.2 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking mysql v14.2.0 [INFO] [stderr] Checking html5ever v0.22.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking kuchiki v0.7.2 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-uds v0.1.7 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-uds-proto v0.1.1 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking ldap3 v0.6.1 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking badtouch v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/runtime.rs:655:82 [INFO] [stderr] | [INFO] [stderr] 655 | lua.set("sock_newline", hlua::function2(move |sock: String, newline: String| -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | let home = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/runtime.rs:655:82 [INFO] [stderr] | [INFO] [stderr] 655 | lua.set("sock_newline", hlua::function2(move |sock: String, newline: String| -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | let home = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(x) => Ok(x.into_iter().map(|x| transform_element(&x)).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/scheduler.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | Attempt(Box, Result), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/scheduler.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | Attempt(Box, Result), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scheduler.rs:128:38 [INFO] [stderr] | [INFO] [stderr] 128 | pause_trigger: Arc::new((Mutex::new(true), Condvar::new())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / error_chain! { [INFO] [stderr] 70 | | foreign_links { [INFO] [stderr] 71 | | Io(std::io::Error); [INFO] [stderr] 72 | | Lua(hlua::LuaError); [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:277:40 [INFO] [stderr] | [INFO] [stderr] 277 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 278 | | descr = "verify_false" [INFO] [stderr] 279 | | [INFO] [stderr] 280 | | function verify(user, password) [INFO] [stderr] 281 | | return false [INFO] [stderr] 282 | | end [INFO] [stderr] 283 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 277 | let script = Script::load_from(br#" [INFO] [stderr] 278 | descr = "verify_false" [INFO] [stderr] 279 | [INFO] [stderr] 280 | function verify(user, password) [INFO] [stderr] 281 | return false [INFO] [stderr] 282 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:291:40 [INFO] [stderr] | [INFO] [stderr] 291 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 292 | | descr = "verify_false" [INFO] [stderr] 293 | | [INFO] [stderr] 294 | | function verify(user, password) [INFO] [stderr] 295 | | return true [INFO] [stderr] 296 | | end [INFO] [stderr] 297 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 291 | let script = Script::load_from(br#" [INFO] [stderr] 292 | descr = "verify_false" [INFO] [stderr] 293 | [INFO] [stderr] 294 | function verify(user, password) [INFO] [stderr] 295 | return true [INFO] [stderr] 296 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:305:40 [INFO] [stderr] | [INFO] [stderr] 305 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 306 | | descr = "json" [INFO] [stderr] 307 | | [INFO] [stderr] 308 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 311 | | end [INFO] [stderr] 312 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 305 | let script = Script::load_from(br#" [INFO] [stderr] 306 | descr = "json" [INFO] [stderr] 307 | [INFO] [stderr] 308 | function verify(user, password) [INFO] [stderr] 309 | json_decode("{{{{{{{{{{{{{{{{{{") [INFO] [stderr] 310 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:320:40 [INFO] [stderr] | [INFO] [stderr] 320 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 321 | | descr = "json" [INFO] [stderr] 322 | | [INFO] [stderr] 323 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 327 | | end [INFO] [stderr] 328 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 320 | let script = Script::load_from(br#" [INFO] [stderr] 321 | descr = "json" [INFO] [stderr] 322 | [INFO] [stderr] 323 | function verify(user, password) [INFO] [stderr] 324 | json_decode("{{{{{{{{{{{{{{{{{{") [INFO] [stderr] 325 | clear_err() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:336:40 [INFO] [stderr] | [INFO] [stderr] 336 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 337 | | descr = "slow script" [INFO] [stderr] 338 | | [INFO] [stderr] 339 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 342 | | end [INFO] [stderr] 343 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 336 | let script = Script::load_from(br#" [INFO] [stderr] 337 | descr = "slow script" [INFO] [stderr] 338 | [INFO] [stderr] 339 | function verify(user, password) [INFO] [stderr] 340 | sleep(1) [INFO] [stderr] 341 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:351:40 [INFO] [stderr] | [INFO] [stderr] 351 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 352 | | descr = "basic auth httpbin.org" [INFO] [stderr] 353 | | [INFO] [stderr] 354 | | function verify(user, password) [INFO] [stderr] 355 | | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 356 | | end [INFO] [stderr] 357 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 351 | let script = Script::load_from(br#" [INFO] [stderr] 352 | descr = "basic auth httpbin.org" [INFO] [stderr] 353 | [INFO] [stderr] 354 | function verify(user, password) [INFO] [stderr] 355 | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 356 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:365:40 [INFO] [stderr] | [INFO] [stderr] 365 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 366 | | descr = "basic auth httpbin.org" [INFO] [stderr] 367 | | [INFO] [stderr] 368 | | function verify(user, password) [INFO] [stderr] 369 | | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 370 | | end [INFO] [stderr] 371 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 365 | let script = Script::load_from(br#" [INFO] [stderr] 366 | descr = "basic auth httpbin.org" [INFO] [stderr] 367 | [INFO] [stderr] 368 | function verify(user, password) [INFO] [stderr] 369 | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 370 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:379:40 [INFO] [stderr] | [INFO] [stderr] 379 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 380 | | descr = "hex test" [INFO] [stderr] 381 | | [INFO] [stderr] 382 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 385 | | end [INFO] [stderr] 386 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 379 | let script = Script::load_from(br#" [INFO] [stderr] 380 | descr = "hex test" [INFO] [stderr] 381 | [INFO] [stderr] 382 | function verify(user, password) [INFO] [stderr] 383 | x = hex({0x6F, 0x68, 0x61, 0x69, 0x0A, 0x00}) [INFO] [stderr] 384 | return x == "6f6861690a00" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:394:40 [INFO] [stderr] | [INFO] [stderr] 394 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 395 | | descr = "hex test" [INFO] [stderr] 396 | | [INFO] [stderr] 397 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 400 | | end [INFO] [stderr] 401 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 394 | let script = Script::load_from(br#" [INFO] [stderr] 395 | descr = "hex test" [INFO] [stderr] 396 | [INFO] [stderr] 397 | function verify(user, password) [INFO] [stderr] 398 | x = hex({}) [INFO] [stderr] 399 | return x == "" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:409:40 [INFO] [stderr] | [INFO] [stderr] 409 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 410 | | descr = "json" [INFO] [stderr] 411 | | [INFO] [stderr] 412 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 424 | | end [INFO] [stderr] 425 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 409 | let script = Script::load_from(br#" [INFO] [stderr] 410 | descr = "json" [INFO] [stderr] 411 | [INFO] [stderr] 412 | function verify(user, password) [INFO] [stderr] 413 | json_encode({ [INFO] [stderr] 414 | hello="world", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:433:40 [INFO] [stderr] | [INFO] [stderr] 433 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 434 | | descr = "json" [INFO] [stderr] 435 | | [INFO] [stderr] 436 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 450 | | end [INFO] [stderr] 451 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 433 | let script = Script::load_from(br#" [INFO] [stderr] 434 | descr = "json" [INFO] [stderr] 435 | [INFO] [stderr] 436 | function verify(user, password) [INFO] [stderr] 437 | x = json_encode({ [INFO] [stderr] 438 | hello="world", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:459:40 [INFO] [stderr] | [INFO] [stderr] 459 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 460 | | descr = "json" [INFO] [stderr] 461 | | [INFO] [stderr] 462 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 465 | | end [INFO] [stderr] 466 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 459 | let script = Script::load_from(br#" [INFO] [stderr] 460 | descr = "json" [INFO] [stderr] 461 | [INFO] [stderr] 462 | function verify(user, password) [INFO] [stderr] 463 | json_decode("{\"almost_one\":0.9999,\"data\":{\"password\":\"fizz\",\"user\":\"bar\"},\"hello\":\"world\",\"list\":[1,3,3,7]}") [INFO] [stderr] 464 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:474:40 [INFO] [stderr] | [INFO] [stderr] 474 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 475 | | descr = "json" [INFO] [stderr] 476 | | [INFO] [stderr] 477 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 480 | | end [INFO] [stderr] 481 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 474 | let script = Script::load_from(br#" [INFO] [stderr] 475 | descr = "json" [INFO] [stderr] 476 | [INFO] [stderr] 477 | function verify(user, password) [INFO] [stderr] 478 | json_decode("{\"almost_one\":0.9999,\"data\":{\"password\":\"fizz\",\"user\":\"bar\"}}}}}}}}}") [INFO] [stderr] 479 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:489:40 [INFO] [stderr] | [INFO] [stderr] 489 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 490 | | descr = "hmac_md5" [INFO] [stderr] 491 | | [INFO] [stderr] 492 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 496 | | end [INFO] [stderr] 497 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 489 | let script = Script::load_from(br#" [INFO] [stderr] 490 | descr = "hmac_md5" [INFO] [stderr] 491 | [INFO] [stderr] 492 | function verify(user, password) [INFO] [stderr] 493 | x = hex(hmac_md5("foo", "bar")) [INFO] [stderr] 494 | -- print('md5: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:505:40 [INFO] [stderr] | [INFO] [stderr] 505 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 506 | | descr = "hmac_sha1" [INFO] [stderr] 507 | | [INFO] [stderr] 508 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 512 | | end [INFO] [stderr] 513 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 505 | let script = Script::load_from(br#" [INFO] [stderr] 506 | descr = "hmac_sha1" [INFO] [stderr] 507 | [INFO] [stderr] 508 | function verify(user, password) [INFO] [stderr] 509 | x = hex(hmac_sha1("foo", "bar")) [INFO] [stderr] 510 | -- print('sha1: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:521:40 [INFO] [stderr] | [INFO] [stderr] 521 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 522 | | descr = "hmac_sha2_256" [INFO] [stderr] 523 | | [INFO] [stderr] 524 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 528 | | end [INFO] [stderr] 529 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 521 | let script = Script::load_from(br#" [INFO] [stderr] 522 | descr = "hmac_sha2_256" [INFO] [stderr] 523 | [INFO] [stderr] 524 | function verify(user, password) [INFO] [stderr] 525 | x = hex(hmac_sha2_256("foo", "bar")) [INFO] [stderr] 526 | -- print('sha2_256: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:537:40 [INFO] [stderr] | [INFO] [stderr] 537 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 538 | | descr = "hmac_sha2_512" [INFO] [stderr] 539 | | [INFO] [stderr] 540 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 544 | | end [INFO] [stderr] 545 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 537 | let script = Script::load_from(br#" [INFO] [stderr] 538 | descr = "hmac_sha2_512" [INFO] [stderr] 539 | [INFO] [stderr] 540 | function verify(user, password) [INFO] [stderr] 541 | x = hex(hmac_sha2_512("foo", "bar")) [INFO] [stderr] 542 | -- print('sha2_512: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:553:40 [INFO] [stderr] | [INFO] [stderr] 553 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 554 | | descr = "hmac_sha3_256" [INFO] [stderr] 555 | | [INFO] [stderr] 556 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 560 | | end [INFO] [stderr] 561 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 553 | let script = Script::load_from(br#" [INFO] [stderr] 554 | descr = "hmac_sha3_256" [INFO] [stderr] 555 | [INFO] [stderr] 556 | function verify(user, password) [INFO] [stderr] 557 | x = hex(hmac_sha3_256("foo", "bar")) [INFO] [stderr] 558 | -- print('sha3_256: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:569:40 [INFO] [stderr] | [INFO] [stderr] 569 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 570 | | descr = "hmac_sha3_512" [INFO] [stderr] 571 | | [INFO] [stderr] 572 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 576 | | end [INFO] [stderr] 577 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 569 | let script = Script::load_from(br#" [INFO] [stderr] 570 | descr = "hmac_sha3_512" [INFO] [stderr] 571 | [INFO] [stderr] 572 | function verify(user, password) [INFO] [stderr] 573 | x = hex(hmac_sha3_512("foo", "bar")) [INFO] [stderr] 574 | -- print('sha3_512: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:585:40 [INFO] [stderr] | [INFO] [stderr] 585 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 586 | | descr = "bcrypt_verify" [INFO] [stderr] 587 | | [INFO] [stderr] 588 | | function verify(user, password) [INFO] [stderr] 589 | | return bcrypt_verify(password, "$2a$12$ByUlHCHx3rxMsdQONpuFbulQqut6GQ/84I5EAUkCqTTI07JA7wUju") [INFO] [stderr] 590 | | end [INFO] [stderr] 591 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 585 | let script = Script::load_from(br#" [INFO] [stderr] 586 | descr = "bcrypt_verify" [INFO] [stderr] 587 | [INFO] [stderr] 588 | function verify(user, password) [INFO] [stderr] 589 | return bcrypt_verify(password, "$2a$12$ByUlHCHx3rxMsdQONpuFbulQqut6GQ/84I5EAUkCqTTI07JA7wUju") [INFO] [stderr] 590 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(x) => Ok(x.into_iter().map(|x| transform_element(&x)).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/scheduler.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | Attempt(Box, Result), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/scheduler.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | Attempt(Box, Result), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scheduler.rs:128:38 [INFO] [stderr] | [INFO] [stderr] 128 | pause_trigger: Arc::new((Mutex::new(true), Condvar::new())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / error_chain! { [INFO] [stderr] 70 | | foreign_links { [INFO] [stderr] 71 | | Io(std::io::Error); [INFO] [stderr] 72 | | Lua(hlua::LuaError); [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/load-creds.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | let path = env::args().skip(1).next().expect("missing argument"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 48s [INFO] running `"docker" "inspect" "ae217f403f3e4768c62732ba4cb6a70116b8b593ae0a550495ff36c9340cf96b"` [INFO] running `"docker" "rm" "-f" "ae217f403f3e4768c62732ba4cb6a70116b8b593ae0a550495ff36c9340cf96b"` [INFO] [stdout] ae217f403f3e4768c62732ba4cb6a70116b8b593ae0a550495ff36c9340cf96b