[INFO] crate backup_rat 0.4.1 is already in cache [INFO] extracting crate backup_rat 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/backup_rat/0.4.1 [INFO] extracting crate backup_rat 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/backup_rat/0.4.1 [INFO] validating manifest of backup_rat-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of backup_rat-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing backup_rat-0.4.1 [INFO] finished frobbing backup_rat-0.4.1 [INFO] frobbed toml for backup_rat-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/backup_rat/0.4.1/Cargo.toml [INFO] started frobbing backup_rat-0.4.1 [INFO] finished frobbing backup_rat-0.4.1 [INFO] frobbed toml for backup_rat-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/backup_rat/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting backup_rat-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/backup_rat/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd016a80597680b365abc6b889acc600b816e591abfc7035de2688e4172e5d3e [INFO] running `"docker" "start" "-a" "cd016a80597680b365abc6b889acc600b816e591abfc7035de2688e4172e5d3e"` [INFO] [stderr] Checking backup_rat v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | targets: targets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `targets` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | targets: targets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `targets` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/operation.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 41 | | if let Ok(size) = size_of(spath) { [INFO] [stderr] 42 | | sum += size; [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | } else if let Ok(size) = size_of(spath) { [INFO] [stderr] 41 | sum += size; [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/operation.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 79 | | if path.file_name().unwrap().to_str().unwrap() == filter { [INFO] [stderr] 80 | | return true; [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | } else if path.file_name().unwrap().to_str().unwrap() == filter { [INFO] [stderr] 79 | return true; [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/operation.rs:93:20 [INFO] [stderr] | [INFO] [stderr] 93 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 94 | | if path.as_os_str().to_str().unwrap() == filter { [INFO] [stderr] 95 | | return true; [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 93 | } else if path.as_os_str().to_str().unwrap() == filter { [INFO] [stderr] 94 | return true; [INFO] [stderr] 95 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/operation.rs:293:21 [INFO] [stderr] | [INFO] [stderr] 293 | / if create_dir_all(to.parent().unwrap()).is_ok() { [INFO] [stderr] 294 | | if copy(from, to).is_ok() { [INFO] [stderr] 295 | | num += 1; [INFO] [stderr] 296 | | } [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 293 | if create_dir_all(to.parent().unwrap()).is_ok() && copy(from, to).is_ok() { [INFO] [stderr] 294 | num += 1; [INFO] [stderr] 295 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/operation.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 41 | | if let Ok(size) = size_of(spath) { [INFO] [stderr] 42 | | sum += size; [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | } else if let Ok(size) = size_of(spath) { [INFO] [stderr] 41 | sum += size; [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/operation.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 79 | | if path.file_name().unwrap().to_str().unwrap() == filter { [INFO] [stderr] 80 | | return true; [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | } else if path.file_name().unwrap().to_str().unwrap() == filter { [INFO] [stderr] 79 | return true; [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/operation.rs:93:20 [INFO] [stderr] | [INFO] [stderr] 93 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 94 | | if path.as_os_str().to_str().unwrap() == filter { [INFO] [stderr] 95 | | return true; [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 93 | } else if path.as_os_str().to_str().unwrap() == filter { [INFO] [stderr] 94 | return true; [INFO] [stderr] 95 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/operation.rs:293:21 [INFO] [stderr] | [INFO] [stderr] 293 | / if create_dir_all(to.parent().unwrap()).is_ok() { [INFO] [stderr] 294 | | if copy(from, to).is_ok() { [INFO] [stderr] 295 | | num += 1; [INFO] [stderr] 296 | | } [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 293 | if create_dir_all(to.parent().unwrap()).is_ok() && copy(from, to).is_ok() { [INFO] [stderr] 294 | num += 1; [INFO] [stderr] 295 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/config.rs:102:39 [INFO] [stderr] | [INFO] [stderr] 102 | ignore_files: target.ignore_files.unwrap_or(Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `target.ignore_files.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/config.rs:103:41 [INFO] [stderr] | [INFO] [stderr] 103 | ignore_folders: target.ignore_folders.unwrap_or(Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `target.ignore_folders.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:121:22 [INFO] [stderr] | [INFO] [stderr] 121 | .unwrap_or(BaseDirs::new().expect("Could not get base directories").home_dir().join(".backup_rat")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| BaseDirs::new().expect("Could not get base directories").home_dir().join(".backup_rat"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/operation.rs:66:20 [INFO] [stderr] | [INFO] [stderr] 66 | ignored_files: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/operation.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | ignored_folders: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/operation.rs:354:40 [INFO] [stderr] | [INFO] [stderr] 354 | } else { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 355 | | read_files.push(( [INFO] [stderr] 356 | | entry.path(), [INFO] [stderr] 357 | | file_parent.join(file_path.file_name().unwrap()), [INFO] [stderr] 358 | | )); [INFO] [stderr] 359 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/operation.rs:349:67 [INFO] [stderr] | [INFO] [stderr] 349 | if f.metadata().unwrap().is_dir() { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 350 | | read_files.push(( [INFO] [stderr] 351 | | entry.path(), [INFO] [stderr] 352 | | file_parent.join(file_path.file_name().unwrap()), [INFO] [stderr] 353 | | )); [INFO] [stderr] 354 | | } else { [INFO] [stderr] | |_________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `dir_names` [INFO] [stderr] --> src/operation.rs:422:26 [INFO] [stderr] | [INFO] [stderr] 422 | for i in 1..dir_names.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 422 | for (i, ) in dir_names.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/operation.rs:460:5 [INFO] [stderr] | [INFO] [stderr] 460 | / let res; [INFO] [stderr] 461 | | if threads > 1 { [INFO] [stderr] 462 | | res = threaded_copy_to(target, threads)?; [INFO] [stderr] 463 | | } else { [INFO] [stderr] 464 | | res = copy_to(target)?; [INFO] [stderr] 465 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let res = if threads > 1 { threaded_copy_to(target, threads)? } else { copy_to(target)? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / let mut threads = 1; [INFO] [stderr] 71 | | if config.multi_threaded { [INFO] [stderr] 72 | | threads = config.threads; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let threads = if config.multi_threaded { config.threads } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | / let mut threads = 1; [INFO] [stderr] 98 | | if config.multi_threaded { [INFO] [stderr] 99 | | threads = config.threads; [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let threads = if config.multi_threaded { config.threads } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `backup_rat`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/config.rs:102:39 [INFO] [stderr] | [INFO] [stderr] 102 | ignore_files: target.ignore_files.unwrap_or(Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `target.ignore_files.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/config.rs:103:41 [INFO] [stderr] | [INFO] [stderr] 103 | ignore_folders: target.ignore_folders.unwrap_or(Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `target.ignore_folders.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:121:22 [INFO] [stderr] | [INFO] [stderr] 121 | .unwrap_or(BaseDirs::new().expect("Could not get base directories").home_dir().join(".backup_rat")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| BaseDirs::new().expect("Could not get base directories").home_dir().join(".backup_rat"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/operation.rs:66:20 [INFO] [stderr] | [INFO] [stderr] 66 | ignored_files: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/operation.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | ignored_folders: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/operation.rs:354:40 [INFO] [stderr] | [INFO] [stderr] 354 | } else { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 355 | | read_files.push(( [INFO] [stderr] 356 | | entry.path(), [INFO] [stderr] 357 | | file_parent.join(file_path.file_name().unwrap()), [INFO] [stderr] 358 | | )); [INFO] [stderr] 359 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/operation.rs:349:67 [INFO] [stderr] | [INFO] [stderr] 349 | if f.metadata().unwrap().is_dir() { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 350 | | read_files.push(( [INFO] [stderr] 351 | | entry.path(), [INFO] [stderr] 352 | | file_parent.join(file_path.file_name().unwrap()), [INFO] [stderr] 353 | | )); [INFO] [stderr] 354 | | } else { [INFO] [stderr] | |_________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `dir_names` [INFO] [stderr] --> src/operation.rs:422:26 [INFO] [stderr] | [INFO] [stderr] 422 | for i in 1..dir_names.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 422 | for (i, ) in dir_names.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/operation.rs:460:5 [INFO] [stderr] | [INFO] [stderr] 460 | / let res; [INFO] [stderr] 461 | | if threads > 1 { [INFO] [stderr] 462 | | res = threaded_copy_to(target, threads)?; [INFO] [stderr] 463 | | } else { [INFO] [stderr] 464 | | res = copy_to(target)?; [INFO] [stderr] 465 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let res = if threads > 1 { threaded_copy_to(target, threads)? } else { copy_to(target)? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / let mut threads = 1; [INFO] [stderr] 71 | | if config.multi_threaded { [INFO] [stderr] 72 | | threads = config.threads; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let threads = if config.multi_threaded { config.threads } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | / let mut threads = 1; [INFO] [stderr] 98 | | if config.multi_threaded { [INFO] [stderr] 99 | | threads = config.threads; [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let threads = if config.multi_threaded { config.threads } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `backup_rat`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cd016a80597680b365abc6b889acc600b816e591abfc7035de2688e4172e5d3e"` [INFO] running `"docker" "rm" "-f" "cd016a80597680b365abc6b889acc600b816e591abfc7035de2688e4172e5d3e"` [INFO] [stdout] cd016a80597680b365abc6b889acc600b816e591abfc7035de2688e4172e5d3e