[INFO] crate backr 0.5.0 is already in cache [INFO] extracting crate backr 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/backr/0.5.0 [INFO] extracting crate backr 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/backr/0.5.0 [INFO] validating manifest of backr-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of backr-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing backr-0.5.0 [INFO] finished frobbing backr-0.5.0 [INFO] frobbed toml for backr-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/backr/0.5.0/Cargo.toml [INFO] started frobbing backr-0.5.0 [INFO] finished frobbing backr-0.5.0 [INFO] frobbed toml for backr-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/backr/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting backr-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/backr/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d5577670453dd5153b287602f4a4b9047160cd47c72e4a96e321fb546ff40a2 [INFO] running `"docker" "start" "-a" "1d5577670453dd5153b287602f4a4b9047160cd47c72e4a96e321fb546ff40a2"` [INFO] [stderr] Checking progress v0.2.0 [INFO] [stderr] Checking backr v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/main.rs:357:16 [INFO] [stderr] | [INFO] [stderr] 357 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/main.rs:357:16 [INFO] [stderr] | [INFO] [stderr] 357 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match check_permissions(gvars.get_source(), gvars.get_dest()) { [INFO] [stderr] 79 | | true => { [INFO] [stderr] 80 | | if gvars.quite() { [INFO] [stderr] 81 | | println!( [INFO] [stderr] ... | [INFO] [stderr] 126 | | false => (), [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 78 | if check_permissions(gvars.get_source(), gvars.get_dest()) { [INFO] [stderr] 79 | if gvars.quite() { [INFO] [stderr] 80 | println!( [INFO] [stderr] 81 | "** {:?} is being used as the source directory \ [INFO] [stderr] 82 | \n** {:?} is being used as the destination directory \ [INFO] [stderr] 83 | \n** Searching for files to backup...", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | let mut bar = Bar::new(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:261:22 [INFO] [stderr] | [INFO] [stderr] 261 | let dest_write = match dest.exists() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 262 | | // Dest exists try to create a file in it [INFO] [stderr] 263 | | true => { [INFO] [stderr] 264 | | let tmp_path = dest.join("CanIWriteHere?.txt"); [INFO] [stderr] ... | [INFO] [stderr] 283 | | }, [INFO] [stderr] 284 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 261 | let dest_write = if dest.exists() { [INFO] [stderr] 262 | let tmp_path = dest.join("CanIWriteHere?.txt"); [INFO] [stderr] 263 | match fs::write(&tmp_path, "Yes I can!") { [INFO] [stderr] 264 | Ok(_) => { [INFO] [stderr] 265 | fs::remove_file(tmp_path).unwrap(); [INFO] [stderr] 266 | true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | / match update { [INFO] [stderr] 319 | | // update flag is set [INFO] [stderr] 320 | | true => { [INFO] [stderr] 321 | | // If the existing destination file is newer than the source file, ignore it and continue looping [INFO] [stderr] ... | [INFO] [stderr] 334 | | } [INFO] [stderr] 335 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 318 | if update { [INFO] [stderr] 319 | // If the existing destination file is newer than the source file, ignore it and continue looping [INFO] [stderr] 320 | if tmp_dest.exists() [INFO] [stderr] 321 | && (src.metadata().unwrap().modified().unwrap() [INFO] [stderr] 322 | < tmp_dest.metadata().unwrap().modified().unwrap()) [INFO] [stderr] 323 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:483:21 [INFO] [stderr] | [INFO] [stderr] 483 | let regex = match cli.is_present("all") { [INFO] [stderr] | _____________________^ [INFO] [stderr] 484 | | true => r#".*"#, [INFO] [stderr] 485 | | false => cli.value_of("regex").unwrap_or_default(), [INFO] [stderr] 486 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if cli.is_present("all") { r#".*"# } else { cli.value_of("regex").unwrap_or_default() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match check_permissions(gvars.get_source(), gvars.get_dest()) { [INFO] [stderr] 79 | | true => { [INFO] [stderr] 80 | | if gvars.quite() { [INFO] [stderr] 81 | | println!( [INFO] [stderr] ... | [INFO] [stderr] 126 | | false => (), [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 78 | if check_permissions(gvars.get_source(), gvars.get_dest()) { [INFO] [stderr] 79 | if gvars.quite() { [INFO] [stderr] 80 | println!( [INFO] [stderr] 81 | "** {:?} is being used as the source directory \ [INFO] [stderr] 82 | \n** {:?} is being used as the destination directory \ [INFO] [stderr] 83 | \n** Searching for files to backup...", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | let mut bar = Bar::new(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:261:22 [INFO] [stderr] | [INFO] [stderr] 261 | let dest_write = match dest.exists() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 262 | | // Dest exists try to create a file in it [INFO] [stderr] 263 | | true => { [INFO] [stderr] 264 | | let tmp_path = dest.join("CanIWriteHere?.txt"); [INFO] [stderr] ... | [INFO] [stderr] 283 | | }, [INFO] [stderr] 284 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 261 | let dest_write = if dest.exists() { [INFO] [stderr] 262 | let tmp_path = dest.join("CanIWriteHere?.txt"); [INFO] [stderr] 263 | match fs::write(&tmp_path, "Yes I can!") { [INFO] [stderr] 264 | Ok(_) => { [INFO] [stderr] 265 | fs::remove_file(tmp_path).unwrap(); [INFO] [stderr] 266 | true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | / match update { [INFO] [stderr] 319 | | // update flag is set [INFO] [stderr] 320 | | true => { [INFO] [stderr] 321 | | // If the existing destination file is newer than the source file, ignore it and continue looping [INFO] [stderr] ... | [INFO] [stderr] 334 | | } [INFO] [stderr] 335 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 318 | if update { [INFO] [stderr] 319 | // If the existing destination file is newer than the source file, ignore it and continue looping [INFO] [stderr] 320 | if tmp_dest.exists() [INFO] [stderr] 321 | && (src.metadata().unwrap().modified().unwrap() [INFO] [stderr] 322 | < tmp_dest.metadata().unwrap().modified().unwrap()) [INFO] [stderr] 323 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:483:21 [INFO] [stderr] | [INFO] [stderr] 483 | let regex = match cli.is_present("all") { [INFO] [stderr] | _____________________^ [INFO] [stderr] 484 | | true => r#".*"#, [INFO] [stderr] 485 | | false => cli.value_of("regex").unwrap_or_default(), [INFO] [stderr] 486 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if cli.is_present("all") { r#".*"# } else { cli.value_of("regex").unwrap_or_default() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.34s [INFO] running `"docker" "inspect" "1d5577670453dd5153b287602f4a4b9047160cd47c72e4a96e321fb546ff40a2"` [INFO] running `"docker" "rm" "-f" "1d5577670453dd5153b287602f4a4b9047160cd47c72e4a96e321fb546ff40a2"` [INFO] [stdout] 1d5577670453dd5153b287602f4a4b9047160cd47c72e4a96e321fb546ff40a2