[INFO] crate background-jobs-core 0.3.1 is already in cache
[INFO] extracting crate background-jobs-core 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/background-jobs-core/0.3.1
[INFO] extracting crate background-jobs-core 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/background-jobs-core/0.3.1
[INFO] validating manifest of background-jobs-core-0.3.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of background-jobs-core-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing background-jobs-core-0.3.1
[INFO] finished frobbing background-jobs-core-0.3.1
[INFO] frobbed toml for background-jobs-core-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/background-jobs-core/0.3.1/Cargo.toml
[INFO] started frobbing background-jobs-core-0.3.1
[INFO] finished frobbing background-jobs-core-0.3.1
[INFO] frobbed toml for background-jobs-core-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/background-jobs-core/0.3.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting background-jobs-core-0.3.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/background-jobs-core/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bff55e6069accf7a4af9dac1a14dc37d336a51c44b64609e484ca3f6c782e622
[INFO] running `"docker" "start" "-a" "bff55e6069accf7a4af9dac1a14dc37d336a51c44b64609e484ca3f6c782e622"`
[INFO] [stderr]     Checking lmdb v0.8.0
[INFO] [stderr]     Checking kv v0.7.0
[INFO] [stderr]     Checking background-jobs-core v0.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/storage.rs:319:9
[INFO] [stderr]     |
[INFO] [stderr] 319 | /         if job.is_failed() {
[INFO] [stderr] 320 | |             if job.increment().should_requeue() {
[INFO] [stderr] 321 | |                 job.pending();
[INFO] [stderr] 322 | |                 job.next_queue();
[INFO] [stderr] 323 | |             }
[INFO] [stderr] 324 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 319 |         if job.is_failed() && job.increment().should_requeue() {
[INFO] [stderr] 320 |     job.pending();
[INFO] [stderr] 321 |     job.next_queue();
[INFO] [stderr] 322 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/storage.rs:319:9
[INFO] [stderr]     |
[INFO] [stderr] 319 | /         if job.is_failed() {
[INFO] [stderr] 320 | |             if job.increment().should_requeue() {
[INFO] [stderr] 321 | |                 job.pending();
[INFO] [stderr] 322 | |                 job.next_queue();
[INFO] [stderr] 323 | |             }
[INFO] [stderr] 324 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 319 |         if job.is_failed() && job.increment().should_requeue() {
[INFO] [stderr] 320 |     job.pending();
[INFO] [stderr] 321 |     job.next_queue();
[INFO] [stderr] 322 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/job_info.rs:103:9
[INFO] [stderr]     |
[INFO] [stderr] 103 |         self.id.clone()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.id`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/job_info.rs:103:9
[INFO] [stderr]     |
[INFO] [stderr] 103 |         self.id.clone()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.id`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/storage.rs:364:48
[INFO] [stderr]     |
[INFO] [stderr] 364 |         let store = self.store.write().map_err(|e| Error::from(e))?;
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/storage.rs:364:48
[INFO] [stderr]     |
[INFO] [stderr] 364 |         let store = self.store.write().map_err(|e| Error::from(e))?;
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.85s
[INFO] running `"docker" "inspect" "bff55e6069accf7a4af9dac1a14dc37d336a51c44b64609e484ca3f6c782e622"`
[INFO] running `"docker" "rm" "-f" "bff55e6069accf7a4af9dac1a14dc37d336a51c44b64609e484ca3f6c782e622"`
[INFO] [stdout] bff55e6069accf7a4af9dac1a14dc37d336a51c44b64609e484ca3f6c782e622