[INFO] crate ax25 0.1.0 is already in cache
[INFO] extracting crate ax25 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/ax25/0.1.0
[INFO] extracting crate ax25 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ax25/0.1.0
[INFO] validating manifest of ax25-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ax25-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ax25-0.1.0
[INFO] finished frobbing ax25-0.1.0
[INFO] frobbed toml for ax25-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ax25/0.1.0/Cargo.toml
[INFO] started frobbing ax25-0.1.0
[INFO] finished frobbing ax25-0.1.0
[INFO] frobbed toml for ax25-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ax25/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ax25-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ax25/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 01ae5e101ab2394d6c7ecdd1a205169517e4e4cf00101eef4a04b997a3db22bb
[INFO] running `"docker" "start" "-a" "01ae5e101ab2394d6c7ecdd1a205169517e4e4cf00101eef4a04b997a3db22bb"`
[INFO] [stderr]     Checking ax25 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:364:22
[INFO] [stderr]     |
[INFO] [stderr] 364 |         Ok(Address { callsign: callsign, ssid: ssid, c_bit: false })
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^ help: replace it with: `callsign`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:364:42
[INFO] [stderr]     |
[INFO] [stderr] 364 |         Ok(Address { callsign: callsign, ssid: ssid, c_bit: false })
[INFO] [stderr]     |                                          ^^^^^^^^^^ help: replace it with: `ssid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:425:17
[INFO] [stderr]     |
[INFO] [stderr] 425 |                 repeater: repeater,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `repeater`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:440:13
[INFO] [stderr]     |
[INFO] [stderr] 440 |             route: route,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `route`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:441:13
[INFO] [stderr]     |
[INFO] [stderr] 441 |             content: content,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `content`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:442:13
[INFO] [stderr]     |
[INFO] [stderr] 442 |             command_or_response: command_or_response
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_or_response`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:516:13
[INFO] [stderr]     |
[INFO] [stderr] 516 |             poll_or_final: poll_or_final
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `poll_or_final`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:520:13
[INFO] [stderr]     |
[INFO] [stderr] 520 |             poll_or_final: poll_or_final
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `poll_or_final`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:524:13
[INFO] [stderr]     |
[INFO] [stderr] 524 |             poll_or_final: poll_or_final
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `poll_or_final`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:364:22
[INFO] [stderr]     |
[INFO] [stderr] 364 |         Ok(Address { callsign: callsign, ssid: ssid, c_bit: false })
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^ help: replace it with: `callsign`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:364:42
[INFO] [stderr]     |
[INFO] [stderr] 364 |         Ok(Address { callsign: callsign, ssid: ssid, c_bit: false })
[INFO] [stderr]     |                                          ^^^^^^^^^^ help: replace it with: `ssid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:425:17
[INFO] [stderr]     |
[INFO] [stderr] 425 |                 repeater: repeater,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `repeater`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:440:13
[INFO] [stderr]     |
[INFO] [stderr] 440 |             route: route,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `route`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:441:13
[INFO] [stderr]     |
[INFO] [stderr] 441 |             content: content,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `content`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:442:13
[INFO] [stderr]     |
[INFO] [stderr] 442 |             command_or_response: command_or_response
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_or_response`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:516:13
[INFO] [stderr]     |
[INFO] [stderr] 516 |             poll_or_final: poll_or_final
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `poll_or_final`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:520:13
[INFO] [stderr]     |
[INFO] [stderr] 520 |             poll_or_final: poll_or_final
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `poll_or_final`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/frame.rs:524:13
[INFO] [stderr]     |
[INFO] [stderr] 524 |             poll_or_final: poll_or_final
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `poll_or_final`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/frame.rs:29:26
[INFO] [stderr]    |
[INFO] [stderr] 29 |             pid if pid & 0b00110000 == 0b00010000
[INFO] [stderr]    |                          ^^^^^^^^^^ help: consider: `0b0011_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/frame.rs:29:40
[INFO] [stderr]    |
[INFO] [stderr] 29 |             pid if pid & 0b00110000 == 0b00010000
[INFO] [stderr]    |                                        ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/frame.rs:30:26
[INFO] [stderr]    |
[INFO] [stderr] 30 |                 || pid & 0b00110000 == 0b00100000 => ProtocolIdentifier::Layer3Impl,
[INFO] [stderr]    |                          ^^^^^^^^^^ help: consider: `0b0011_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/frame.rs:30:40
[INFO] [stderr]    |
[INFO] [stderr] 30 |                 || pid & 0b00110000 == 0b00100000 => ProtocolIdentifier::Layer3Impl,
[INFO] [stderr]    |                                        ^^^^^^^^^^ help: consider: `0b0010_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/frame.rs:51:48
[INFO] [stderr]    |
[INFO] [stderr] 51 |             &ProtocolIdentifier::Layer3Impl => 0b00010000,
[INFO] [stderr]    |                                                ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/frame.rs:284:9
[INFO] [stderr]     |
[INFO] [stderr] 284 |         return &self.msg;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.msg`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/frame.rs:29:26
[INFO] [stderr]    |
[INFO] [stderr] 29 |             pid if pid & 0b00110000 == 0b00010000
[INFO] [stderr]    |                          ^^^^^^^^^^ help: consider: `0b0011_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/frame.rs:29:40
[INFO] [stderr]    |
[INFO] [stderr] 29 |             pid if pid & 0b00110000 == 0b00010000
[INFO] [stderr]    |                                        ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/frame.rs:30:26
[INFO] [stderr]    |
[INFO] [stderr] 30 |                 || pid & 0b00110000 == 0b00100000 => ProtocolIdentifier::Layer3Impl,
[INFO] [stderr]    |                          ^^^^^^^^^^ help: consider: `0b0011_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/frame.rs:30:40
[INFO] [stderr]    |
[INFO] [stderr] 30 |                 || pid & 0b00110000 == 0b00100000 => ProtocolIdentifier::Layer3Impl,
[INFO] [stderr]    |                                        ^^^^^^^^^^ help: consider: `0b0010_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/frame.rs:51:48
[INFO] [stderr]    |
[INFO] [stderr] 51 |             &ProtocolIdentifier::Layer3Impl => 0b00010000,
[INFO] [stderr]    |                                                ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/frame.rs:284:9
[INFO] [stderr]     |
[INFO] [stderr] 284 |         return &self.msg;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.msg`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/frame.rs:27:24
[INFO] [stderr]    |
[INFO] [stderr] 27 |     fn from_byte(byte: &u8) -> ProtocolIdentifier {
[INFO] [stderr]    |                        ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/frame.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 | /         match self {
[INFO] [stderr] 51 | |             &ProtocolIdentifier::Layer3Impl => 0b00010000,
[INFO] [stderr] 52 | |             &ProtocolIdentifier::X25Plp => 0x01,
[INFO] [stderr] 53 | |             &ProtocolIdentifier::CompressedTcpIp => 0x06,
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |             &ProtocolIdentifier::Unknown(pid) => pid
[INFO] [stderr] 67 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 50 |         match *self {
[INFO] [stderr] 51 |             ProtocolIdentifier::Layer3Impl => 0b00010000,
[INFO] [stderr] 52 |             ProtocolIdentifier::X25Plp => 0x01,
[INFO] [stderr] 53 |             ProtocolIdentifier::CompressedTcpIp => 0x06,
[INFO] [stderr] 54 |             ProtocolIdentifier::UncompressedTcpIp => 0x07,
[INFO] [stderr] 55 |             ProtocolIdentifier::SegmentationFragment => 0x08,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]    --> src/frame.rs:242:36
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 frmr1 |= if fr.w { 1 << 0 } else { 0 };
[INFO] [stderr]     |                                    ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/frame.rs:343:40
[INFO] [stderr]     |
[INFO] [stderr] 343 |         let parts: Vec<&str> = s.split("-").collect();
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/frame.rs:349:12
[INFO] [stderr]     |
[INFO] [stderr] 349 |         if callsign.len() == 0 || callsign.len() > 6 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `callsign.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/frame.rs:407:61
[INFO] [stderr]     |
[INFO] [stderr] 407 |         let addr_start = bytes.iter().position(|&c| c != 0).ok_or(ParseError::new())?;
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(ParseError::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/frame.rs:408:69
[INFO] [stderr]     |
[INFO] [stderr] 408 |         let addr_end = bytes.iter().position(|&c| c & 0x01 == 0x01).ok_or(ParseError::new())?;
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(ParseError::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/frame.rs:502:15
[INFO] [stderr]     |
[INFO] [stderr] 502 |         info: bytes[2..].iter().cloned().collect() // could be empty vec
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/frame.rs:558:15
[INFO] [stderr]     |
[INFO] [stderr] 558 |         info: bytes[2..].iter().cloned().collect()
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/frame.rs:575:27
[INFO] [stderr]     |
[INFO] [stderr] 575 |           command_response: match bytes[2] & 0b0001_0000 > 0 {
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 576 | |             true => CommandResponse::Response,
[INFO] [stderr] 577 | |             false => CommandResponse::Command
[INFO] [stderr] 578 | |         },
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if bytes[2] & 0b0001_0000 > 0 { CommandResponse::Response } else { CommandResponse::Command }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/frame.rs:585:8
[INFO] [stderr]     |
[INFO] [stderr] 585 |     if bytes.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/frame.rs:27:24
[INFO] [stderr]    |
[INFO] [stderr] 27 |     fn from_byte(byte: &u8) -> ProtocolIdentifier {
[INFO] [stderr]    |                        ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/frame.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 | /         match self {
[INFO] [stderr] 51 | |             &ProtocolIdentifier::Layer3Impl => 0b00010000,
[INFO] [stderr] 52 | |             &ProtocolIdentifier::X25Plp => 0x01,
[INFO] [stderr] 53 | |             &ProtocolIdentifier::CompressedTcpIp => 0x06,
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |             &ProtocolIdentifier::Unknown(pid) => pid
[INFO] [stderr] 67 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 50 |         match *self {
[INFO] [stderr] 51 |             ProtocolIdentifier::Layer3Impl => 0b00010000,
[INFO] [stderr] 52 |             ProtocolIdentifier::X25Plp => 0x01,
[INFO] [stderr] 53 |             ProtocolIdentifier::CompressedTcpIp => 0x06,
[INFO] [stderr] 54 |             ProtocolIdentifier::UncompressedTcpIp => 0x07,
[INFO] [stderr] 55 |             ProtocolIdentifier::SegmentationFragment => 0x08,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]    --> src/frame.rs:242:36
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 frmr1 |= if fr.w { 1 << 0 } else { 0 };
[INFO] [stderr]     |                                    ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/frame.rs:343:40
[INFO] [stderr]     |
[INFO] [stderr] 343 |         let parts: Vec<&str> = s.split("-").collect();
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/frame.rs:349:12
[INFO] [stderr]     |
[INFO] [stderr] 349 |         if callsign.len() == 0 || callsign.len() > 6 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `callsign.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/frame.rs:407:61
[INFO] [stderr]     |
[INFO] [stderr] 407 |         let addr_start = bytes.iter().position(|&c| c != 0).ok_or(ParseError::new())?;
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(ParseError::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/frame.rs:408:69
[INFO] [stderr]     |
[INFO] [stderr] 408 |         let addr_end = bytes.iter().position(|&c| c & 0x01 == 0x01).ok_or(ParseError::new())?;
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(ParseError::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/frame.rs:502:15
[INFO] [stderr]     |
[INFO] [stderr] 502 |         info: bytes[2..].iter().cloned().collect() // could be empty vec
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/frame.rs:558:15
[INFO] [stderr]     |
[INFO] [stderr] 558 |         info: bytes[2..].iter().cloned().collect()
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/frame.rs:575:27
[INFO] [stderr]     |
[INFO] [stderr] 575 |           command_response: match bytes[2] & 0b0001_0000 > 0 {
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 576 | |             true => CommandResponse::Response,
[INFO] [stderr] 577 | |             false => CommandResponse::Command
[INFO] [stderr] 578 | |         },
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if bytes[2] & 0b0001_0000 > 0 { CommandResponse::Response } else { CommandResponse::Command }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/frame.rs:585:8
[INFO] [stderr]     |
[INFO] [stderr] 585 |     if bytes.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.29s
[INFO] running `"docker" "inspect" "01ae5e101ab2394d6c7ecdd1a205169517e4e4cf00101eef4a04b997a3db22bb"`
[INFO] running `"docker" "rm" "-f" "01ae5e101ab2394d6c7ecdd1a205169517e4e4cf00101eef4a04b997a3db22bb"`
[INFO] [stdout] 01ae5e101ab2394d6c7ecdd1a205169517e4e4cf00101eef4a04b997a3db22bb