[INFO] crate aws_lambda_events 0.1.0 is already in cache [INFO] extracting crate aws_lambda_events 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/aws_lambda_events/0.1.0 [INFO] extracting crate aws_lambda_events 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aws_lambda_events/0.1.0 [INFO] validating manifest of aws_lambda_events-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aws_lambda_events-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aws_lambda_events-0.1.0 [INFO] finished frobbing aws_lambda_events-0.1.0 [INFO] frobbed toml for aws_lambda_events-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/aws_lambda_events/0.1.0/Cargo.toml [INFO] started frobbing aws_lambda_events-0.1.0 [INFO] finished frobbing aws_lambda_events-0.1.0 [INFO] frobbed toml for aws_lambda_events-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aws_lambda_events/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aws_lambda_events-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/aws_lambda_events/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0cf3b1cc3732e66d74a10fa6ef973df54fbab08a01109176e8ef4c2d8da3321b [INFO] running `"docker" "start" "-a" "0cf3b1cc3732e66d74a10fa6ef973df54fbab08a01109176e8ef4c2d8da3321b"` [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking aws_lambda_events v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/custom_serde.rs:185:42 [INFO] [stderr] | [INFO] [stderr] 185 | let expected = Utc.ymd(2017, 10, 05).and_hms_nano(15, 33, 44, 0); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 185 | let expected = Utc.ymd(2017, 10, 5).and_hms_nano(15, 33, 44, 0); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 185 | let expected = Utc.ymd(2017, 10, 0o5).and_hms_nano(15, 33, 44, 0); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/custom_serde.rs:198:22 [INFO] [stderr] | [INFO] [stderr] 198 | "v": 1507217624302.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_507_217_624_302.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/custom_serde.rs:242:59 [INFO] [stderr] | [INFO] [stderr] 242 | v: Utc.ymd(1983, 7, 22).and_hms_nano(1, 0, 0, 1234_000_000), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_234_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/custom_serde.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | + date.timestamp_subsec_millis() as i64 * 10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date.timestamp_subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/custom_serde.rs:50:11 [INFO] [stderr] | [INFO] [stderr] 50 | + date.timestamp_subsec_nanos() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/custom_serde.rs:100:42 [INFO] [stderr] | [INFO] [stderr] 100 | pub(crate) fn serialize_base64(value: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/custom_serde.rs:138:8 [INFO] [stderr] | [INFO] [stderr] 138 | Ok(opt.unwrap_or(HashMap::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/custom_serde.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | + date.timestamp_subsec_millis() as i64 * 10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date.timestamp_subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/custom_serde.rs:50:11 [INFO] [stderr] | [INFO] [stderr] 50 | + date.timestamp_subsec_nanos() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/custom_serde.rs:100:42 [INFO] [stderr] | [INFO] [stderr] 100 | pub(crate) fn serialize_base64(value: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/custom_serde.rs:138:8 [INFO] [stderr] | [INFO] [stderr] 138 | Ok(opt.unwrap_or(HashMap::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/custom_serde.rs:172:16 [INFO] [stderr] | [INFO] [stderr] 172 | v: "Hello World".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello World"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/custom_serde.rs:194:52 [INFO] [stderr] | [INFO] [stderr] 194 | let decoded: Test = serde_json::from_slice(r#"{"v":1507217624302}"#.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `br#"{"v":1507217624302}"#` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.57s [INFO] running `"docker" "inspect" "0cf3b1cc3732e66d74a10fa6ef973df54fbab08a01109176e8ef4c2d8da3321b"` [INFO] running `"docker" "rm" "-f" "0cf3b1cc3732e66d74a10fa6ef973df54fbab08a01109176e8ef4c2d8da3321b"` [INFO] [stdout] 0cf3b1cc3732e66d74a10fa6ef973df54fbab08a01109176e8ef4c2d8da3321b