[INFO] crate awi 0.8.0 is already in cache [INFO] extracting crate awi 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/awi/0.8.0 [INFO] extracting crate awi 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/awi/0.8.0 [INFO] validating manifest of awi-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of awi-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing awi-0.8.0 [INFO] finished frobbing awi-0.8.0 [INFO] frobbed toml for awi-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/awi/0.8.0/Cargo.toml [INFO] started frobbing awi-0.8.0 [INFO] finished frobbing awi-0.8.0 [INFO] frobbed toml for awi-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/awi/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting awi-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/awi/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac320976c295415af6c7cc96ba1a2aa584110fcb861b92c2b0aa25208a8e40ed [INFO] running `"docker" "start" "-a" "ac320976c295415af6c7cc96ba1a2aa584110fcb861b92c2b0aa25208a8e40ed"` [INFO] [stderr] Checking awi v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os/windows/mod.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | Window { connection: connection, window: window, miw: true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os/windows/mod.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | Window { connection: connection, window: window, miw: true, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os/windows/mod.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | Window { connection: connection, window: window, miw: true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os/windows/mod.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | Window { connection: connection, window: window, miw: true, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:25:65 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn update(&mut self, queue: &mut Vec, input: Input) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:108:38 [INFO] [stderr] | [INFO] [stderr] 108 | fn a(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:117:38 [INFO] [stderr] | [INFO] [stderr] 117 | fn b(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:125:38 [INFO] [stderr] | [INFO] [stderr] 125 | fn c(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:133:38 [INFO] [stderr] | [INFO] [stderr] 133 | fn d(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:142:38 [INFO] [stderr] | [INFO] [stderr] 142 | fn e(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:151:38 [INFO] [stderr] | [INFO] [stderr] 151 | fn f(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | fn g(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:168:38 [INFO] [stderr] | [INFO] [stderr] 168 | fn h(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:176:38 [INFO] [stderr] | [INFO] [stderr] 176 | fn i(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:186:38 [INFO] [stderr] | [INFO] [stderr] 186 | fn j(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:195:38 [INFO] [stderr] | [INFO] [stderr] 195 | fn k(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:203:38 [INFO] [stderr] | [INFO] [stderr] 203 | fn l(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:212:38 [INFO] [stderr] | [INFO] [stderr] 212 | fn m(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:221:38 [INFO] [stderr] | [INFO] [stderr] 221 | fn n(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:230:38 [INFO] [stderr] | [INFO] [stderr] 230 | fn o(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:238:38 [INFO] [stderr] | [INFO] [stderr] 238 | fn p(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:246:38 [INFO] [stderr] | [INFO] [stderr] 246 | fn q(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:255:38 [INFO] [stderr] | [INFO] [stderr] 255 | fn r(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:263:38 [INFO] [stderr] | [INFO] [stderr] 263 | fn s(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:272:38 [INFO] [stderr] | [INFO] [stderr] 272 | fn t(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:281:38 [INFO] [stderr] | [INFO] [stderr] 281 | fn u(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:289:38 [INFO] [stderr] | [INFO] [stderr] 289 | fn v(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:297:38 [INFO] [stderr] | [INFO] [stderr] 297 | fn w(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:305:38 [INFO] [stderr] | [INFO] [stderr] 305 | fn x(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:313:38 [INFO] [stderr] | [INFO] [stderr] 313 | fn y(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:321:38 [INFO] [stderr] | [INFO] [stderr] 321 | fn z(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:330:42 [INFO] [stderr] | [INFO] [stderr] 330 | fn enter(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:338:47 [INFO] [stderr] | [INFO] [stderr] 338 | fn apostrophe(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:346:46 [INFO] [stderr] | [INFO] [stderr] 346 | fn semicolon(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:354:46 [INFO] [stderr] | [INFO] [stderr] 354 | fn equalsign(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:361:42 [INFO] [stderr] | [INFO] [stderr] 361 | fn minus(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:369:41 [INFO] [stderr] | [INFO] [stderr] 369 | fn num1(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:378:41 [INFO] [stderr] | [INFO] [stderr] 378 | fn num2(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:387:41 [INFO] [stderr] | [INFO] [stderr] 387 | fn num3(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:396:41 [INFO] [stderr] | [INFO] [stderr] 396 | fn num4(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:405:41 [INFO] [stderr] | [INFO] [stderr] 405 | fn num5(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:413:41 [INFO] [stderr] | [INFO] [stderr] 413 | fn num6(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:421:41 [INFO] [stderr] | [INFO] [stderr] 421 | fn num7(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:429:41 [INFO] [stderr] | [INFO] [stderr] 429 | fn num8(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:437:41 [INFO] [stderr] | [INFO] [stderr] 437 | fn num9(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:445:41 [INFO] [stderr] | [INFO] [stderr] 445 | fn num0(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/input/keyboard/mod.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | 0b1000000000000000000000000000000000000000000000000000000000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/input/keyboard/mod.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | const BIT16 : u16 = 0b1000000000000000u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1000_0000_0000_0000u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/input/keyboard/mod.rs:164:10 [INFO] [stderr] | [INFO] [stderr] 164 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 165 | | if (self.exts & (BIT16 >> (key as usize - 64))) != 0 { [INFO] [stderr] 166 | | queue.key(key, Some( [INFO] [stderr] 167 | | (self.exto & (BIT16 >> (key as usize - 64))) [INFO] [stderr] ... | [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 164 | } else if (self.exts & (BIT16 >> (key as usize - 64))) != 0 { [INFO] [stderr] 165 | queue.key(key, Some( [INFO] [stderr] 166 | (self.exto & (BIT16 >> (key as usize - 64))) [INFO] [stderr] 167 | == 0 [INFO] [stderr] 168 | )); [INFO] [stderr] 169 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/input/keyboard/mod.rs:159:11 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 160 | | if (self.keyo & (BIT64 >> key as usize)) != 0 { [INFO] [stderr] 161 | | queue.key(key, None); [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if (self.keyo & (BIT64 >> key as usize)) != 0 { [INFO] [stderr] 160 | queue.key(key, None); [INFO] [stderr] 161 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/input/keyboard/mod.rs:170:11 [INFO] [stderr] | [INFO] [stderr] 170 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 171 | | if (self.exto & (BIT16 >> (key as usize - 64))) [INFO] [stderr] 172 | | != 0 [INFO] [stderr] 173 | | { [INFO] [stderr] 174 | | queue.key(key, None); [INFO] [stderr] 175 | | } [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | } else if (self.exto & (BIT16 >> (key as usize - 64))) [INFO] [stderr] 171 | != 0 [INFO] [stderr] 172 | { [INFO] [stderr] 173 | queue.key(key, None); [INFO] [stderr] 174 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/mod.rs:685:36 [INFO] [stderr] | [INFO] [stderr] 685 | fn input(&mut self, input: Input) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/os/linux/mod.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | let mut value_list = [ 0b01000100000000001101111 ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b010_0010_0000_0000_0110_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/os/linux/mod.rs:250:2 [INFO] [stderr] | [INFO] [stderr] 250 | atom [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/os/linux/mod.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | let atom = unsafe { [INFO] [stderr] | ________________^ [INFO] [stderr] 245 | | extern { fn free(this: *mut XcbInternAtomReply) -> (); } [INFO] [stderr] 246 | | let r_atom = (*reply).atom; [INFO] [stderr] 247 | | free(reply); [INFO] [stderr] 248 | | r_atom [INFO] [stderr] 249 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:25:65 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn update(&mut self, queue: &mut Vec, input: Input) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:108:38 [INFO] [stderr] | [INFO] [stderr] 108 | fn a(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:117:38 [INFO] [stderr] | [INFO] [stderr] 117 | fn b(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:125:38 [INFO] [stderr] | [INFO] [stderr] 125 | fn c(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:133:38 [INFO] [stderr] | [INFO] [stderr] 133 | fn d(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:142:38 [INFO] [stderr] | [INFO] [stderr] 142 | fn e(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:151:38 [INFO] [stderr] | [INFO] [stderr] 151 | fn f(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | fn g(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:168:38 [INFO] [stderr] | [INFO] [stderr] 168 | fn h(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:176:38 [INFO] [stderr] | [INFO] [stderr] 176 | fn i(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:186:38 [INFO] [stderr] | [INFO] [stderr] 186 | fn j(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:195:38 [INFO] [stderr] | [INFO] [stderr] 195 | fn k(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:203:38 [INFO] [stderr] | [INFO] [stderr] 203 | fn l(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:212:38 [INFO] [stderr] | [INFO] [stderr] 212 | fn m(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:221:38 [INFO] [stderr] | [INFO] [stderr] 221 | fn n(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:230:38 [INFO] [stderr] | [INFO] [stderr] 230 | fn o(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:238:38 [INFO] [stderr] | [INFO] [stderr] 238 | fn p(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:246:38 [INFO] [stderr] | [INFO] [stderr] 246 | fn q(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:255:38 [INFO] [stderr] | [INFO] [stderr] 255 | fn r(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:263:38 [INFO] [stderr] | [INFO] [stderr] 263 | fn s(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:272:38 [INFO] [stderr] | [INFO] [stderr] 272 | fn t(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:281:38 [INFO] [stderr] | [INFO] [stderr] 281 | fn u(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:289:38 [INFO] [stderr] | [INFO] [stderr] 289 | fn v(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:297:38 [INFO] [stderr] | [INFO] [stderr] 297 | fn w(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:305:38 [INFO] [stderr] | [INFO] [stderr] 305 | fn x(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:313:38 [INFO] [stderr] | [INFO] [stderr] 313 | fn y(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:321:38 [INFO] [stderr] | [INFO] [stderr] 321 | fn z(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:330:42 [INFO] [stderr] | [INFO] [stderr] 330 | fn enter(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:338:47 [INFO] [stderr] | [INFO] [stderr] 338 | fn apostrophe(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:346:46 [INFO] [stderr] | [INFO] [stderr] 346 | fn semicolon(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:354:46 [INFO] [stderr] | [INFO] [stderr] 354 | fn equalsign(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:361:42 [INFO] [stderr] | [INFO] [stderr] 361 | fn minus(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:369:41 [INFO] [stderr] | [INFO] [stderr] 369 | fn num1(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:378:41 [INFO] [stderr] | [INFO] [stderr] 378 | fn num2(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:387:41 [INFO] [stderr] | [INFO] [stderr] 387 | fn num3(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:396:41 [INFO] [stderr] | [INFO] [stderr] 396 | fn num4(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:405:41 [INFO] [stderr] | [INFO] [stderr] 405 | fn num5(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:413:41 [INFO] [stderr] | [INFO] [stderr] 413 | fn num6(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:421:41 [INFO] [stderr] | [INFO] [stderr] 421 | fn num7(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:429:41 [INFO] [stderr] | [INFO] [stderr] 429 | fn num8(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:437:41 [INFO] [stderr] | [INFO] [stderr] 437 | fn num9(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/keyboard/modifiers.rs:445:41 [INFO] [stderr] | [INFO] [stderr] 445 | fn num0(&self, queue: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/input/keyboard/mod.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | 0b1000000000000000000000000000000000000000000000000000000000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/input/keyboard/mod.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | const BIT16 : u16 = 0b1000000000000000u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1000_0000_0000_0000u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/input/keyboard/mod.rs:164:10 [INFO] [stderr] | [INFO] [stderr] 164 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 165 | | if (self.exts & (BIT16 >> (key as usize - 64))) != 0 { [INFO] [stderr] 166 | | queue.key(key, Some( [INFO] [stderr] 167 | | (self.exto & (BIT16 >> (key as usize - 64))) [INFO] [stderr] ... | [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 164 | } else if (self.exts & (BIT16 >> (key as usize - 64))) != 0 { [INFO] [stderr] 165 | queue.key(key, Some( [INFO] [stderr] 166 | (self.exto & (BIT16 >> (key as usize - 64))) [INFO] [stderr] 167 | == 0 [INFO] [stderr] 168 | )); [INFO] [stderr] 169 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/input/keyboard/mod.rs:159:11 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 160 | | if (self.keyo & (BIT64 >> key as usize)) != 0 { [INFO] [stderr] 161 | | queue.key(key, None); [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if (self.keyo & (BIT64 >> key as usize)) != 0 { [INFO] [stderr] 160 | queue.key(key, None); [INFO] [stderr] 161 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/input/keyboard/mod.rs:170:11 [INFO] [stderr] | [INFO] [stderr] 170 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 171 | | if (self.exto & (BIT16 >> (key as usize - 64))) [INFO] [stderr] 172 | | != 0 [INFO] [stderr] 173 | | { [INFO] [stderr] 174 | | queue.key(key, None); [INFO] [stderr] 175 | | } [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | } else if (self.exto & (BIT16 >> (key as usize - 64))) [INFO] [stderr] 171 | != 0 [INFO] [stderr] 172 | { [INFO] [stderr] 173 | queue.key(key, None); [INFO] [stderr] 174 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/input/mod.rs:685:36 [INFO] [stderr] | [INFO] [stderr] 685 | fn input(&mut self, input: Input) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/os/linux/mod.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | let mut value_list = [ 0b01000100000000001101111 ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b010_0010_0000_0000_0110_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/os/linux/mod.rs:250:2 [INFO] [stderr] | [INFO] [stderr] 250 | atom [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/os/linux/mod.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | let atom = unsafe { [INFO] [stderr] | ________________^ [INFO] [stderr] 245 | | extern { fn free(this: *mut XcbInternAtomReply) -> (); } [INFO] [stderr] 246 | | let r_atom = (*reply).atom; [INFO] [stderr] 247 | | free(reply); [INFO] [stderr] 248 | | r_atom [INFO] [stderr] 249 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/input/keyboard/modifiers.rs:25:2 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn update(&mut self, queue: &mut Vec, input: Input) -> () { [INFO] [stderr] | _____^ [INFO] [stderr] 26 | | match input { [INFO] [stderr] 27 | | Input::Text(_) => match self.held { [INFO] [stderr] 28 | | NONE | SHIFT => {}, [INFO] [stderr] ... | [INFO] [stderr] 105 | | queue.push(input) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::keyboard::Keyboard` [INFO] [stderr] --> src/input/keyboard/mod.rs:95:2 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn new() -> Keyboard { [INFO] [stderr] | _____^ [INFO] [stderr] 96 | | Keyboard { keys: 0u64, exts: 0u16, keyo: 0u64, exto: 0u16 } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/input/mod.rs:428:27 [INFO] [stderr] | [INFO] [stderr] 428 | fn to_f32(self) -> f32 { self as f32 } [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/input/mod.rs:432:27 [INFO] [stderr] | [INFO] [stderr] 432 | fn to_f32(self) -> f32 { self as f32 } [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `input::InputQueue` [INFO] [stderr] --> src/input/mod.rs:459:2 [INFO] [stderr] | [INFO] [stderr] 459 | pub fn new() -> InputQueue { [INFO] [stderr] | _____^ [INFO] [stderr] 460 | | let queue = Vec::new(); [INFO] [stderr] 461 | | let mods = keyboard::modifiers::Modifiers::create(); [INFO] [stderr] 462 | | [INFO] [stderr] 463 | | InputQueue { queue, mods } [INFO] [stderr] 464 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 456 | impl Default for input::InputQueue { [INFO] [stderr] 457 | fn default() -> Self { [INFO] [stderr] 458 | Self::new() [INFO] [stderr] 459 | } [INFO] [stderr] 460 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/os/linux/mod.rs:384:37 [INFO] [stderr] | [INFO] [stderr] 384 | (xkb.xkb_state_update_key)(state, keycode as u32, if dn { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(keycode)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/os/linux/mod.rs:396:39 [INFO] [stderr] | [INFO] [stderr] 396 | (xkb.xkb_state_key_get_utf8)(state, key as u32, [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/os/linux/mod.rs:406:39 [INFO] [stderr] | [INFO] [stderr] 406 | (xkb.xkb_state_key_get_utf8)(state, key as u32, buffer, size); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/input/keyboard/modifiers.rs:25:2 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn update(&mut self, queue: &mut Vec, input: Input) -> () { [INFO] [stderr] | _____^ [INFO] [stderr] 26 | | match input { [INFO] [stderr] 27 | | Input::Text(_) => match self.held { [INFO] [stderr] 28 | | NONE | SHIFT => {}, [INFO] [stderr] ... | [INFO] [stderr] 105 | | queue.push(input) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::keyboard::Keyboard` [INFO] [stderr] --> src/input/keyboard/mod.rs:95:2 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn new() -> Keyboard { [INFO] [stderr] | _____^ [INFO] [stderr] 96 | | Keyboard { keys: 0u64, exts: 0u16, keyo: 0u64, exto: 0u16 } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/input/mod.rs:428:27 [INFO] [stderr] | [INFO] [stderr] 428 | fn to_f32(self) -> f32 { self as f32 } [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/input/mod.rs:432:27 [INFO] [stderr] | [INFO] [stderr] 432 | fn to_f32(self) -> f32 { self as f32 } [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `input::InputQueue` [INFO] [stderr] --> src/input/mod.rs:459:2 [INFO] [stderr] | [INFO] [stderr] 459 | pub fn new() -> InputQueue { [INFO] [stderr] | _____^ [INFO] [stderr] 460 | | let queue = Vec::new(); [INFO] [stderr] 461 | | let mods = keyboard::modifiers::Modifiers::create(); [INFO] [stderr] 462 | | [INFO] [stderr] 463 | | InputQueue { queue, mods } [INFO] [stderr] 464 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 456 | impl Default for input::InputQueue { [INFO] [stderr] 457 | fn default() -> Self { [INFO] [stderr] 458 | Self::new() [INFO] [stderr] 459 | } [INFO] [stderr] 460 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/os/linux/mod.rs:384:37 [INFO] [stderr] | [INFO] [stderr] 384 | (xkb.xkb_state_update_key)(state, keycode as u32, if dn { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(keycode)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/os/linux/mod.rs:396:39 [INFO] [stderr] | [INFO] [stderr] 396 | (xkb.xkb_state_key_get_utf8)(state, key as u32, [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/os/linux/mod.rs:406:39 [INFO] [stderr] | [INFO] [stderr] 406 | (xkb.xkb_state_key_get_utf8)(state, key as u32, buffer, size); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.41s [INFO] running `"docker" "inspect" "ac320976c295415af6c7cc96ba1a2aa584110fcb861b92c2b0aa25208a8e40ed"` [INFO] running `"docker" "rm" "-f" "ac320976c295415af6c7cc96ba1a2aa584110fcb861b92c2b0aa25208a8e40ed"` [INFO] [stdout] ac320976c295415af6c7cc96ba1a2aa584110fcb861b92c2b0aa25208a8e40ed