[INFO] crate avro 0.2.1 is already in cache [INFO] extracting crate avro 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/avro/0.2.1 [INFO] extracting crate avro 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/avro/0.2.1 [INFO] validating manifest of avro-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of avro-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing avro-0.2.1 [INFO] finished frobbing avro-0.2.1 [INFO] frobbed toml for avro-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/avro/0.2.1/Cargo.toml [INFO] started frobbing avro-0.2.1 [INFO] finished frobbing avro-0.2.1 [INFO] frobbed toml for avro-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/avro/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting avro-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/avro/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5486b59672e48bf03c71c6e179c1e98fcc95fedbf44fb1c9b772fe9b64f359c [INFO] running `"docker" "start" "-a" "f5486b59672e48bf03c71c6e179c1e98fcc95fedbf44fb1c9b772fe9b64f359c"` [INFO] [stderr] Checking avro v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | src: src, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:396:13 [INFO] [stderr] | [INFO] [stderr] 396 | source_manager: source_manager, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_manager` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | ty: ty, range: (start..this.index).into() [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:683:13 [INFO] [stderr] | [INFO] [stderr] 683 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:684:13 [INFO] [stderr] | [INFO] [stderr] 684 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:685:13 [INFO] [stderr] | [INFO] [stderr] 685 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:696:21 [INFO] [stderr] | [INFO] [stderr] 696 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:848:32 [INFO] [stderr] | [INFO] [stderr] 848 | Ok(Schema::Union { tys: tys }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:895:9 [INFO] [stderr] | [INFO] [stderr] 895 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:896:9 [INFO] [stderr] | [INFO] [stderr] 896 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:897:9 [INFO] [stderr] | [INFO] [stderr] 897 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:984:74 [INFO] [stderr] | [INFO] [stderr] 984 | symbols.push(EnumSymbol { name: Cow::Borrowed(sym_name), doc: doc }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:995:9 [INFO] [stderr] | [INFO] [stderr] 995 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:996:9 [INFO] [stderr] | [INFO] [stderr] 996 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:997:9 [INFO] [stderr] | [INFO] [stderr] 997 | symbols: symbols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `symbols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1017:9 [INFO] [stderr] | [INFO] [stderr] 1017 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1018:9 [INFO] [stderr] | [INFO] [stderr] 1018 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1019:9 [INFO] [stderr] | [INFO] [stderr] 1019 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1142:9 [INFO] [stderr] | [INFO] [stderr] 1142 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1143:9 [INFO] [stderr] | [INFO] [stderr] 1143 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1144:9 [INFO] [stderr] | [INFO] [stderr] 1144 | tys: tys, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | src: src, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:396:13 [INFO] [stderr] | [INFO] [stderr] 396 | source_manager: source_manager, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_manager` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | ty: ty, range: (start..this.index).into() [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:683:13 [INFO] [stderr] | [INFO] [stderr] 683 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:684:13 [INFO] [stderr] | [INFO] [stderr] 684 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:685:13 [INFO] [stderr] | [INFO] [stderr] 685 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:696:21 [INFO] [stderr] | [INFO] [stderr] 696 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:848:32 [INFO] [stderr] | [INFO] [stderr] 848 | Ok(Schema::Union { tys: tys }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:895:9 [INFO] [stderr] | [INFO] [stderr] 895 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:896:9 [INFO] [stderr] | [INFO] [stderr] 896 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:897:9 [INFO] [stderr] | [INFO] [stderr] 897 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:984:74 [INFO] [stderr] | [INFO] [stderr] 984 | symbols.push(EnumSymbol { name: Cow::Borrowed(sym_name), doc: doc }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:995:9 [INFO] [stderr] | [INFO] [stderr] 995 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:996:9 [INFO] [stderr] | [INFO] [stderr] 996 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:997:9 [INFO] [stderr] | [INFO] [stderr] 997 | symbols: symbols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `symbols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1017:9 [INFO] [stderr] | [INFO] [stderr] 1017 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1018:9 [INFO] [stderr] | [INFO] [stderr] 1018 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1019:9 [INFO] [stderr] | [INFO] [stderr] 1019 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1142:9 [INFO] [stderr] | [INFO] [stderr] 1142 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1143:9 [INFO] [stderr] | [INFO] [stderr] 1143 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idl.rs:1144:9 [INFO] [stderr] | [INFO] [stderr] 1144 | tys: tys, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/idl.rs:228:27 [INFO] [stderr] | [INFO] [stderr] 228 | ).unwrap_or(trimmed_line.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| trimmed_line.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | num |= (buf[0] as u64 & 0b0111_1111) << (i * 7); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/decode.rs:79:31 [INFO] [stderr] | [INFO] [stderr] 79 | assert_eq!(decode_zig_zag(0xFFFFFFFF_FFFFFFFF), i64::min_value()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_digit_groups)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/decode.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | assert_eq!(decode_zig_zag(0xFFFFFFFF_FFFFFFFE), i64::max_value()); // 0x7FFF...FF [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decode.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match schema { [INFO] [stderr] 86 | | &Schema::Null => Ok(Value::Null), [INFO] [stderr] 87 | | &Schema::Boolean => { [INFO] [stderr] 88 | | let mut buf = [0u8; 1]; [INFO] [stderr] ... | [INFO] [stderr] 166 | | _ => unimplemented!(), [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *schema { [INFO] [stderr] 86 | Schema::Null => Ok(Value::Null), [INFO] [stderr] 87 | Schema::Boolean => { [INFO] [stderr] 88 | let mut buf = [0u8; 1]; [INFO] [stderr] 89 | try!(reader.read_exact(&mut buf[..])); [INFO] [stderr] 90 | match buf[0] { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | if num < (i32::min_value() as i64) || num > (i32::max_value() as i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:98:57 [INFO] [stderr] | [INFO] [stderr] 98 | if num < (i32::min_value() as i64) || num > (i32::max_value() as i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/encode.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | try!(writer.write(&[b])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/encode.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | try!(writer.write(&[b])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | encode_var_len_u64(&mut vec, 944261).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `944_261` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encode.rs:79:50 [INFO] [stderr] | [INFO] [stderr] 79 | assert_eq!(encode_zig_zag(i64::min_value()), 0xFFFFFFFF_FFFFFFFF); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/encode.rs:80:50 [INFO] [stderr] | [INFO] [stderr] 80 | assert_eq!(encode_zig_zag(i64::max_value()), 0xFFFFFFFF_FFFFFFFE); // 0x7FFF...FF [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 65 | value_unwrap_fn!(unwrap_boolean, bool, Boolean, &Value::Boolean(val) => val); [INFO] [stderr] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 66 | value_unwrap_fn!(unwrap_int, i32, Int, &Value::Int(val) => val); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 67 | value_unwrap_fn!(unwrap_long, i64, Long, &Value::Long(val) => val); [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 68 | value_unwrap_fn!(unwrap_float, f32, Float, &Value::Float(val) => val); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 69 | value_unwrap_fn!(unwrap_double, f64, Double, &Value::Double(val) => val); [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 70 | value_unwrap_fn!(unwrap_bytes, &Cow<'b, [u8]>, Bytes, &Value::Bytes(ref val) => val); [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 71 | value_unwrap_fn!(unwrap_string, &Cow<'b, str>, String, &Value::String(ref val) => val); [INFO] [stderr] | --------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 72 | / value_unwrap_fn!(unwrap_record, (&Rc>, &Vec>), [INFO] [stderr] 73 | | Record, &Value::Record(ref sch, ref val) => (sch, val)); [INFO] [stderr] | |________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 74 | / value_unwrap_fn!(unwrap_enum, (&Rc>, i32), [INFO] [stderr] 75 | | Enum, &Value::Enum(ref sch, val) => (sch, val)); [INFO] [stderr] | |________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 76 | value_unwrap_fn!(unwrap_array, &Vec>, Array, &Value::Array(ref val) => val); [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 77 | / value_unwrap_fn!(unwrap_map, &HashMap, Value<'a, 'b>>, [INFO] [stderr] 78 | | Map, &Value::Map(ref val) => val); [INFO] [stderr] | |__________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 79 | / value_unwrap_fn!(unwrap_fixed, (&Rc>, &Cow<'b, [u8]>), [INFO] [stderr] 80 | | Fixed, &Value::Fixed(ref sch, ref val) => (sch, val)); [INFO] [stderr] | |______________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:126:37 [INFO] [stderr] | [INFO] [stderr] 126 | fn create_field_indexes<'a>(fields: &Vec>) -> HashMap, usize> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Field<'a>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `avro`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/idl.rs:228:27 [INFO] [stderr] | [INFO] [stderr] 228 | ).unwrap_or(trimmed_line.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| trimmed_line.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/idl.rs:1178:1 [INFO] [stderr] | [INFO] [stderr] 1178 | / fn test_parse_record() { [INFO] [stderr] 1179 | | let res = parse_idl(r#" [INFO] [stderr] 1180 | | /** Comment one. */ [INFO] [stderr] 1181 | | protocol Test1 { [INFO] [stderr] ... | [INFO] [stderr] 1250 | | } [INFO] [stderr] 1251 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/idl.rs:1202:5 [INFO] [stderr] | [INFO] [stderr] 1202 | / if let &Schema::Record(ref r) = first { [INFO] [stderr] 1203 | | assert_eq!(r.name, Cow::Borrowed("First")); [INFO] [stderr] 1204 | | assert_eq!(r.doc, None); [INFO] [stderr] 1205 | | assert_eq!(r.fields[0].name, Cow::Borrowed("i")); [INFO] [stderr] ... | [INFO] [stderr] 1212 | | panic!("wrong type"); [INFO] [stderr] 1213 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1202 | if let Schema::Record(ref r) = *first { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/idl.rs:1216:5 [INFO] [stderr] | [INFO] [stderr] 1216 | / if let &Schema::Record(ref r) = second { [INFO] [stderr] 1217 | | assert_eq!(r.name, Cow::Borrowed("Second")); [INFO] [stderr] 1218 | | assert_eq!(r.doc, Some(Cow::Borrowed("Comment two."))); [INFO] [stderr] 1219 | | assert_eq!(r.fields[0].name, Cow::Borrowed("nums")); [INFO] [stderr] ... | [INFO] [stderr] 1227 | | panic!("wrong type"); [INFO] [stderr] 1228 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1216 | if let Schema::Record(ref r) = *second { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/idl.rs:1231:5 [INFO] [stderr] | [INFO] [stderr] 1231 | / if let &Schema::Error(ref r) = third { [INFO] [stderr] 1232 | | assert_eq!(r.name, Cow::Borrowed("Third")); [INFO] [stderr] 1233 | | assert_eq!(r.doc, None); [INFO] [stderr] 1234 | | assert_eq!(r.fields[0].name, Cow::Borrowed("enabledFeatures")); [INFO] [stderr] ... | [INFO] [stderr] 1249 | | panic!("wrong type"); [INFO] [stderr] 1250 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1231 | if let Schema::Error(ref r) = *third { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/idl.rs:1277:5 [INFO] [stderr] | [INFO] [stderr] 1277 | / if let &Schema::Enum(ref e) = first { [INFO] [stderr] 1278 | | assert_eq!(e.name, Cow::Borrowed("TimePeriods")); [INFO] [stderr] 1279 | | assert_eq!(e.doc, Some(Cow::Borrowed("Only two values"))); [INFO] [stderr] 1280 | | assert_eq!(&e.symbols, &[ [INFO] [stderr] ... | [INFO] [stderr] 1285 | | panic!("wrong type"); [INFO] [stderr] 1286 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1277 | if let Schema::Enum(ref e) = *first { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/idl.rs:1289:5 [INFO] [stderr] | [INFO] [stderr] 1289 | / if let &Schema::Enum(ref e) = second { [INFO] [stderr] 1290 | | assert_eq!(e.name, Cow::Borrowed("Seasons")); [INFO] [stderr] 1291 | | assert_eq!(e.doc, None); [INFO] [stderr] 1292 | | assert_eq!(&e.symbols, &[ [INFO] [stderr] ... | [INFO] [stderr] 1302 | | panic!("wrong type"); [INFO] [stderr] 1303 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1289 | if let Schema::Enum(ref e) = *second { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/idl.rs:1321:5 [INFO] [stderr] | [INFO] [stderr] 1321 | / if let &Schema::Fixed(ref f) = first { [INFO] [stderr] 1322 | | assert_eq!(f.name, Cow::Borrowed("Guid")); [INFO] [stderr] 1323 | | assert_eq!(f.doc, Some(Cow::Borrowed("An identifier"))); [INFO] [stderr] 1324 | | assert_eq!(f.size, 16); [INFO] [stderr] 1325 | | } else { [INFO] [stderr] 1326 | | panic!("wrong type"); [INFO] [stderr] 1327 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1321 | if let Schema::Fixed(ref f) = *first { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/idl.rs:1330:5 [INFO] [stderr] | [INFO] [stderr] 1330 | / if let &Schema::Fixed(ref f) = second { [INFO] [stderr] 1331 | | assert_eq!(f.name, Cow::Borrowed("IPv4")); [INFO] [stderr] 1332 | | assert_eq!(f.doc, None); [INFO] [stderr] 1333 | | assert_eq!(f.size, 4); [INFO] [stderr] 1334 | | } else { [INFO] [stderr] 1335 | | panic!("wrong type"); [INFO] [stderr] 1336 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1330 | if let Schema::Fixed(ref f) = *second { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/idl.rs:1360:1 [INFO] [stderr] | [INFO] [stderr] 1360 | / fn test_parse_record_properties() { [INFO] [stderr] 1361 | | let res = parse_idl(r#" [INFO] [stderr] 1362 | | protocol TestProp { [INFO] [stderr] 1363 | | /** An important record */ [INFO] [stderr] ... | [INFO] [stderr] 1427 | | } [INFO] [stderr] 1428 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/idl.rs:1389:5 [INFO] [stderr] | [INFO] [stderr] 1389 | / if let &Schema::Record(ref r) = first { [INFO] [stderr] 1390 | | assert_eq!(r.doc, Some(Cow::Borrowed("An important record"))); [INFO] [stderr] 1391 | | assert_eq!(r.properties.len(), 5); [INFO] [stderr] 1392 | | assert_eq!(r.properties[0].name, "naming"); [INFO] [stderr] ... | [INFO] [stderr] 1426 | | panic!("wrong type"); [INFO] [stderr] 1427 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1389 | if let Schema::Record(ref r) = *first { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/idl.rs:1406:37 [INFO] [stderr] | [INFO] [stderr] 1406 | serde_json::Value::F64(-3.14), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/idl.rs:1444:5 [INFO] [stderr] | [INFO] [stderr] 1444 | / if let &Schema::Fixed(ref ty_guid) = &protocol.tys[0] { [INFO] [stderr] 1445 | | assert_eq!(ty_guid.doc, Some(Cow::Borrowed("A named data type"))); [INFO] [stderr] 1446 | | assert_eq!(ty_guid.properties.len(), 2); [INFO] [stderr] 1447 | | assert_eq!(ty_guid.properties[0].name, "foo"); [INFO] [stderr] ... | [INFO] [stderr] 1452 | | panic!("wrong type"); [INFO] [stderr] 1453 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1444 | if let Schema::Fixed(ref ty_guid) = protocol.tys[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/idl.rs:1455:5 [INFO] [stderr] | [INFO] [stderr] 1455 | / if let &Schema::Fixed(ref ty_hash) = &protocol.tys[1] { [INFO] [stderr] 1456 | | assert_eq!(ty_hash.doc, None); [INFO] [stderr] 1457 | | assert_eq!(ty_hash.properties.len(), 0); [INFO] [stderr] 1458 | | } else { [INFO] [stderr] 1459 | | panic!("wrong type"); [INFO] [stderr] 1460 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1455 | if let Schema::Fixed(ref ty_hash) = protocol.tys[1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/idl.rs:1482:5 [INFO] [stderr] | [INFO] [stderr] 1482 | / if let &Schema::Enum(ref ty_time) = &protocol.tys[0] { [INFO] [stderr] 1483 | | assert_eq!(ty_time.doc, Some(Cow::Borrowed("Only two values"))); [INFO] [stderr] 1484 | | assert_eq!(ty_time.properties.len(), 2); [INFO] [stderr] 1485 | | assert_eq!(ty_time.properties[0].name, "foo"); [INFO] [stderr] ... | [INFO] [stderr] 1490 | | panic!("wrong type"); [INFO] [stderr] 1491 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1482 | if let Schema::Enum(ref ty_time) = protocol.tys[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/idl.rs:1493:5 [INFO] [stderr] | [INFO] [stderr] 1493 | / if let &Schema::Enum(ref ty_fruit) = &protocol.tys[1] { [INFO] [stderr] 1494 | | assert_eq!(ty_fruit.doc, None); [INFO] [stderr] 1495 | | assert_eq!(ty_fruit.properties.len(), 0); [INFO] [stderr] 1496 | | } else { [INFO] [stderr] 1497 | | panic!("wrong type"); [INFO] [stderr] 1498 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1493 | if let Schema::Enum(ref ty_fruit) = protocol.tys[1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | num |= (buf[0] as u64 & 0b0111_1111) << (i * 7); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decode.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match schema { [INFO] [stderr] 86 | | &Schema::Null => Ok(Value::Null), [INFO] [stderr] 87 | | &Schema::Boolean => { [INFO] [stderr] 88 | | let mut buf = [0u8; 1]; [INFO] [stderr] ... | [INFO] [stderr] 166 | | _ => unimplemented!(), [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *schema { [INFO] [stderr] 86 | Schema::Null => Ok(Value::Null), [INFO] [stderr] 87 | Schema::Boolean => { [INFO] [stderr] 88 | let mut buf = [0u8; 1]; [INFO] [stderr] 89 | try!(reader.read_exact(&mut buf[..])); [INFO] [stderr] 90 | match buf[0] { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | if num < (i32::min_value() as i64) || num > (i32::max_value() as i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:98:57 [INFO] [stderr] | [INFO] [stderr] 98 | if num < (i32::min_value() as i64) || num > (i32::max_value() as i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/decode.rs:206:93 [INFO] [stderr] | [INFO] [stderr] 206 | assert_eq!(decode(&mut &b"\xC3\xF5\x48\x40"[..], &Schema::Float).unwrap(), Value::Float(3.14)); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::E` found. Consider using it directly [INFO] [stderr] --> src/decode.rs:208:23 [INFO] [stderr] | [INFO] [stderr] 208 | Value::Double(2.718)); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/decode.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | Err(_) => panic!("wrong error kind"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/decode.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | Err(_) => panic!("wrong error kind"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/encode.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | try!(writer.write(&[b])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/encode.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | try!(writer.write(&[b])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 65 | value_unwrap_fn!(unwrap_boolean, bool, Boolean, &Value::Boolean(val) => val); [INFO] [stderr] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 66 | value_unwrap_fn!(unwrap_int, i32, Int, &Value::Int(val) => val); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 67 | value_unwrap_fn!(unwrap_long, i64, Long, &Value::Long(val) => val); [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 68 | value_unwrap_fn!(unwrap_float, f32, Float, &Value::Float(val) => val); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 69 | value_unwrap_fn!(unwrap_double, f64, Double, &Value::Double(val) => val); [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 70 | value_unwrap_fn!(unwrap_bytes, &Cow<'b, [u8]>, Bytes, &Value::Bytes(ref val) => val); [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 71 | value_unwrap_fn!(unwrap_string, &Cow<'b, str>, String, &Value::String(ref val) => val); [INFO] [stderr] | --------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 72 | / value_unwrap_fn!(unwrap_record, (&Rc>, &Vec>), [INFO] [stderr] 73 | | Record, &Value::Record(ref sch, ref val) => (sch, val)); [INFO] [stderr] | |________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 74 | / value_unwrap_fn!(unwrap_enum, (&Rc>, i32), [INFO] [stderr] 75 | | Enum, &Value::Enum(ref sch, val) => (sch, val)); [INFO] [stderr] | |________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 76 | value_unwrap_fn!(unwrap_array, &Vec>, Array, &Value::Array(ref val) => val); [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 77 | / value_unwrap_fn!(unwrap_map, &HashMap, Value<'a, 'b>>, [INFO] [stderr] 78 | | Map, &Value::Map(ref val) => val); [INFO] [stderr] | |__________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | $val_pat => $ret, [INFO] [stderr] 57 | | _ => panic!(concat!( [INFO] [stderr] 58 | | "called `Value::", stringify!($n), "()` on a non-`", stringify!($variant), "` value: {:?}"), self), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 79 | / value_unwrap_fn!(unwrap_fixed, (&Rc>, &Cow<'b, [u8]>), [INFO] [stderr] 80 | | Fixed, &Value::Fixed(ref sch, ref val) => (sch, val)); [INFO] [stderr] | |______________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/lib.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(Value::Float(3.14).unwrap_float(), 3.14); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/lib.rs:88:51 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(Value::Float(3.14).unwrap_float(), 3.14); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(Value::Float(3.14).unwrap_float(), 3.14); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(Value::Float(3.14).unwrap_float(), 3.14); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/lib.rs:89:30 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(Value::Double(3.14).unwrap_double(), 3.14); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/lib.rs:89:53 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(Value::Double(3.14).unwrap_double(), 3.14); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(Value::Double(3.14).unwrap_double(), 3.14); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(Value::Double(3.14).unwrap_double(), 3.14); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:126:37 [INFO] [stderr] | [INFO] [stderr] 126 | fn create_field_indexes<'a>(fields: &Vec>) -> HashMap, usize> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Field<'a>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `avro`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f5486b59672e48bf03c71c6e179c1e98fcc95fedbf44fb1c9b772fe9b64f359c"` [INFO] running `"docker" "rm" "-f" "f5486b59672e48bf03c71c6e179c1e98fcc95fedbf44fb1c9b772fe9b64f359c"` [INFO] [stdout] f5486b59672e48bf03c71c6e179c1e98fcc95fedbf44fb1c9b772fe9b64f359c