[INFO] crate aventurine 0.1.0 is already in cache [INFO] extracting crate aventurine 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/aventurine/0.1.0 [INFO] extracting crate aventurine 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aventurine/0.1.0 [INFO] validating manifest of aventurine-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aventurine-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aventurine-0.1.0 [INFO] finished frobbing aventurine-0.1.0 [INFO] frobbed toml for aventurine-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/aventurine/0.1.0/Cargo.toml [INFO] started frobbing aventurine-0.1.0 [INFO] finished frobbing aventurine-0.1.0 [INFO] frobbed toml for aventurine-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aventurine/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aventurine-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/aventurine/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 64ca7ef4e98f38a6d364598f55bb7b8b0ad61e05aa7c5313111d02dc4b71d2a7 [INFO] running `"docker" "start" "-a" "64ca7ef4e98f38a6d364598f55bb7b8b0ad61e05aa7c5313111d02dc4b71d2a7"` [INFO] [stderr] Checking topaz v0.2.0 [INFO] [stderr] Compiling glium v0.18.1 [INFO] [stderr] Checking aventurine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:89:32 [INFO] [stderr] | [INFO] [stderr] 89 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 90 | | if let Some(index) = self.on_unfocus {universe.do_event(E::with_window_event(index,event))} [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________________________^ help: try: `if let Some(index) = self.on_unfocus {universe.do_event(E::with_window_event(index,event))}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:89:32 [INFO] [stderr] | [INFO] [stderr] 89 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 90 | | if let Some(index) = self.on_unfocus {universe.do_event(E::with_window_event(index,event))} [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________________________^ help: try: `if let Some(index) = self.on_unfocus {universe.do_event(E::with_window_event(index,event))}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / match event { [INFO] [stderr] 83 | | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 84 | | WindowEvent::Closed => if let Some(index) = self.on_close {universe.do_event(E::with_window_event(index,event))}, [INFO] [stderr] 85 | | WindowEvent::Resized(_,_) => if let Some(index) = self.on_resize { universe.do_event(E::with_window_event(index,event))}, [INFO] [stderr] ... | [INFO] [stderr] 99 | | _ => (), [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | if let glium::glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 83 | WindowEvent::Closed => if let Some(index) = self.on_close {universe.do_event(E::with_window_event(index,event))}, [INFO] [stderr] 84 | WindowEvent::Resized(_,_) => if let Some(index) = self.on_resize { universe.do_event(E::with_window_event(index,event))}, [INFO] [stderr] 85 | WindowEvent::Focused(has_focus) => { [INFO] [stderr] 86 | if has_focus { [INFO] [stderr] 87 | if let Some(index) = self.on_focus {universe.do_event(E::with_window_event(index,event))} [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / match event { [INFO] [stderr] 83 | | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 84 | | WindowEvent::Closed => if let Some(index) = self.on_close {universe.do_event(E::with_window_event(index,event))}, [INFO] [stderr] 85 | | WindowEvent::Resized(_,_) => if let Some(index) = self.on_resize { universe.do_event(E::with_window_event(index,event))}, [INFO] [stderr] ... | [INFO] [stderr] 99 | | _ => (), [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | if let glium::glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 83 | WindowEvent::Closed => if let Some(index) = self.on_close {universe.do_event(E::with_window_event(index,event))}, [INFO] [stderr] 84 | WindowEvent::Resized(_,_) => if let Some(index) = self.on_resize { universe.do_event(E::with_window_event(index,event))}, [INFO] [stderr] 85 | WindowEvent::Focused(has_focus) => { [INFO] [stderr] 86 | if has_focus { [INFO] [stderr] 87 | if let Some(index) = self.on_focus {universe.do_event(E::with_window_event(index,event))} [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/empty-window.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | id: id [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/empty-window.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | id: id [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/empty-window.rs:55:46 [INFO] [stderr] | [INFO] [stderr] 55 | let display_system = BlankWindowSystem { display: display }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.74s [INFO] running `"docker" "inspect" "64ca7ef4e98f38a6d364598f55bb7b8b0ad61e05aa7c5313111d02dc4b71d2a7"` [INFO] running `"docker" "rm" "-f" "64ca7ef4e98f38a6d364598f55bb7b8b0ad61e05aa7c5313111d02dc4b71d2a7"` [INFO] [stdout] 64ca7ef4e98f38a6d364598f55bb7b8b0ad61e05aa7c5313111d02dc4b71d2a7