[INFO] crate av-stream-info-rust 0.4.0 is already in cache [INFO] extracting crate av-stream-info-rust 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/av-stream-info-rust/0.4.0 [INFO] extracting crate av-stream-info-rust 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/av-stream-info-rust/0.4.0 [INFO] validating manifest of av-stream-info-rust-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of av-stream-info-rust-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing av-stream-info-rust-0.4.0 [INFO] finished frobbing av-stream-info-rust-0.4.0 [INFO] frobbed toml for av-stream-info-rust-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/av-stream-info-rust/0.4.0/Cargo.toml [INFO] started frobbing av-stream-info-rust-0.4.0 [INFO] finished frobbing av-stream-info-rust-0.4.0 [INFO] frobbed toml for av-stream-info-rust-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/av-stream-info-rust/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting av-stream-info-rust-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/av-stream-info-rust/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6c201b4267a3b18088e6de6df4fa1a9d24838b198358edd93879118f307388f [INFO] running `"docker" "start" "-a" "a6c201b4267a3b18088e6de6df4fa1a9d24838b198358edd93879118f307388f"` [INFO] [stderr] Compiling trackable_derive v0.1.2 [INFO] [stderr] Checking playlist-decoder v0.7.0 [INFO] [stderr] Checking trackable v0.2.21 [INFO] [stderr] Checking hls_m3u8 v0.1.3 [INFO] [stderr] Checking av-stream-info-rust v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return Err(Box::new(RequestError::new("connection was not possible"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::new(RequestError::new("connection was not possible")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | return Err(Box::new(RequestError::new("HTTP header missing"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::new(RequestError::new("HTTP header missing")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / return content_type == "application/mpegurl" || content_type == "application/x-mpegurl" [INFO] [stderr] 57 | | || content_type == "audio/mpegurl" || content_type == "audio/x-mpegurl" [INFO] [stderr] 58 | | || content_type == "application/vnd.apple.mpegurl" [INFO] [stderr] 59 | | || content_type == "application/vnd.apple.mpegurl.audio"; [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | content_type == "application/mpegurl" || content_type == "application/x-mpegurl" [INFO] [stderr] 57 | || content_type == "audio/mpegurl" || content_type == "audio/x-mpegurl" [INFO] [stderr] 58 | || content_type == "application/vnd.apple.mpegurl" [INFO] [stderr] 59 | || content_type == "application/vnd.apple.mpegurl.audio" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / return content_type == "audio/x-scpls" || content_type == "application/x-scpls" [INFO] [stderr] 64 | | || content_type == "application/pls+xml"; [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | content_type == "audio/x-scpls" || content_type == "application/x-scpls" [INFO] [stderr] 64 | || content_type == "application/pls+xml" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return content_type == "video/x-ms-asx" || content_type == "video/x-ms-asf"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `content_type == "video/x-ms-asx" || content_type == "video/x-ms-asf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return content_type == "application/xspf+xml"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `content_type == "application/xspf+xml"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / return type_is_m3u(content_type) || type_is_pls(content_type) || type_is_asx(content_type) [INFO] [stderr] 85 | | || type_is_xspf(content_type); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | type_is_m3u(content_type) || type_is_pls(content_type) || type_is_asx(content_type) [INFO] [stderr] 85 | || type_is_xspf(content_type) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:366:5 [INFO] [stderr] | [INFO] [stderr] 366 | return (codec_audio,codec_video); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(codec_audio,codec_video)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/request.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | Duration::from_secs(timeout as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(timeout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/request.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | .ok_or(RequestError::new("illegal host name"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RequestError::new("illegal host name"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/request.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | .ok_or(RequestError::new("port unknown"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RequestError::new("port unknown"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/request.rs:83:58 [INFO] [stderr] | [INFO] [stderr] 83 | stream.set_read_timeout(Some(Duration::from_secs(timeout as u64)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(timeout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/request.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / let mut host_str = String::from(host); [INFO] [stderr] 89 | | if port != 443{ [INFO] [stderr] 90 | | host_str = format!("{}:{}",host,port); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let host_str = if port != 443 { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { String::from(host) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/request.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / let mut host_str = String::from(host); [INFO] [stderr] 108 | | if port != 80{ [INFO] [stderr] 109 | | host_str = format!("{}:{}",host,port); [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let host_str = if port != 80 { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { String::from(host) };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/request.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / pub fn get_content<'a>(&'a self) -> &'a str { [INFO] [stderr] 182 | | &self.content [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/request.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | stream.write(request_str.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/request.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | / match line.find(':') { [INFO] [stderr] 258 | | Some(index) => { [INFO] [stderr] 259 | | let (key, value) = line.split_at(index); [INFO] [stderr] 260 | | httpinfo.headers.insert( [INFO] [stderr] ... | [INFO] [stderr] 265 | | _ => {} [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 257 | if let Some(index) = line.find(':') { [INFO] [stderr] 258 | let (key, value) = line.split_at(index); [INFO] [stderr] 259 | httpinfo.headers.insert( [INFO] [stderr] 260 | String::from(key).to_lowercase(), [INFO] [stderr] 261 | String::from(value[1..].trim()), [INFO] [stderr] 262 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/streamcheck.rs:76:36 [INFO] [stderr] | [INFO] [stderr] 76 | let search = content_type.find(";"); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/streamcheck.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match search { [INFO] [stderr] 79 | | Some(index) => { [INFO] [stderr] 80 | | content_type = &content_type[0..index]; [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | None => {} [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | if let Some(index) = search { [INFO] [stderr] 79 | content_type = &content_type[0..index]; [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/streamcheck.rs:153:41 [INFO] [stderr] | [INFO] [stderr] 153 | / for i in playlist.stream_inf_tags() { [INFO] [stderr] 154 | | let mut audio = String::from("UNKNOWN"); [INFO] [stderr] 155 | | let mut video: Option = None; [INFO] [stderr] 156 | | let codecs_obj = i.codecs(); [INFO] [stderr] ... | [INFO] [stderr] 176 | | break; [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/streamcheck.rs:198:36 [INFO] [stderr] | [INFO] [stderr] 198 | if playlist.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `playlist.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/streamcheck.rs:245:17 [INFO] [stderr] | [INFO] [stderr] 245 | / match location { [INFO] [stderr] 246 | | Some(location) => { [INFO] [stderr] 247 | | list.extend(check(location,check_all, timeout,max_depth - 1)); [INFO] [stderr] 248 | | } [INFO] [stderr] 249 | | None => {} [INFO] [stderr] 250 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 245 | if let Some(location) = location { [INFO] [stderr] 246 | list.extend(check(location,check_all, timeout,max_depth - 1)); [INFO] [stderr] 247 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/streamcheck.rs:271:17 [INFO] [stderr] | [INFO] [stderr] 271 | max_urls = max_urls - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_urls -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | / match item { [INFO] [stderr] 42 | | &Ok(_) => { [INFO] [stderr] 43 | | working = true; [INFO] [stderr] 44 | | break; [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | &Err(_) => {} [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *item { [INFO] [stderr] 42 | Ok(_) => { [INFO] [stderr] 43 | working = true; [INFO] [stderr] 44 | break; [INFO] [stderr] 45 | } [INFO] [stderr] 46 | Err(_) => {} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `av-stream-info-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return Err(Box::new(RequestError::new("connection was not possible"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::new(RequestError::new("connection was not possible")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | return Err(Box::new(RequestError::new("HTTP header missing"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::new(RequestError::new("HTTP header missing")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / return content_type == "application/mpegurl" || content_type == "application/x-mpegurl" [INFO] [stderr] 57 | | || content_type == "audio/mpegurl" || content_type == "audio/x-mpegurl" [INFO] [stderr] 58 | | || content_type == "application/vnd.apple.mpegurl" [INFO] [stderr] 59 | | || content_type == "application/vnd.apple.mpegurl.audio"; [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | content_type == "application/mpegurl" || content_type == "application/x-mpegurl" [INFO] [stderr] 57 | || content_type == "audio/mpegurl" || content_type == "audio/x-mpegurl" [INFO] [stderr] 58 | || content_type == "application/vnd.apple.mpegurl" [INFO] [stderr] 59 | || content_type == "application/vnd.apple.mpegurl.audio" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / return content_type == "audio/x-scpls" || content_type == "application/x-scpls" [INFO] [stderr] 64 | | || content_type == "application/pls+xml"; [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | content_type == "audio/x-scpls" || content_type == "application/x-scpls" [INFO] [stderr] 64 | || content_type == "application/pls+xml" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return content_type == "video/x-ms-asx" || content_type == "video/x-ms-asf"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `content_type == "video/x-ms-asx" || content_type == "video/x-ms-asf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return content_type == "application/xspf+xml"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `content_type == "application/xspf+xml"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / return type_is_m3u(content_type) || type_is_pls(content_type) || type_is_asx(content_type) [INFO] [stderr] 85 | | || type_is_xspf(content_type); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | type_is_m3u(content_type) || type_is_pls(content_type) || type_is_asx(content_type) [INFO] [stderr] 85 | || type_is_xspf(content_type) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/streamcheck.rs:366:5 [INFO] [stderr] | [INFO] [stderr] 366 | return (codec_audio,codec_video); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(codec_audio,codec_video)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/request.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | Duration::from_secs(timeout as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(timeout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/request.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | .ok_or(RequestError::new("illegal host name"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RequestError::new("illegal host name"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/request.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | .ok_or(RequestError::new("port unknown"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RequestError::new("port unknown"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/request.rs:83:58 [INFO] [stderr] | [INFO] [stderr] 83 | stream.set_read_timeout(Some(Duration::from_secs(timeout as u64)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(timeout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/request.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / let mut host_str = String::from(host); [INFO] [stderr] 89 | | if port != 443{ [INFO] [stderr] 90 | | host_str = format!("{}:{}",host,port); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let host_str = if port != 443 { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { String::from(host) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/request.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / let mut host_str = String::from(host); [INFO] [stderr] 108 | | if port != 80{ [INFO] [stderr] 109 | | host_str = format!("{}:{}",host,port); [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let host_str = if port != 80 { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { String::from(host) };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/request.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / pub fn get_content<'a>(&'a self) -> &'a str { [INFO] [stderr] 182 | | &self.content [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/request.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | stream.write(request_str.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/request.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | / match line.find(':') { [INFO] [stderr] 258 | | Some(index) => { [INFO] [stderr] 259 | | let (key, value) = line.split_at(index); [INFO] [stderr] 260 | | httpinfo.headers.insert( [INFO] [stderr] ... | [INFO] [stderr] 265 | | _ => {} [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 257 | if let Some(index) = line.find(':') { [INFO] [stderr] 258 | let (key, value) = line.split_at(index); [INFO] [stderr] 259 | httpinfo.headers.insert( [INFO] [stderr] 260 | String::from(key).to_lowercase(), [INFO] [stderr] 261 | String::from(value[1..].trim()), [INFO] [stderr] 262 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/streamcheck.rs:76:36 [INFO] [stderr] | [INFO] [stderr] 76 | let search = content_type.find(";"); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/streamcheck.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match search { [INFO] [stderr] 79 | | Some(index) => { [INFO] [stderr] 80 | | content_type = &content_type[0..index]; [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | None => {} [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | if let Some(index) = search { [INFO] [stderr] 79 | content_type = &content_type[0..index]; [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/streamcheck.rs:153:41 [INFO] [stderr] | [INFO] [stderr] 153 | / for i in playlist.stream_inf_tags() { [INFO] [stderr] 154 | | let mut audio = String::from("UNKNOWN"); [INFO] [stderr] 155 | | let mut video: Option = None; [INFO] [stderr] 156 | | let codecs_obj = i.codecs(); [INFO] [stderr] ... | [INFO] [stderr] 176 | | break; [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/streamcheck.rs:198:36 [INFO] [stderr] | [INFO] [stderr] 198 | if playlist.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `playlist.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/streamcheck.rs:245:17 [INFO] [stderr] | [INFO] [stderr] 245 | / match location { [INFO] [stderr] 246 | | Some(location) => { [INFO] [stderr] 247 | | list.extend(check(location,check_all, timeout,max_depth - 1)); [INFO] [stderr] 248 | | } [INFO] [stderr] 249 | | None => {} [INFO] [stderr] 250 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 245 | if let Some(location) = location { [INFO] [stderr] 246 | list.extend(check(location,check_all, timeout,max_depth - 1)); [INFO] [stderr] 247 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/streamcheck.rs:271:17 [INFO] [stderr] | [INFO] [stderr] 271 | max_urls = max_urls - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_urls -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | / match item { [INFO] [stderr] 42 | | &Ok(_) => { [INFO] [stderr] 43 | | working = true; [INFO] [stderr] 44 | | break; [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | &Err(_) => {} [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *item { [INFO] [stderr] 42 | Ok(_) => { [INFO] [stderr] 43 | working = true; [INFO] [stderr] 44 | break; [INFO] [stderr] 45 | } [INFO] [stderr] 46 | Err(_) => {} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `av-stream-info-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a6c201b4267a3b18088e6de6df4fa1a9d24838b198358edd93879118f307388f"` [INFO] running `"docker" "rm" "-f" "a6c201b4267a3b18088e6de6df4fa1a9d24838b198358edd93879118f307388f"` [INFO] [stdout] a6c201b4267a3b18088e6de6df4fa1a9d24838b198358edd93879118f307388f