[INFO] crate av-bitstream 0.1.0 is already in cache [INFO] extracting crate av-bitstream 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/av-bitstream/0.1.0 [INFO] extracting crate av-bitstream 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/av-bitstream/0.1.0 [INFO] validating manifest of av-bitstream-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of av-bitstream-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing av-bitstream-0.1.0 [INFO] finished frobbing av-bitstream-0.1.0 [INFO] frobbed toml for av-bitstream-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/av-bitstream/0.1.0/Cargo.toml [INFO] started frobbing av-bitstream-0.1.0 [INFO] finished frobbing av-bitstream-0.1.0 [INFO] frobbed toml for av-bitstream-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/av-bitstream/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting av-bitstream-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/av-bitstream/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 330060c7d9b6967ce6a310a0361aaf527e9d12d38ddf7d49d555dbb3eb8939a1 [INFO] running `"docker" "start" "-a" "330060c7d9b6967ce6a310a0361aaf527e9d12d38ddf7d49d555dbb3eb8939a1"` [INFO] [stderr] Checking av-bitstream v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/bitread.rs:102:30 [INFO] [stderr] | [INFO] [stderr] 102 | fn align_bits(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/bitread.rs:102:30 [INFO] [stderr] | [INFO] [stderr] 102 | fn align_bits(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitread.rs:284:44 [INFO] [stderr] | [INFO] [stderr] 284 | pub const CHECKBOARD0101: [u8; 128] = [0b01010101; 128]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_0101` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitread.rs:285:44 [INFO] [stderr] | [INFO] [stderr] 285 | pub const CHECKBOARD0011: [u8; 128] = [0b00110011; 128]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitread.rs:310:48 [INFO] [stderr] | [INFO] [stderr] 310 | assert_eq!(reader.get_bits_64(32), 1431655765); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_431_655_765` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitread.rs:419:48 [INFO] [stderr] | [INFO] [stderr] 419 | assert_eq!(reader.get_bits_64(32), 1431655765); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_431_655_765` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:392:28 [INFO] [stderr] | [INFO] [stderr] 392 | const BITS: [u8; 8] = [0b01011011, 0b10111100, 0b11111111, 0, 0, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:392:40 [INFO] [stderr] | [INFO] [stderr] 392 | const BITS: [u8; 8] = [0b01011011, 0b10111100, 0b11111111, 0, 0, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:392:52 [INFO] [stderr] | [INFO] [stderr] 392 | const BITS: [u8; 8] = [0b01011011, 0b10111100, 0b11111111, 0, 0, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:459:67 [INFO] [stderr] | [INFO] [stderr] 459 | code: 0b1111010, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:463:67 [INFO] [stderr] | [INFO] [stderr] 463 | code: 0b1111011, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:467:67 [INFO] [stderr] | [INFO] [stderr] 467 | code: 0b1111110, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:471:67 [INFO] [stderr] | [INFO] [stderr] 471 | code: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:488:35 [INFO] [stderr] | [INFO] [stderr] 488 | const BITS_LE: [u8; 8] = [0b11101111, 0b01110010, 0b01, 0, 0, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:488:47 [INFO] [stderr] | [INFO] [stderr] 488 | const BITS_LE: [u8; 8] = [0b11101111, 0b01110010, 0b01, 0, 0, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:515:69 [INFO] [stderr] | [INFO] [stderr] 515 | code: 0b0101111, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b010_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:519:69 [INFO] [stderr] | [INFO] [stderr] 519 | code: 0b0111111, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codebook.rs:523:69 [INFO] [stderr] | [INFO] [stderr] 523 | code: 0b1011101111, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b10_1110_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/codebook.rs:113:1 [INFO] [stderr] | [INFO] [stderr] 113 | / fn fill_lut(table: &mut Vec, [INFO] [stderr] 114 | | mode: CodebookMode, [INFO] [stderr] 115 | | off: usize, [INFO] [stderr] 116 | | code: u32, [INFO] [stderr] ... | [INFO] [stderr] 126 | | bits > lut_bits [INFO] [stderr] 127 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_u8` doesn't need a mutable reference [INFO] [stderr] --> src/bytewrite.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | assert!(1 == get_u8(&mut buf)); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_u8` doesn't need a mutable reference [INFO] [stderr] --> src/bytewrite.rs:120:29 [INFO] [stderr] | [INFO] [stderr] 120 | assert!(2 == get_u8(&mut buf[1..])); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_u8` doesn't need a mutable reference [INFO] [stderr] --> src/bytewrite.rs:123:31 [INFO] [stderr] | [INFO] [stderr] 123 | assert!(255 == get_u8(&mut buf[2..])); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_i8` doesn't need a mutable reference [INFO] [stderr] --> src/bytewrite.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | assert!(1 == get_i8(&mut buf)); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_i8` doesn't need a mutable reference [INFO] [stderr] --> src/bytewrite.rs:133:29 [INFO] [stderr] | [INFO] [stderr] 133 | assert!(2 == get_i8(&mut buf[1..])); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_i8` doesn't need a mutable reference [INFO] [stderr] --> src/bytewrite.rs:136:32 [INFO] [stderr] | [INFO] [stderr] 136 | assert!(-128 == get_i8(&mut buf[2..])); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/codebook.rs:113:1 [INFO] [stderr] | [INFO] [stderr] 113 | / fn fill_lut(table: &mut Vec, [INFO] [stderr] 114 | | mode: CodebookMode, [INFO] [stderr] 115 | | off: usize, [INFO] [stderr] 116 | | code: u32, [INFO] [stderr] ... | [INFO] [stderr] 126 | | bits > lut_bits [INFO] [stderr] 127 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.24s [INFO] running `"docker" "inspect" "330060c7d9b6967ce6a310a0361aaf527e9d12d38ddf7d49d555dbb3eb8939a1"` [INFO] running `"docker" "rm" "-f" "330060c7d9b6967ce6a310a0361aaf527e9d12d38ddf7d49d555dbb3eb8939a1"` [INFO] [stdout] 330060c7d9b6967ce6a310a0361aaf527e9d12d38ddf7d49d555dbb3eb8939a1