[INFO] crate auto_impl 0.3.0 is already in cache [INFO] extracting crate auto_impl 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/auto_impl/0.3.0 [INFO] extracting crate auto_impl 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/auto_impl/0.3.0 [INFO] validating manifest of auto_impl-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of auto_impl-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing auto_impl-0.3.0 [INFO] removed 0 missing tests [INFO] finished frobbing auto_impl-0.3.0 [INFO] frobbed toml for auto_impl-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/auto_impl/0.3.0/Cargo.toml [INFO] started frobbing auto_impl-0.3.0 [INFO] removed 0 missing tests [INFO] finished frobbing auto_impl-0.3.0 [INFO] frobbed toml for auto_impl-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/auto_impl/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting auto_impl-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/auto_impl/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1ea3f60e22e84b8673113caf1e71f1eadf3862d74d173a20fcc257f7fe8f6da2 [INFO] running `"docker" "start" "-a" "1ea3f60e22e84b8673113caf1e71f1eadf3862d74d173a20fcc257f7fe8f6da2"` [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking auto_impl v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:313:17 [INFO] [stderr] | [INFO] [stderr] 313 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:356:17 [INFO] [stderr] | [INFO] [stderr] 356 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:388:17 [INFO] [stderr] | [INFO] [stderr] 388 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:420:17 [INFO] [stderr] | [INFO] [stderr] 420 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:537:15 [INFO] [stderr] | [INFO] [stderr] 537 | fn as_str(&self) -> Option<&'static str> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:550:17 [INFO] [stderr] | [INFO] [stderr] 550 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:665:61 [INFO] [stderr] | [INFO] [stderr] 665 | fn should_keep_default_for(m: &TraitItemMethod, proxy_type: &ProxyType) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/proxy.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | pub(crate) fn is_fn(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking libtest-mimic v0.1.0 [INFO] [stderr] Checking build-plan v0.1.1 [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> examples/names.rs:53:10 [INFO] [stderr] | [INFO] [stderr] 53 | fn A<'b, 'c>(&self, B: C, D: E<&[F; 1]>) -> G { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> examples/names.rs:53:14 [INFO] [stderr] | [INFO] [stderr] 53 | fn A<'b, 'c>(&self, B: C, D: E<&[F; 1]>) -> G { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let H =` [INFO] [stderr] --> examples/names.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | let H = (); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:313:17 [INFO] [stderr] | [INFO] [stderr] 313 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:356:17 [INFO] [stderr] | [INFO] [stderr] 356 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:388:17 [INFO] [stderr] | [INFO] [stderr] 388 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:420:17 [INFO] [stderr] | [INFO] [stderr] 420 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:537:15 [INFO] [stderr] | [INFO] [stderr] 537 | fn as_str(&self) -> Option<&'static str> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:550:17 [INFO] [stderr] | [INFO] [stderr] 550 | proxy_type: &ProxyType, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gen.rs:665:61 [INFO] [stderr] | [INFO] [stderr] 665 | fn should_keep_default_for(m: &TraitItemMethod, proxy_type: &ProxyType) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProxyType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/proxy.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | pub(crate) fn is_fn(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/util/mod.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | outputs.remove(0).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `outputs.remove(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/util/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | env::current_dir().expect("invalid current dir").into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `env::current_dir().expect("invalid current dir")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/util/mod.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | outputs.remove(0).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `outputs.remove(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/util/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | env::current_dir().expect("invalid current dir").into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `env::current_dir().expect("invalid current dir")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.31s [INFO] running `"docker" "inspect" "1ea3f60e22e84b8673113caf1e71f1eadf3862d74d173a20fcc257f7fe8f6da2"` [INFO] running `"docker" "rm" "-f" "1ea3f60e22e84b8673113caf1e71f1eadf3862d74d173a20fcc257f7fe8f6da2"` [INFO] [stdout] 1ea3f60e22e84b8673113caf1e71f1eadf3862d74d173a20fcc257f7fe8f6da2