[INFO] crate authz 0.1.5 is already in cache [INFO] extracting crate authz 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/authz/0.1.5 [INFO] extracting crate authz 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/authz/0.1.5 [INFO] validating manifest of authz-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of authz-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing authz-0.1.5 [INFO] finished frobbing authz-0.1.5 [INFO] frobbed toml for authz-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/authz/0.1.5/Cargo.toml [INFO] started frobbing authz-0.1.5 [INFO] finished frobbing authz-0.1.5 [INFO] frobbed toml for authz-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/authz/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting authz-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/authz/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b6882be0c246242c4e3759127d4ac335da5f5e886cb0bf8b318bfe727eeeccef [INFO] running `"docker" "start" "-a" "b6882be0c246242c4e3759127d4ac335da5f5e886cb0bf8b318bfe727eeeccef"` [INFO] [stderr] Checking authz v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/authz.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | domain: domain, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `domain` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/authz.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | actions: actions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `actions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/authz.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | targets: targets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `targets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/authz.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | domain: domain, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `domain` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/authz.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | actions: actions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `actions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/authz.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | targets: targets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `targets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/authz.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | perm [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/authz.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | let perm = Permission { [INFO] [stderr] | ____________________^ [INFO] [stderr] 36 | | domain: domain, [INFO] [stderr] 37 | | actions: actions, [INFO] [stderr] 38 | | targets: targets, [INFO] [stderr] 39 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/authz.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/authz.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / if self.domain != "*" { [INFO] [stderr] 80 | | if self.domain != permission.domain { [INFO] [stderr] 81 | | return false; [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 79 | if self.domain != "*" && self.domain != permission.domain { [INFO] [stderr] 80 | return false; [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/authz.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / if !self.actions.contains("*") { [INFO] [stderr] 86 | | if !&self.actions.is_superset(&permission.actions) { [INFO] [stderr] 87 | | return false; [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | if !self.actions.contains("*") && !&self.actions.is_superset(&permission.actions) { [INFO] [stderr] 86 | return false; [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/authz.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / if !self.targets.contains("*") { [INFO] [stderr] 92 | | if !&self.targets.is_superset(&permission.targets) { [INFO] [stderr] 93 | | return false; [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | if !self.targets.contains("*") && !&self.targets.is_superset(&permission.targets) { [INFO] [stderr] 92 | return false; [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/authz.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/authz.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/authz.rs:29:11 [INFO] [stderr] | [INFO] [stderr] 29 | ["*"].into_iter().map(|s| s.to_string()).collect() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `authz`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/authz.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | perm [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/authz.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | let perm = Permission { [INFO] [stderr] | ____________________^ [INFO] [stderr] 36 | | domain: domain, [INFO] [stderr] 37 | | actions: actions, [INFO] [stderr] 38 | | targets: targets, [INFO] [stderr] 39 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/authz.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/authz.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / if self.domain != "*" { [INFO] [stderr] 80 | | if self.domain != permission.domain { [INFO] [stderr] 81 | | return false; [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 79 | if self.domain != "*" && self.domain != permission.domain { [INFO] [stderr] 80 | return false; [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/authz.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / if !self.actions.contains("*") { [INFO] [stderr] 86 | | if !&self.actions.is_superset(&permission.actions) { [INFO] [stderr] 87 | | return false; [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | if !self.actions.contains("*") && !&self.actions.is_superset(&permission.actions) { [INFO] [stderr] 86 | return false; [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/authz.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / if !self.targets.contains("*") { [INFO] [stderr] 92 | | if !&self.targets.is_superset(&permission.targets) { [INFO] [stderr] 93 | | return false; [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | if !self.targets.contains("*") && !&self.targets.is_superset(&permission.targets) { [INFO] [stderr] 92 | return false; [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/authz.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/authz.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/authz.rs:29:11 [INFO] [stderr] | [INFO] [stderr] 29 | ["*"].into_iter().map(|s| s.to_string()).collect() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `authz`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b6882be0c246242c4e3759127d4ac335da5f5e886cb0bf8b318bfe727eeeccef"` [INFO] running `"docker" "rm" "-f" "b6882be0c246242c4e3759127d4ac335da5f5e886cb0bf8b318bfe727eeeccef"` [INFO] [stdout] b6882be0c246242c4e3759127d4ac335da5f5e886cb0bf8b318bfe727eeeccef