[INFO] crate audio-video-metadata 0.1.7 is already in cache [INFO] extracting crate audio-video-metadata 0.1.7 into work/ex/clippy-test-run/sources/stable/reg/audio-video-metadata/0.1.7 [INFO] extracting crate audio-video-metadata 0.1.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/audio-video-metadata/0.1.7 [INFO] validating manifest of audio-video-metadata-0.1.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of audio-video-metadata-0.1.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing audio-video-metadata-0.1.7 [INFO] finished frobbing audio-video-metadata-0.1.7 [INFO] frobbed toml for audio-video-metadata-0.1.7 written to work/ex/clippy-test-run/sources/stable/reg/audio-video-metadata/0.1.7/Cargo.toml [INFO] started frobbing audio-video-metadata-0.1.7 [INFO] finished frobbing audio-video-metadata-0.1.7 [INFO] frobbed toml for audio-video-metadata-0.1.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/audio-video-metadata/0.1.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting audio-video-metadata-0.1.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/audio-video-metadata/0.1.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63367dea8ffd2057b86a966cb4724543a46fddf16859073a0bfb54ef79fe108b [INFO] running `"docker" "start" "-a" "63367dea8ffd2057b86a966cb4724543a46fddf16859073a0bfb54ef79fe108b"` [INFO] [stderr] Checking mp3-metadata v0.3.0 [INFO] [stderr] Checking ogg v0.5.1 [INFO] [stderr] Checking mp4parse v0.10.1 [INFO] [stderr] Checking ogg_metadata v0.4.1 [INFO] [stderr] Checking audio-video-metadata v0.1.7 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata.rs:158:66 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(metadata.duration, Some(Duration::new(12, 408162800))); [INFO] [stderr] | ^^^^^^^^^ help: consider: `408_162_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:65:45 [INFO] [stderr] | [INFO] [stderr] 65 | meta.dimensions.width = v.width as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(v.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:66:46 [INFO] [stderr] | [INFO] [stderr] 66 | meta.dimensions.height = v.height as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(v.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/metadata.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / if let Some(mut fd) = File::open(filename).ok() { [INFO] [stderr] 112 | | let mut buf = Vec::new(); [INFO] [stderr] 113 | | [INFO] [stderr] 114 | | match fd.read_to_end(&mut buf) { [INFO] [stderr] ... | [INFO] [stderr] 119 | | Err(Error::FileError) [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut fd)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match self { [INFO] [stderr] 32 | | &Error::FileError => "FileError".to_owned(), [INFO] [stderr] 33 | | &Error::UnknownFormat => "UnknownFormat".to_owned(), [INFO] [stderr] 34 | | &Error::CostumError(ref e) => e.clone(), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | Error::FileError => "FileError".to_owned(), [INFO] [stderr] 33 | Error::UnknownFormat => "UnknownFormat".to_owned(), [INFO] [stderr] 34 | Error::CostumError(ref e) => e.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:65:45 [INFO] [stderr] | [INFO] [stderr] 65 | meta.dimensions.width = v.width as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(v.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata.rs:66:46 [INFO] [stderr] | [INFO] [stderr] 66 | meta.dimensions.height = v.height as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(v.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/metadata.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / if let Some(mut fd) = File::open(filename).ok() { [INFO] [stderr] 112 | | let mut buf = Vec::new(); [INFO] [stderr] 113 | | [INFO] [stderr] 114 | | match fd.read_to_end(&mut buf) { [INFO] [stderr] ... | [INFO] [stderr] 119 | | Err(Error::FileError) [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut fd)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match self { [INFO] [stderr] 32 | | &Error::FileError => "FileError".to_owned(), [INFO] [stderr] 33 | | &Error::UnknownFormat => "UnknownFormat".to_owned(), [INFO] [stderr] 34 | | &Error::CostumError(ref e) => e.clone(), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | Error::FileError => "FileError".to_owned(), [INFO] [stderr] 33 | Error::UnknownFormat => "UnknownFormat".to_owned(), [INFO] [stderr] 34 | Error::CostumError(ref e) => e.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.19s [INFO] running `"docker" "inspect" "63367dea8ffd2057b86a966cb4724543a46fddf16859073a0bfb54ef79fe108b"` [INFO] running `"docker" "rm" "-f" "63367dea8ffd2057b86a966cb4724543a46fddf16859073a0bfb54ef79fe108b"` [INFO] [stdout] 63367dea8ffd2057b86a966cb4724543a46fddf16859073a0bfb54ef79fe108b