[INFO] crate aud 0.1.3 is already in cache [INFO] extracting crate aud 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/aud/0.1.3 [INFO] extracting crate aud 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aud/0.1.3 [INFO] validating manifest of aud-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aud-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aud-0.1.3 [INFO] finished frobbing aud-0.1.3 [INFO] frobbed toml for aud-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/aud/0.1.3/Cargo.toml [INFO] started frobbing aud-0.1.3 [INFO] finished frobbing aud-0.1.3 [INFO] frobbed toml for aud-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aud/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aud-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/aud/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 440533d9556ba25e0d9663cddc41b49b6bc719674c212023ad7081a007c2e9fb [INFO] running `"docker" "start" "-a" "440533d9556ba25e0d9663cddc41b49b6bc719674c212023ad7081a007c2e9fb"` [INFO] [stderr] Checking aud v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | Saga { adventures: adventures } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adventures` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | Saga { adventures: adventures } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adventures` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn to_error(self) -> Box { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:124:19 [INFO] [stderr] | [INFO] [stderr] 124 | fn tell_(saga: &Vec>, i: usize, acc: T) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Adventure]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | fn revert(saga: &Vec>, error: Box, i: usize, acc: T) -> Failure { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Adventure]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn to_error(self) -> Box { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:124:19 [INFO] [stderr] | [INFO] [stderr] 124 | fn tell_(saga: &Vec>, i: usize, acc: T) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Adventure]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | fn revert(saga: &Vec>, error: Box, i: usize, acc: T) -> Failure { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Adventure]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | Err(_) => unimplemented!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.56s [INFO] running `"docker" "inspect" "440533d9556ba25e0d9663cddc41b49b6bc719674c212023ad7081a007c2e9fb"` [INFO] running `"docker" "rm" "-f" "440533d9556ba25e0d9663cddc41b49b6bc719674c212023ad7081a007c2e9fb"` [INFO] [stdout] 440533d9556ba25e0d9663cddc41b49b6bc719674c212023ad7081a007c2e9fb