[INFO] crate atoms 2.2.3 is already in cache
[INFO] extracting crate atoms 2.2.3 into work/ex/clippy-test-run/sources/stable/reg/atoms/2.2.3
[INFO] extracting crate atoms 2.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atoms/2.2.3
[INFO] validating manifest of atoms-2.2.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of atoms-2.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing atoms-2.2.3
[INFO] finished frobbing atoms-2.2.3
[INFO] frobbed toml for atoms-2.2.3 written to work/ex/clippy-test-run/sources/stable/reg/atoms/2.2.3/Cargo.toml
[INFO] started frobbing atoms-2.2.3
[INFO] finished frobbing atoms-2.2.3
[INFO] frobbed toml for atoms-2.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atoms/2.2.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting atoms-2.2.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/atoms/2.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b8d3cc55e0fa8ec21b4ffb0709cb1b61ee173c74268018af81a73b1cf655a64a
[INFO] running `"docker" "start" "-a" "b8d3cc55e0fa8ec21b4ffb0709cb1b61ee173c74268018af81a73b1cf655a64a"`
[INFO] [stderr] Checking unescape v0.1.0
[INFO] [stderr] Checking atoms v2.2.3 (/opt/crater/workdir)
[INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
[INFO] [stderr] --> src/value.rs:209:49
[INFO] [stderr] |
[INFO] [stderr] 209 | pub fn into_list>, F>(source_vec: Vec, map: F) -> Value
[INFO] [stderr] | ^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr] --> src/parse.rs:216:16
[INFO] [stderr] |
[INFO] [stderr] 216 | if let Some(_) = try!(self.next()) {
[INFO] [stderr] | ^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 2 | if match $ expr {
[INFO] [stderr] 3 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 4 | :: Err ( err ) => {
[INFO] [stderr] 5 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 6 | $ crate :: convert :: From :: from ( err ) ) } }.is_some() ) ; ( $ expr : expr , ) => (
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr] --> src/parse.rs:258:12
[INFO] [stderr] |
[INFO] [stderr] 258 | if self.buffer.len() <= 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.buffer.len() == 0 instead
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr]
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr] --> src/parse.rs:269:12
[INFO] [stderr] |
[INFO] [stderr] 269 | if self.buffer.len() <= 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.buffer.len() == 0 instead
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr] --> src/parse.rs:498:9
[INFO] [stderr] |
[INFO] [stderr] 498 | / match i64::from_str(&text) {
[INFO] [stderr] 499 | | Ok(i) => return Ok(Value::int(i)),
[INFO] [stderr] 500 | | _ => {},
[INFO] [stderr] 501 | | }
[INFO] [stderr] | |_________^ help: try this: `if let Ok(i) = i64::from_str(&text) { return Ok(Value::int(i)) }`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr] --> src/parse.rs:504:9
[INFO] [stderr] |
[INFO] [stderr] 504 | / match f64::from_str(&text) {
[INFO] [stderr] 505 | | Ok(f) => return Ok(Value::float(f)),
[INFO] [stderr] 506 | | _ => {},
[INFO] [stderr] 507 | | }
[INFO] [stderr] | |_________^ help: try this: `if let Ok(f) = f64::from_str(&text) { return Ok(Value::float(f)) }`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/parse.rs:510:12
[INFO] [stderr] |
[INFO] [stderr] 510 | if text.len() == 0usize {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr]
[INFO] [stderr] error: Could not compile `atoms`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
[INFO] [stderr] --> src/value.rs:209:49
[INFO] [stderr] |
[INFO] [stderr] 209 | pub fn into_list>, F>(source_vec: Vec, map: F) -> Value
[INFO] [stderr] | ^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr] --> src/parse.rs:216:16
[INFO] [stderr] |
[INFO] [stderr] 216 | if let Some(_) = try!(self.next()) {
[INFO] [stderr] | ^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 2 | if match $ expr {
[INFO] [stderr] 3 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 4 | :: Err ( err ) => {
[INFO] [stderr] 5 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 6 | $ crate :: convert :: From :: from ( err ) ) } }.is_some() ) ; ( $ expr : expr , ) => (
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr] --> src/parse.rs:258:12
[INFO] [stderr] |
[INFO] [stderr] 258 | if self.buffer.len() <= 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.buffer.len() == 0 instead
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr]
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr] --> src/parse.rs:269:12
[INFO] [stderr] |
[INFO] [stderr] 269 | if self.buffer.len() <= 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.buffer.len() == 0 instead
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr] --> src/parse.rs:498:9
[INFO] [stderr] |
[INFO] [stderr] 498 | / match i64::from_str(&text) {
[INFO] [stderr] 499 | | Ok(i) => return Ok(Value::int(i)),
[INFO] [stderr] 500 | | _ => {},
[INFO] [stderr] 501 | | }
[INFO] [stderr] | |_________^ help: try this: `if let Ok(i) = i64::from_str(&text) { return Ok(Value::int(i)) }`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr] --> src/parse.rs:504:9
[INFO] [stderr] |
[INFO] [stderr] 504 | / match f64::from_str(&text) {
[INFO] [stderr] 505 | | Ok(f) => return Ok(Value::float(f)),
[INFO] [stderr] 506 | | _ => {},
[INFO] [stderr] 507 | | }
[INFO] [stderr] | |_________^ help: try this: `if let Ok(f) = f64::from_str(&text) { return Ok(Value::float(f)) }`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/parse.rs:510:12
[INFO] [stderr] |
[INFO] [stderr] 510 | if text.len() == 0usize {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr]
[INFO] [stderr] error: Could not compile `atoms`.
[INFO] [stderr]
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "b8d3cc55e0fa8ec21b4ffb0709cb1b61ee173c74268018af81a73b1cf655a64a"`
[INFO] running `"docker" "rm" "-f" "b8d3cc55e0fa8ec21b4ffb0709cb1b61ee173c74268018af81a73b1cf655a64a"`
[INFO] [stdout] b8d3cc55e0fa8ec21b4ffb0709cb1b61ee173c74268018af81a73b1cf655a64a