[INFO] crate atomicmonitor 0.1.2 is already in cache [INFO] extracting crate atomicmonitor 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/atomicmonitor/0.1.2 [INFO] extracting crate atomicmonitor 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atomicmonitor/0.1.2 [INFO] validating manifest of atomicmonitor-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of atomicmonitor-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing atomicmonitor-0.1.2 [INFO] finished frobbing atomicmonitor-0.1.2 [INFO] frobbed toml for atomicmonitor-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/atomicmonitor/0.1.2/Cargo.toml [INFO] started frobbing atomicmonitor-0.1.2 [INFO] finished frobbing atomicmonitor-0.1.2 [INFO] frobbed toml for atomicmonitor-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atomicmonitor/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting atomicmonitor-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/atomicmonitor/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89cd730d9605feee1edbc65a33bcfa0155611102dee0a7bf8b00abd8cf39d9a4 [INFO] running `"docker" "start" "-a" "89cd730d9605feee1edbc65a33bcfa0155611102dee0a7bf8b00abd8cf39d9a4"` [INFO] [stderr] Checking monitor v0.1.0 [INFO] [stderr] Checking atomic v0.4.3 [INFO] [stderr] Checking atomicmonitor v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:90:32 [INFO] [stderr] | [INFO] [stderr] 90 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 91 | | if let Ok(remaining) = Duration::nanoseconds(end_time as i64 - precise_time_ns() as i64).to_std() { [INFO] [stderr] 92 | | guard.wait_timeout(remaining); [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 90 | } else if let Ok(remaining) = Duration::nanoseconds(end_time as i64 - precise_time_ns() as i64).to_std() { [INFO] [stderr] 91 | guard.wait_timeout(remaining); [INFO] [stderr] 92 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u64 to i128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | let end_time = precise_time_ns() as i128 + timeout.num_nanoseconds().unwrap() as i128; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i128::from(precise_time_ns())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i64 to i128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:70:52 [INFO] [stderr] | [INFO] [stderr] 70 | let end_time = precise_time_ns() as i128 + timeout.num_nanoseconds().unwrap() as i128; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i128::from(timeout.num_nanoseconds().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | if { [INFO] [stderr] | ____________________^ [INFO] [stderr] 77 | | value = self.get(); [INFO] [stderr] 78 | | condition(value) [INFO] [stderr] 79 | | } { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: try [INFO] [stderr] let res = { [INFO] [stderr] value = self.get(); [INFO] [stderr] condition(value) [INFO] [stderr] }; [INFO] [stderr] if res { [INFO] [stderr] true [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | if { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 84 | | value = self.get(); [INFO] [stderr] 85 | | condition(value) [INFO] [stderr] 86 | | } { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: try [INFO] [stderr] let res = { [INFO] [stderr] value = self.get(); [INFO] [stderr] condition(value) [INFO] [stderr] }; [INFO] [stderr] if res { [INFO] [stderr] break true; [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: casting u64 to i128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:88:35 [INFO] [stderr] | [INFO] [stderr] 88 | } else if precise_time_ns() as i128 > end_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i128::from(precise_time_ns())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:90:32 [INFO] [stderr] | [INFO] [stderr] 90 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 91 | | if let Ok(remaining) = Duration::nanoseconds(end_time as i64 - precise_time_ns() as i64).to_std() { [INFO] [stderr] 92 | | guard.wait_timeout(remaining); [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 90 | } else if let Ok(remaining) = Duration::nanoseconds(end_time as i64 - precise_time_ns() as i64).to_std() { [INFO] [stderr] 91 | guard.wait_timeout(remaining); [INFO] [stderr] 92 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u64 to i128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | let end_time = precise_time_ns() as i128 + timeout.num_nanoseconds().unwrap() as i128; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i128::from(precise_time_ns())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i64 to i128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:70:52 [INFO] [stderr] | [INFO] [stderr] 70 | let end_time = precise_time_ns() as i128 + timeout.num_nanoseconds().unwrap() as i128; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i128::from(timeout.num_nanoseconds().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | if { [INFO] [stderr] | ____________________^ [INFO] [stderr] 77 | | value = self.get(); [INFO] [stderr] 78 | | condition(value) [INFO] [stderr] 79 | | } { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: try [INFO] [stderr] let res = { [INFO] [stderr] value = self.get(); [INFO] [stderr] condition(value) [INFO] [stderr] }; [INFO] [stderr] if res { [INFO] [stderr] true [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | if { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 84 | | value = self.get(); [INFO] [stderr] 85 | | condition(value) [INFO] [stderr] 86 | | } { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: try [INFO] [stderr] let res = { [INFO] [stderr] value = self.get(); [INFO] [stderr] condition(value) [INFO] [stderr] }; [INFO] [stderr] if res { [INFO] [stderr] break true; [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: casting u64 to i128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:88:35 [INFO] [stderr] | [INFO] [stderr] 88 | } else if precise_time_ns() as i128 > end_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i128::from(precise_time_ns())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.57s [INFO] running `"docker" "inspect" "89cd730d9605feee1edbc65a33bcfa0155611102dee0a7bf8b00abd8cf39d9a4"` [INFO] running `"docker" "rm" "-f" "89cd730d9605feee1edbc65a33bcfa0155611102dee0a7bf8b00abd8cf39d9a4"` [INFO] [stdout] 89cd730d9605feee1edbc65a33bcfa0155611102dee0a7bf8b00abd8cf39d9a4