[INFO] crate atlatl 0.1.2 is already in cache [INFO] extracting crate atlatl 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/atlatl/0.1.2 [INFO] extracting crate atlatl 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atlatl/0.1.2 [INFO] validating manifest of atlatl-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of atlatl-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing atlatl-0.1.2 [INFO] finished frobbing atlatl-0.1.2 [INFO] frobbed toml for atlatl-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/atlatl/0.1.2/Cargo.toml [INFO] started frobbing atlatl-0.1.2 [INFO] finished frobbing atlatl-0.1.2 [INFO] frobbed toml for atlatl-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atlatl/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting atlatl-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/atlatl/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ab60258778702a6309ef453187c62adca70d19f3bb375cfab957d4f26bbd5ad2 [INFO] running `"docker" "start" "-a" "ab60258778702a6309ef453187c62adca70d19f3bb375cfab957d4f26bbd5ad2"` [INFO] [stderr] Checking atlatl v0.1.2 (/opt/crater/workdir) [INFO] [stderr] Checking fst v0.1.38 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fst/intermediate.rs:62:62 [INFO] [stderr] | [INFO] [stderr] 62 | self.fst.da.stipe[e] = Stipe { check: label, terminal: terminal }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `terminal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fst/mod.rs:80:75 [INFO] [stderr] | [INFO] [stderr] 80 | if check == input => Some(State { index: self.da.next[e], terminal: terminal }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `terminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fst/mod.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | root_output : root_output, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `fst::builder::Builder` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fst/builder.rs:167:1 [INFO] [stderr] | [INFO] [stderr] 167 | / impl Builder where I : Index, O : Output { [INFO] [stderr] 168 | | fn register(&mut self, state : State) -> Result { [INFO] [stderr] 169 | | let idx = &mut self.usable_index; [INFO] [stderr] 170 | | let trans_r = &mut self.transition_count; [INFO] [stderr] ... | [INFO] [stderr] 261 | | pub fn len(&self) -> usize { self.language_size } [INFO] [stderr] 262 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/fst/builder.rs:179:17 [INFO] [stderr] | [INFO] [stderr] 179 | / match s_i > I::bound() || *trans_r > I::bound() { [INFO] [stderr] 180 | | true => Err(Error::OutOfBounds { [INFO] [stderr] 181 | | reached : cmp::max(s_i, *trans_r), [INFO] [stderr] 182 | | maximum : I::max_value().as_usize() [INFO] [stderr] 183 | | }), [INFO] [stderr] 184 | | false => Ok(*e.insert(I::as_index(s_i))) [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 179 | if s_i > I::bound() || *trans_r > I::bound() { Err(Error::OutOfBounds { [INFO] [stderr] 180 | reached : cmp::max(s_i, *trans_r), [INFO] [stderr] 181 | maximum : I::max_value().as_usize() [INFO] [stderr] 182 | }) } else { Ok(*e.insert(I::as_index(s_i))) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/fst/builder.rs:246:5 [INFO] [stderr] | [INFO] [stderr] 246 | / pub fn from_iter(iter : T) -> Result> [INFO] [stderr] 247 | | where K : AsRef<[u8]> [INFO] [stderr] 248 | | , T : IntoIterator [INFO] [stderr] 249 | | { [INFO] [stderr] ... | [INFO] [stderr] 254 | | Ok(builder) [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: item `fst::intermediate::Intermediary` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fst/intermediate.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / impl Intermediary where I : Index, O : Output { [INFO] [stderr] 20 | | pub fn into_dart(self) -> FST { self.fst } [INFO] [stderr] 21 | | [INFO] [stderr] 22 | | /// Build an intermediate representation [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/fst/intermediate.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn from_builder(&mut self, fst : &Builder) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/fst/intermediate.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match base > I::bound() { [INFO] [stderr] 85 | | true => Err(Error::OutOfBounds { [INFO] [stderr] 86 | | reached : base, [INFO] [stderr] 87 | | maximum : I::max_value().as_usize() [INFO] [stderr] 88 | | }), [INFO] [stderr] 89 | | false => Ok(base) [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 84 | if base > I::bound() { Err(Error::OutOfBounds { [INFO] [stderr] 85 | reached : base, [INFO] [stderr] 86 | maximum : I::max_value().as_usize() [INFO] [stderr] 87 | }) } else { Ok(base) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `fst::FST` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fst/mod.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | / impl FST where I : Index, O : Output { [INFO] [stderr] 69 | | pub fn from_builder(builder : &builder::Builder) -> Result { [INFO] [stderr] 70 | | let mut repr = Intermediary::default(); [INFO] [stderr] 71 | | repr.from_builder(builder) ?; [INFO] [stderr] ... | [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/fst/mod.rs:138:27 [INFO] [stderr] | [INFO] [stderr] 138 | query : query.into_iter(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/fst/mod.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | query : query.into_iter(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fst/intermediate.rs:62:62 [INFO] [stderr] | [INFO] [stderr] 62 | self.fst.da.stipe[e] = Stipe { check: label, terminal: terminal }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `terminal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fst/mod.rs:80:75 [INFO] [stderr] | [INFO] [stderr] 80 | if check == input => Some(State { index: self.da.next[e], terminal: terminal }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `terminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fst/mod.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | root_output : root_output, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `atlatl`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `fst::builder::Builder` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fst/builder.rs:167:1 [INFO] [stderr] | [INFO] [stderr] 167 | / impl Builder where I : Index, O : Output { [INFO] [stderr] 168 | | fn register(&mut self, state : State) -> Result { [INFO] [stderr] 169 | | let idx = &mut self.usable_index; [INFO] [stderr] 170 | | let trans_r = &mut self.transition_count; [INFO] [stderr] ... | [INFO] [stderr] 261 | | pub fn len(&self) -> usize { self.language_size } [INFO] [stderr] 262 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/fst/builder.rs:179:17 [INFO] [stderr] | [INFO] [stderr] 179 | / match s_i > I::bound() || *trans_r > I::bound() { [INFO] [stderr] 180 | | true => Err(Error::OutOfBounds { [INFO] [stderr] 181 | | reached : cmp::max(s_i, *trans_r), [INFO] [stderr] 182 | | maximum : I::max_value().as_usize() [INFO] [stderr] 183 | | }), [INFO] [stderr] 184 | | false => Ok(*e.insert(I::as_index(s_i))) [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 179 | if s_i > I::bound() || *trans_r > I::bound() { Err(Error::OutOfBounds { [INFO] [stderr] 180 | reached : cmp::max(s_i, *trans_r), [INFO] [stderr] 181 | maximum : I::max_value().as_usize() [INFO] [stderr] 182 | }) } else { Ok(*e.insert(I::as_index(s_i))) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/fst/builder.rs:246:5 [INFO] [stderr] | [INFO] [stderr] 246 | / pub fn from_iter(iter : T) -> Result> [INFO] [stderr] 247 | | where K : AsRef<[u8]> [INFO] [stderr] 248 | | , T : IntoIterator [INFO] [stderr] 249 | | { [INFO] [stderr] ... | [INFO] [stderr] 254 | | Ok(builder) [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: item `fst::intermediate::Intermediary` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fst/intermediate.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / impl Intermediary where I : Index, O : Output { [INFO] [stderr] 20 | | pub fn into_dart(self) -> FST { self.fst } [INFO] [stderr] 21 | | [INFO] [stderr] 22 | | /// Build an intermediate representation [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/fst/intermediate.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn from_builder(&mut self, fst : &Builder) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/fst/intermediate.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match base > I::bound() { [INFO] [stderr] 85 | | true => Err(Error::OutOfBounds { [INFO] [stderr] 86 | | reached : base, [INFO] [stderr] 87 | | maximum : I::max_value().as_usize() [INFO] [stderr] 88 | | }), [INFO] [stderr] 89 | | false => Ok(base) [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 84 | if base > I::bound() { Err(Error::OutOfBounds { [INFO] [stderr] 85 | reached : base, [INFO] [stderr] 86 | maximum : I::max_value().as_usize() [INFO] [stderr] 87 | }) } else { Ok(base) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `fst::FST` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/fst/mod.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | / impl FST where I : Index, O : Output { [INFO] [stderr] 69 | | pub fn from_builder(builder : &builder::Builder) -> Result { [INFO] [stderr] 70 | | let mut repr = Intermediary::default(); [INFO] [stderr] 71 | | repr.from_builder(builder) ?; [INFO] [stderr] ... | [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/fst/mod.rs:138:27 [INFO] [stderr] | [INFO] [stderr] 138 | query : query.into_iter(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/fst/mod.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | query : query.into_iter(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/lib.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | let reaper = fst.reap("abcd".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ab60258778702a6309ef453187c62adca70d19f3bb375cfab957d4f26bbd5ad2"` [INFO] running `"docker" "rm" "-f" "ab60258778702a6309ef453187c62adca70d19f3bb375cfab957d4f26bbd5ad2"` [INFO] [stdout] ab60258778702a6309ef453187c62adca70d19f3bb375cfab957d4f26bbd5ad2