[INFO] crate atlas-coverage-core 0.1.0 is already in cache [INFO] extracting crate atlas-coverage-core 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/atlas-coverage-core/0.1.0 [INFO] extracting crate atlas-coverage-core 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atlas-coverage-core/0.1.0 [INFO] validating manifest of atlas-coverage-core-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of atlas-coverage-core-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing atlas-coverage-core-0.1.0 [INFO] finished frobbing atlas-coverage-core-0.1.0 [INFO] frobbed toml for atlas-coverage-core-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/atlas-coverage-core/0.1.0/Cargo.toml [INFO] started frobbing atlas-coverage-core-0.1.0 [INFO] finished frobbing atlas-coverage-core-0.1.0 [INFO] frobbed toml for atlas-coverage-core-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atlas-coverage-core/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting atlas-coverage-core-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/atlas-coverage-core/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 581aba5ea7a461a10fde308b41c42c21a9a4cc1c5e72eceabb91934fa2e33a96 [INFO] running `"docker" "start" "-a" "581aba5ea7a461a10fde308b41c42c21a9a4cc1c5e72eceabb91934fa2e33a96"` [INFO] [stderr] Checking vlq v0.5.1 [INFO] [stderr] Checking lcov-parser v3.2.2 [INFO] [stderr] Checking ecmascript v0.1.0 [INFO] [stderr] Checking atlas-coverage-core v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lcov.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/vlq_decode.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/vlq_decode.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lcov.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/vlq_decode.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/vlq_decode.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env::args` [INFO] [stderr] --> src/lib.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | use std::env::args; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env::args` [INFO] [stderr] --> src/lib.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | use std::env::args; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/lib.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_xml_to_stdout` [INFO] [stderr] --> src/lines.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn write_xml_to_stdout(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/debug.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | let paths = reads.into_iter().map(|v| v.expect("Cannot read file entry").path()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `reads` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/debug.rs:101:38 [INFO] [stderr] | [INFO] [stderr] 101 | let minified_slice: String = minified [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 102 | | .lines() [INFO] [stderr] 103 | | .skip(v.gen_line as usize) [INFO] [stderr] 104 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/debug.rs:117:28 [INFO] [stderr] | [INFO] [stderr] 117 | source_slice = sources [INFO] [stderr] | ____________________________^ [INFO] [stderr] 118 | | .get(source_ref.source_idx as usize) [INFO] [stderr] 119 | | .unwrap() [INFO] [stderr] | |_________________________^ help: try this: `sources[source_ref.source_idx as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/debug.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | / source_content [INFO] [stderr] 123 | | .lines() [INFO] [stderr] 124 | | .skip(source_ref.source_line as usize) [INFO] [stderr] 125 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/debug.rs:155:22 [INFO] [stderr] | [INFO] [stderr] 155 | name.unwrap_or("".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lcov.rs:24:58 [INFO] [stderr] | [INFO] [stderr] 24 | let split = self.input.find('\n').map(|i| i + 1).unwrap_or(self.input.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.input.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lcov.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | / match LCOVRecord::from(line) { [INFO] [stderr] 59 | | LCOVRecord::SourceFile(src_file) => { [INFO] [stderr] 60 | | return LcovFilesLines { [INFO] [stderr] 61 | | lines, [INFO] [stderr] ... | [INFO] [stderr] 65 | | _ => {} [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | if let LCOVRecord::SourceFile(src_file) = LCOVRecord::from(line) { [INFO] [stderr] 59 | return LcovFilesLines { [INFO] [stderr] 60 | lines, [INFO] [stderr] 61 | next_file: Some(src_file), [INFO] [stderr] 62 | } [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lines.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | sources.get_mut(source_ref.source_idx as usize).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `sources[source_ref.source_idx as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lines.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | .or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lines.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / minified [INFO] [stderr] 78 | | .lines() [INFO] [stderr] 79 | | .into_iter() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 77 | minified [INFO] [stderr] 78 | .lines() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lines.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | sum = sum + line.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += line.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/load.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(deserializer.deserialize_seq(visitor)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 95 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/load.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | type IntoIter = ::std::iter::Map< [INFO] [stderr] | _____________________^ [INFO] [stderr] 111 | | ::std::collections::hash_map::IntoIter<::std::string::String, load::RawCoveragePart>, [INFO] [stderr] 112 | | fn((String, load::RawCoveragePart)) -> model::PuppeteerData, [INFO] [stderr] 113 | | >; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vlq_decode.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | self.idx = self.idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vlq_decode.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | self.idx = self.idx - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.idx -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vlq_decode.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | } else if self.data[idx] == ';' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b';' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vlq_decode.rs:57:37 [INFO] [stderr] | [INFO] [stderr] 57 | } else if self.data[idx] == ',' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b',' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vlq_decode.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | self.gen_column = self.gen_column + gen_col_offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.gen_column += gen_col_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | our_coverage.map(|our_coverage| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 71 | || let new_lines : HashSet<_> = line_data.lines.into_iter().collect(); [INFO] [stderr] 72 | || [INFO] [stderr] 73 | || our_coverage.lines.retain(|v| new_lines.contains(&v.line_number)); [INFO] [stderr] 74 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(our_coverage) = our_coverage { ... }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_xml_to_stdout` [INFO] [stderr] --> src/lines.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn write_xml_to_stdout(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/debug.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | let paths = reads.into_iter().map(|v| v.expect("Cannot read file entry").path()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `reads` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/debug.rs:101:38 [INFO] [stderr] | [INFO] [stderr] 101 | let minified_slice: String = minified [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 102 | | .lines() [INFO] [stderr] 103 | | .skip(v.gen_line as usize) [INFO] [stderr] 104 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/debug.rs:117:28 [INFO] [stderr] | [INFO] [stderr] 117 | source_slice = sources [INFO] [stderr] | ____________________________^ [INFO] [stderr] 118 | | .get(source_ref.source_idx as usize) [INFO] [stderr] 119 | | .unwrap() [INFO] [stderr] | |_________________________^ help: try this: `sources[source_ref.source_idx as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/debug.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | / source_content [INFO] [stderr] 123 | | .lines() [INFO] [stderr] 124 | | .skip(source_ref.source_line as usize) [INFO] [stderr] 125 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/debug.rs:155:22 [INFO] [stderr] | [INFO] [stderr] 155 | name.unwrap_or("".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lcov.rs:24:58 [INFO] [stderr] | [INFO] [stderr] 24 | let split = self.input.find('\n').map(|i| i + 1).unwrap_or(self.input.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.input.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lcov.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | / match LCOVRecord::from(line) { [INFO] [stderr] 59 | | LCOVRecord::SourceFile(src_file) => { [INFO] [stderr] 60 | | return LcovFilesLines { [INFO] [stderr] 61 | | lines, [INFO] [stderr] ... | [INFO] [stderr] 65 | | _ => {} [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | if let LCOVRecord::SourceFile(src_file) = LCOVRecord::from(line) { [INFO] [stderr] 59 | return LcovFilesLines { [INFO] [stderr] 60 | lines, [INFO] [stderr] 61 | next_file: Some(src_file), [INFO] [stderr] 62 | } [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lines.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | sources.get_mut(source_ref.source_idx as usize).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `sources[source_ref.source_idx as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lines.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | .or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lines.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / minified [INFO] [stderr] 78 | | .lines() [INFO] [stderr] 79 | | .into_iter() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 77 | minified [INFO] [stderr] 78 | .lines() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lines.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | sum = sum + line.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += line.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/load.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(deserializer.deserialize_seq(visitor)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 95 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/load.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | type IntoIter = ::std::iter::Map< [INFO] [stderr] | _____________________^ [INFO] [stderr] 111 | | ::std::collections::hash_map::IntoIter<::std::string::String, load::RawCoveragePart>, [INFO] [stderr] 112 | | fn((String, load::RawCoveragePart)) -> model::PuppeteerData, [INFO] [stderr] 113 | | >; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vlq_decode.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | self.idx = self.idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vlq_decode.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | self.idx = self.idx - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.idx -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vlq_decode.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | } else if self.data[idx] == ';' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b';' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vlq_decode.rs:57:37 [INFO] [stderr] | [INFO] [stderr] 57 | } else if self.data[idx] == ',' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b',' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vlq_decode.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | self.gen_column = self.gen_column + gen_col_offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.gen_column += gen_col_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | our_coverage.map(|our_coverage| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 71 | || let new_lines : HashSet<_> = line_data.lines.into_iter().collect(); [INFO] [stderr] 72 | || [INFO] [stderr] 73 | || our_coverage.lines.retain(|v| new_lines.contains(&v.line_number)); [INFO] [stderr] 74 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(our_coverage) = our_coverage { ... }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::PathBuf` [INFO] [stderr] --> src/bin/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::path::PathBuf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/main.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | let paths = reads.into_iter().map(|v| v.expect("Cannot read file entry").path()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `reads` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::PathBuf` [INFO] [stderr] --> src/bin/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::path::PathBuf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/main.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | let paths = reads.into_iter().map(|v| v.expect("Cannot read file entry").path()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `reads` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.81s [INFO] running `"docker" "inspect" "581aba5ea7a461a10fde308b41c42c21a9a4cc1c5e72eceabb91934fa2e33a96"` [INFO] running `"docker" "rm" "-f" "581aba5ea7a461a10fde308b41c42c21a9a4cc1c5e72eceabb91934fa2e33a96"` [INFO] [stdout] 581aba5ea7a461a10fde308b41c42c21a9a4cc1c5e72eceabb91934fa2e33a96