[INFO] crate aterm 0.20.0 is already in cache [INFO] extracting crate aterm 0.20.0 into work/ex/clippy-test-run/sources/stable/reg/aterm/0.20.0 [INFO] extracting crate aterm 0.20.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aterm/0.20.0 [INFO] validating manifest of aterm-0.20.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aterm-0.20.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aterm-0.20.0 [INFO] finished frobbing aterm-0.20.0 [INFO] frobbed toml for aterm-0.20.0 written to work/ex/clippy-test-run/sources/stable/reg/aterm/0.20.0/Cargo.toml [INFO] started frobbing aterm-0.20.0 [INFO] finished frobbing aterm-0.20.0 [INFO] frobbed toml for aterm-0.20.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aterm/0.20.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aterm-0.20.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/aterm/0.20.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a1f0db57ae92f3331966cb72019a1d01e3f9b35c3ad5b0d989b7d047a2968898 [INFO] running `"docker" "start" "-a" "a1f0db57ae92f3331966cb72019a1d01e3f9b35c3ad5b0d989b7d047a2968898"` [INFO] [stderr] Checking aterm v0.20.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/utils.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rc/mod.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rc/mod.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `zero_ptr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/parse.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | #[allow(unknown_lints, zero_ptr)] // clippy: shut up about a macro from another crate [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::zero_ptr` [INFO] [stderr] [INFO] [stderr] warning: lint name `zero_ptr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/parse.rs:121:28 [INFO] [stderr] | [INFO] [stderr] 121 | #[allow(unknown_lints, zero_ptr)] // clippy: shut up about a macro from another crate [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::zero_ptr` [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/parse.rs:172:1 [INFO] [stderr] | [INFO] [stderr] 172 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/parse.rs:363:1 [INFO] [stderr] | [INFO] [stderr] 363 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/utils.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rc/mod.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rc/mod.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `zero_ptr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/parse.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | #[allow(unknown_lints, zero_ptr)] // clippy: shut up about a macro from another crate [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::zero_ptr` [INFO] [stderr] [INFO] [stderr] warning: lint name `zero_ptr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/parse.rs:121:28 [INFO] [stderr] | [INFO] [stderr] 121 | #[allow(unknown_lints, zero_ptr)] // clippy: shut up about a macro from another crate [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::zero_ptr` [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/parse.rs:172:1 [INFO] [stderr] | [INFO] [stderr] 172 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/parse.rs:363:1 [INFO] [stderr] | [INFO] [stderr] 363 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/utils.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/utils.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parse.rs:636:29 [INFO] [stderr] | [INFO] [stderr] 636 | let i = factory.int(1234567); [INFO] [stderr] | ^^^^^^^ help: consider: `1_234_567` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parse.rs:643:30 [INFO] [stderr] | [INFO] [stderr] 643 | let l = factory.long(1234567); [INFO] [stderr] | ^^^^^^^ help: consider: `1_234_567` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/rc/mod.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | let mut string_cache = unsafe { extend_lifetime_mut(&mut self.string_cache.borrow_mut()) }; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/rc/shared.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | let mut string_cache = unsafe { extend_lifetime_mut(&mut self.string_cache.borrow_mut()) }; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bad_idea.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | fn key(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/rc/mod.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | pub type T<'s, A: ATermT<'s>> = Term<'s, >::Blob>; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_annotations` which has no body [INFO] [stderr] --> src/interface.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 54 | | fn get_annotations(&self) -> &[Self::Rec]; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_int` which has no body [INFO] [stderr] --> src/interface.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 57 | | fn get_int(&self) -> Option; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_long` which has no body [INFO] [stderr] --> src/interface.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 60 | | fn get_long(&self) -> Option; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_real` which has no body [INFO] [stderr] --> src/interface.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 63 | | fn get_real(&self) -> Option; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_application` which has no body [INFO] [stderr] --> src/interface.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 66 | | fn get_application(&self) -> Option<(InternedString<'s>, &[Self::Rec])>; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_list` which has no body [INFO] [stderr] --> src/interface.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 69 | | fn get_list(&self) -> Option>; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_placeholder` which has no body [INFO] [stderr] --> src/interface.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 72 | | fn get_placeholder(&self) -> Option<&TermPlaceholder>; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_blob` which has no body [INFO] [stderr] --> src/interface.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 75 | | fn get_blob(&self) -> Option<&Self::Blob>; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/string_share.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | InternedString(self.map.get::(itemcow.borrow()).map(|&s| s).unwrap_or_else(|| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.map.get::(itemcow.borrow()).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `aterm`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/rc/mod.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | let mut string_cache = unsafe { extend_lifetime_mut(&mut self.string_cache.borrow_mut()) }; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/rc/shared.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | let mut string_cache = unsafe { extend_lifetime_mut(&mut self.string_cache.borrow_mut()) }; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bad_idea.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | fn key(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/rc/mod.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | pub type T<'s, A: ATermT<'s>> = Term<'s, >::Blob>; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_annotations` which has no body [INFO] [stderr] --> src/interface.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 54 | | fn get_annotations(&self) -> &[Self::Rec]; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_int` which has no body [INFO] [stderr] --> src/interface.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 57 | | fn get_int(&self) -> Option; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_long` which has no body [INFO] [stderr] --> src/interface.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 60 | | fn get_long(&self) -> Option; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_real` which has no body [INFO] [stderr] --> src/interface.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 63 | | fn get_real(&self) -> Option; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_application` which has no body [INFO] [stderr] --> src/interface.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 66 | | fn get_application(&self) -> Option<(InternedString<'s>, &[Self::Rec])>; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_list` which has no body [INFO] [stderr] --> src/interface.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 69 | | fn get_list(&self) -> Option>; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_placeholder` which has no body [INFO] [stderr] --> src/interface.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 72 | | fn get_placeholder(&self) -> Option<&TermPlaceholder>; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `get_blob` which has no body [INFO] [stderr] --> src/interface.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 75 | | fn get_blob(&self) -> Option<&Self::Blob>; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/string_share.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | InternedString(self.map.get::(itemcow.borrow()).map(|&s| s).unwrap_or_else(|| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.map.get::(itemcow.borrow()).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `aterm`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a1f0db57ae92f3331966cb72019a1d01e3f9b35c3ad5b0d989b7d047a2968898"` [INFO] running `"docker" "rm" "-f" "a1f0db57ae92f3331966cb72019a1d01e3f9b35c3ad5b0d989b7d047a2968898"` [INFO] [stdout] a1f0db57ae92f3331966cb72019a1d01e3f9b35c3ad5b0d989b7d047a2968898