[INFO] crate atarashii_imap 0.3.0 is already in cache [INFO] extracting crate atarashii_imap 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/atarashii_imap/0.3.0 [INFO] extracting crate atarashii_imap 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atarashii_imap/0.3.0 [INFO] validating manifest of atarashii_imap-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of atarashii_imap-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing atarashii_imap-0.3.0 [INFO] finished frobbing atarashii_imap-0.3.0 [INFO] frobbed toml for atarashii_imap-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/atarashii_imap/0.3.0/Cargo.toml [INFO] started frobbing atarashii_imap-0.3.0 [INFO] finished frobbing atarashii_imap-0.3.0 [INFO] frobbed toml for atarashii_imap-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atarashii_imap/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting atarashii_imap-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/atarashii_imap/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aab5d2aa18356afd8f89d58e01ea9d4481bfc9cefb4dc7e075670d7d8086ba3b [INFO] running `"docker" "start" "-a" "aab5d2aa18356afd8f89d58e01ea9d4481bfc9cefb4dc7e075670d7d8086ba3b"` [INFO] [stderr] warning: file found to be present in multiple build targets: /opt/crater/workdir/examples/app.rs [INFO] [stderr] Checking atarashii_imap v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | Connection { port: port, host: host.to_string(), tcp_stream_ex: tcps_ex, tag_sequence_number: Cell::new(1) } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | Connection { port: port, host: host.to_string(), tcp_stream_ex: tcps_ex, tag_sequence_number: Cell::new(1) } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:245:65 [INFO] [stderr] | [INFO] [stderr] 245 | fn verify_greeting(stcp_conn: &mut ssl::SslStream) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes_read` [INFO] [stderr] --> src/lib.rs:204:14 [INFO] [stderr] | [INFO] [stderr] 204 | Ok(bytes_read) => { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_bytes_read` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `login_res` [INFO] [stderr] --> src/lib.rs:210:18 [INFO] [stderr] | [INFO] [stderr] 210 | Ok(login_res) => unimplemented!(), [INFO] [stderr] | ^^^^^^^^^ help: consider using `_login_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:211:19 [INFO] [stderr] | [INFO] [stderr] 211 | Err(e) => unimplemented!() [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:215:15 [INFO] [stderr] | [INFO] [stderr] 215 | Err(e) => unimplemented!() [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:219:11 [INFO] [stderr] | [INFO] [stderr] 219 | Err(e) => unimplemented!() [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `re_tag_and_res` [INFO] [stderr] --> src/lib.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | let re_tag_and_res = Regex::new(&format!(r"{}\s(OK|NO|BAD){{1}}", self.get_current_tag())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_re_tag_and_res` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StartTls` [INFO] [stderr] --> src/lib.rs:65:3 [INFO] [stderr] | [INFO] [stderr] 65 | StartTls(ssl::SslStream), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `start_tls` [INFO] [stderr] --> src/lib.rs:490:3 [INFO] [stderr] | [INFO] [stderr] 490 | fn start_tls(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:245:65 [INFO] [stderr] | [INFO] [stderr] 245 | fn verify_greeting(stcp_conn: &mut ssl::SslStream) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | &greet_buf[greet_buf.len() - NEW_LINE_FULL_CODE_LEN..] == &NEW_LINE_FULL_CODE[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 250 | greet_buf[greet_buf.len() - NEW_LINE_FULL_CODE_LEN..] == NEW_LINE_FULL_CODE[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:284:46 [INFO] [stderr] | [INFO] [stderr] 284 | let flg2: Vec<&str> = flg1.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:291:46 [INFO] [stderr] | [INFO] [stderr] 291 | let flg2: Vec<&str> = flg1.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:448:60 [INFO] [stderr] | [INFO] [stderr] 448 | if read_buf.len() >= NEW_LINE_FULL_CODE.len() && &read_buf[read_buf.len() - NEW_LINE_FULL_CODE.len()..] == &NEW_LINE_FULL_CODE[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 448 | if read_buf.len() >= NEW_LINE_FULL_CODE.len() && read_buf[read_buf.len() - NEW_LINE_FULL_CODE.len()..] == NEW_LINE_FULL_CODE[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes_read` [INFO] [stderr] --> src/lib.rs:204:14 [INFO] [stderr] | [INFO] [stderr] 204 | Ok(bytes_read) => { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_bytes_read` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `login_res` [INFO] [stderr] --> src/lib.rs:210:18 [INFO] [stderr] | [INFO] [stderr] 210 | Ok(login_res) => unimplemented!(), [INFO] [stderr] | ^^^^^^^^^ help: consider using `_login_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:211:19 [INFO] [stderr] | [INFO] [stderr] 211 | Err(e) => unimplemented!() [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:215:15 [INFO] [stderr] | [INFO] [stderr] 215 | Err(e) => unimplemented!() [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:219:11 [INFO] [stderr] | [INFO] [stderr] 219 | Err(e) => unimplemented!() [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `re_tag_and_res` [INFO] [stderr] --> src/lib.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | let re_tag_and_res = Regex::new(&format!(r"{}\s(OK|NO|BAD){{1}}", self.get_current_tag())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_re_tag_and_res` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StartTls` [INFO] [stderr] --> src/lib.rs:65:3 [INFO] [stderr] | [INFO] [stderr] 65 | StartTls(ssl::SslStream), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `start_tls` [INFO] [stderr] --> src/lib.rs:490:3 [INFO] [stderr] | [INFO] [stderr] 490 | fn start_tls(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | &greet_buf[greet_buf.len() - NEW_LINE_FULL_CODE_LEN..] == &NEW_LINE_FULL_CODE[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 250 | greet_buf[greet_buf.len() - NEW_LINE_FULL_CODE_LEN..] == NEW_LINE_FULL_CODE[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:284:46 [INFO] [stderr] | [INFO] [stderr] 284 | let flg2: Vec<&str> = flg1.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:291:46 [INFO] [stderr] | [INFO] [stderr] 291 | let flg2: Vec<&str> = flg1.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:448:60 [INFO] [stderr] | [INFO] [stderr] 448 | if read_buf.len() >= NEW_LINE_FULL_CODE.len() && &read_buf[read_buf.len() - NEW_LINE_FULL_CODE.len()..] == &NEW_LINE_FULL_CODE[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 448 | if read_buf.len() >= NEW_LINE_FULL_CODE.len() && read_buf[read_buf.len() - NEW_LINE_FULL_CODE.len()..] == NEW_LINE_FULL_CODE[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `SslContext`, `SslStream` [INFO] [stderr] --> examples/app.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | use openssl::ssl::{SslContext, SslStream}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `SslConnectorBuilder`, `SslMethod` [INFO] [stderr] --> examples/app.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | use openssl::ssl::{SslMethod, SslConnectorBuilder}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> examples/app.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | Err(_) => panic!("Unable to open connection") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: unused imports: `SslContext`, `SslStream` [INFO] [stderr] --> examples/app.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | use openssl::ssl::{SslContext, SslStream}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `SslConnectorBuilder`, `SslMethod` [INFO] [stderr] --> examples/app.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | use openssl::ssl::{SslMethod, SslConnectorBuilder}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> examples/app.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | Err(_) => panic!("Unable to open connection") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: unused imports: `SslContext`, `SslStream` [INFO] [stderr] --> examples/app.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | use openssl::ssl::{SslContext, SslStream}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `SslConnectorBuilder`, `SslMethod` [INFO] [stderr] --> examples/app.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | use openssl::ssl::{SslMethod, SslConnectorBuilder}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> examples/app.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | Err(_) => panic!("Unable to open connection") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.59s [INFO] running `"docker" "inspect" "aab5d2aa18356afd8f89d58e01ea9d4481bfc9cefb4dc7e075670d7d8086ba3b"` [INFO] running `"docker" "rm" "-f" "aab5d2aa18356afd8f89d58e01ea9d4481bfc9cefb4dc7e075670d7d8086ba3b"` [INFO] [stdout] aab5d2aa18356afd8f89d58e01ea9d4481bfc9cefb4dc7e075670d7d8086ba3b