[INFO] crate atadb 0.1.0 is already in cache
[INFO] extracting crate atadb 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/atadb/0.1.0
[INFO] extracting crate atadb 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atadb/0.1.0
[INFO] validating manifest of atadb-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of atadb-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing atadb-0.1.0
[INFO] finished frobbing atadb-0.1.0
[INFO] frobbed toml for atadb-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/atadb/0.1.0/Cargo.toml
[INFO] started frobbing atadb-0.1.0
[INFO] finished frobbing atadb-0.1.0
[INFO] frobbed toml for atadb-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/atadb/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting atadb-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/atadb/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a891be8629e8b1e7cebc679f6a5591b8039b16290e0f5232e21e31ee42fbf2ac
[INFO] running `"docker" "start" "-a" "a891be8629e8b1e7cebc679f6a5591b8039b16290e0f5232e21e31ee42fbf2ac"`
[INFO] [stderr]     Checking atadb v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/util/envpath.rs:5:23
[INFO] [stderr]   |
[INFO] [stderr] 5 | const ATA_PATH_NAME: &'static str = "ATADB_PATH";
[INFO] [stderr]   |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/util/envpath.rs:5:23
[INFO] [stderr]   |
[INFO] [stderr] 5 | const ATA_PATH_NAME: &'static str = "ATADB_PATH";
[INFO] [stderr]   |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/util/envpath.rs:29:11
[INFO] [stderr]    |
[INFO] [stderr] 29 |     match env::home_dir() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/util/envpath.rs:29:11
[INFO] [stderr]    |
[INFO] [stderr] 29 |     match env::home_dir() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `txt`
[INFO] [stderr]  --> src/util/hash.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn hash_utf8(txt: &str) -> u64 {
[INFO] [stderr]   |                  ^^^ help: consider using `_txt` instead
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `bin`
[INFO] [stderr]   --> src/util/hash.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn hash_bin(bin: &Vec<u8>) -> u64 {
[INFO] [stderr]    |                 ^^^ help: consider using `_bin` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `bytes`
[INFO] [stderr]   --> src/util/hash.rs:24:17
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn bytes_to_u64(bytes: &[u8; 8]) -> u64 {
[INFO] [stderr]    |                 ^^^^^ help: consider using `_bytes` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `txt`
[INFO] [stderr]  --> src/util/hash.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn hash_utf8(txt: &str) -> u64 {
[INFO] [stderr]   |                  ^^^ help: consider using `_txt` instead
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `bin`
[INFO] [stderr]   --> src/util/hash.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn hash_bin(bin: &Vec<u8>) -> u64 {
[INFO] [stderr]    |                 ^^^ help: consider using `_bin` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `bytes`
[INFO] [stderr]   --> src/util/hash.rs:24:17
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn bytes_to_u64(bytes: &[u8; 8]) -> u64 {
[INFO] [stderr]    |                 ^^^^^ help: consider using `_bytes` instead
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `dir`
[INFO] [stderr]  --> src/control/database.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 |     dir: PathBuf,
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `config`
[INFO] [stderr]  --> src/control/database.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     config: DBConfig,
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `schema`
[INFO] [stderr]   --> src/control/database.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     schema: Schema,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `users`
[INFO] [stderr]   --> src/control/database.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     users: Vec<User>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `salt`
[INFO] [stderr]  --> src/control/dbconfig.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 |     salt: Vec<u8>,
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `APP_INFO`
[INFO] [stderr]  --> src/util/envpath.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | / const APP_INFO: AppInfo = AppInfo {
[INFO] [stderr] 7 | |     name: "atadb",
[INFO] [stderr] 8 | |     author: "atadb",
[INFO] [stderr] 9 | | };
[INFO] [stderr]   | |__^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `bytes_to_u64`
[INFO] [stderr]   --> src/util/hash.rs:24:1
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn bytes_to_u64(bytes: &[u8; 8]) -> u64 {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `control::dbconfig::DBConfig`
[INFO] [stderr]   --> src/control/dbconfig.rs:8:5
[INFO] [stderr]    |
[INFO] [stderr] 8  | /     pub fn new() -> Self {
[INFO] [stderr] 9  | |         DBConfig { salt: make_salt() }
[INFO] [stderr] 10 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 3  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `dir`
[INFO] [stderr]  --> src/control/database.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 |     dir: PathBuf,
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `config`
[INFO] [stderr]  --> src/control/database.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     config: DBConfig,
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `schema`
[INFO] [stderr]   --> src/control/database.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     schema: Schema,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `users`
[INFO] [stderr]   --> src/control/database.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     users: Vec<User>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `salt`
[INFO] [stderr]  --> src/control/dbconfig.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 |     salt: Vec<u8>,
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `APP_INFO`
[INFO] [stderr]  --> src/util/envpath.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | / const APP_INFO: AppInfo = AppInfo {
[INFO] [stderr] 7 | |     name: "atadb",
[INFO] [stderr] 8 | |     author: "atadb",
[INFO] [stderr] 9 | | };
[INFO] [stderr]   | |__^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `bytes_to_u64`
[INFO] [stderr]   --> src/util/hash.rs:24:1
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn bytes_to_u64(bytes: &[u8; 8]) -> u64 {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `control::dbconfig::DBConfig`
[INFO] [stderr]   --> src/control/dbconfig.rs:8:5
[INFO] [stderr]    |
[INFO] [stderr] 8  | /     pub fn new() -> Self {
[INFO] [stderr] 9  | |         DBConfig { salt: make_salt() }
[INFO] [stderr] 10 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 3  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/util/envpath.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     match env::var_os(ATA_PATH_NAME) {
[INFO] [stderr] 14 | |         Some(value) => {
[INFO] [stderr] 15 | |             for path in env::split_paths(&value) {
[INFO] [stderr] 16 | |                 if !path.exists() {
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         None => (),
[INFO] [stderr] 28 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 |     if let Some(value) = env::var_os(ATA_PATH_NAME) {
[INFO] [stderr] 14 |     for path in env::split_paths(&value) {
[INFO] [stderr] 15 |         if !path.exists() {
[INFO] [stderr] 16 |             paths.push(path);
[INFO] [stderr] 17 |         } else {
[INFO] [stderr] 18 |             warn!(
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/util/envpath.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     match env::home_dir() {
[INFO] [stderr] 30 | |         Some(path) => paths.push(path.join("atadbs")),
[INFO] [stderr] 31 | |         None => (),
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Some(path) = env::home_dir() { paths.push(path.join("atadbs")) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/util/hash.rs:15:22
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn hash_bin(bin: &Vec<u8>) -> u64 {
[INFO] [stderr]    |                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/util/hash.rs:24:24
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn bytes_to_u64(bytes: &[u8; 8]) -> u64 {
[INFO] [stderr]    |                        ^^^^^^^^ help: consider passing by value instead: `[u8; 8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/util/envpath.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     match env::var_os(ATA_PATH_NAME) {
[INFO] [stderr] 14 | |         Some(value) => {
[INFO] [stderr] 15 | |             for path in env::split_paths(&value) {
[INFO] [stderr] 16 | |                 if !path.exists() {
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         None => (),
[INFO] [stderr] 28 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 |     if let Some(value) = env::var_os(ATA_PATH_NAME) {
[INFO] [stderr] 14 |     for path in env::split_paths(&value) {
[INFO] [stderr] 15 |         if !path.exists() {
[INFO] [stderr] 16 |             paths.push(path);
[INFO] [stderr] 17 |         } else {
[INFO] [stderr] 18 |             warn!(
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/util/envpath.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     match env::home_dir() {
[INFO] [stderr] 30 | |         Some(path) => paths.push(path.join("atadbs")),
[INFO] [stderr] 31 | |         None => (),
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Some(path) = env::home_dir() { paths.push(path.join("atadbs")) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/util/hash.rs:15:22
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn hash_bin(bin: &Vec<u8>) -> u64 {
[INFO] [stderr]    |                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/util/hash.rs:24:24
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn bytes_to_u64(bytes: &[u8; 8]) -> u64 {
[INFO] [stderr]    |                        ^^^^^^^^ help: consider passing by value instead: `[u8; 8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `atadb::auth::user::User`
[INFO] [stderr]  --> src/main.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use atadb::auth::user::User;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `atadb::auth::user::User`
[INFO] [stderr]  --> src/main.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use atadb::auth::user::User;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.21s
[INFO] running `"docker" "inspect" "a891be8629e8b1e7cebc679f6a5591b8039b16290e0f5232e21e31ee42fbf2ac"`
[INFO] running `"docker" "rm" "-f" "a891be8629e8b1e7cebc679f6a5591b8039b16290e0f5232e21e31ee42fbf2ac"`
[INFO] [stdout] a891be8629e8b1e7cebc679f6a5591b8039b16290e0f5232e21e31ee42fbf2ac