[INFO] crate async-bincode 0.4.9 is already in cache [INFO] extracting crate async-bincode 0.4.9 into work/ex/clippy-test-run/sources/stable/reg/async-bincode/0.4.9 [INFO] extracting crate async-bincode 0.4.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/async-bincode/0.4.9 [INFO] validating manifest of async-bincode-0.4.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of async-bincode-0.4.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing async-bincode-0.4.9 [INFO] finished frobbing async-bincode-0.4.9 [INFO] frobbed toml for async-bincode-0.4.9 written to work/ex/clippy-test-run/sources/stable/reg/async-bincode/0.4.9/Cargo.toml [INFO] started frobbing async-bincode-0.4.9 [INFO] finished frobbing async-bincode-0.4.9 [INFO] frobbed toml for async-bincode-0.4.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/async-bincode/0.4.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting async-bincode-0.4.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/async-bincode/0.4.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 54d18357262eaa6033b0c2b8d4acb18a87d933e6e235c2377e46c1fa5ff13b09 [INFO] running `"docker" "start" "-a" "54d18357262eaa6033b0c2b8d4acb18a87d933e6e235c2377e46c1fa5ff13b09"` [INFO] [stderr] Checking async-bincode v0.4.9 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader.rs:136:20 [INFO] [stderr] | [INFO] [stderr] 136 | if self.buffer.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/stream.rs:99:10 [INFO] [stderr] | [INFO] [stderr] 99 | ) -> ( [INFO] [stderr] | __________^ [INFO] [stderr] 100 | | AsyncBincodeReader, R>, [INFO] [stderr] 101 | | AsyncBincodeWriter, W, D>, [INFO] [stderr] 102 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:120:25 [INFO] [stderr] | [INFO] [stderr] 120 | let c = c.limit(u32::max_value() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | let c = c.limit(u32::max_value() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader.rs:136:20 [INFO] [stderr] | [INFO] [stderr] 136 | if self.buffer.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/stream.rs:99:10 [INFO] [stderr] | [INFO] [stderr] 99 | ) -> ( [INFO] [stderr] | __________^ [INFO] [stderr] 100 | | AsyncBincodeReader, R>, [INFO] [stderr] 101 | | AsyncBincodeWriter, W, D>, [INFO] [stderr] 102 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:120:25 [INFO] [stderr] | [INFO] [stderr] 120 | let c = c.limit(u32::max_value() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | let c = c.limit(u32::max_value() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.32s [INFO] running `"docker" "inspect" "54d18357262eaa6033b0c2b8d4acb18a87d933e6e235c2377e46c1fa5ff13b09"` [INFO] running `"docker" "rm" "-f" "54d18357262eaa6033b0c2b8d4acb18a87d933e6e235c2377e46c1fa5ff13b09"` [INFO] [stdout] 54d18357262eaa6033b0c2b8d4acb18a87d933e6e235c2377e46c1fa5ff13b09