[INFO] crate assert_snapshot 0.1.3 is already in cache
[INFO] extracting crate assert_snapshot 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/assert_snapshot/0.1.3
[INFO] extracting crate assert_snapshot 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/assert_snapshot/0.1.3
[INFO] validating manifest of assert_snapshot-0.1.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of assert_snapshot-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing assert_snapshot-0.1.3
[INFO] finished frobbing assert_snapshot-0.1.3
[INFO] frobbed toml for assert_snapshot-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/assert_snapshot/0.1.3/Cargo.toml
[INFO] started frobbing assert_snapshot-0.1.3
[INFO] finished frobbing assert_snapshot-0.1.3
[INFO] frobbed toml for assert_snapshot-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/assert_snapshot/0.1.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting assert_snapshot-0.1.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/assert_snapshot/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 312dd49fc14732ef8f0de4380d3d833c4b5875b304ccc36b460805928aae0ff5
[INFO] running `"docker" "start" "-a" "312dd49fc14732ef8f0de4380d3d833c4b5875b304ccc36b460805928aae0ff5"`
[INFO] [stderr]     Checking sorted-json v0.1.0
[INFO] [stderr]     Checking assert_snapshot v0.1.3 (/opt/crater/workdir)
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/assert_snapshot.rs:37:14
[INFO] [stderr]    |
[INFO] [stderr] 37 |     scrubs: &HashMap<String, String>,
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 32 | pub fn assert_snapshot_<T, S: ::std::hash::BuildHasher>(
[INFO] [stderr] 33 |     file: &'static str,
[INFO] [stderr] 34 |     line: u32,
[INFO] [stderr] 35 |     extra: &str,
[INFO] [stderr] 36 |     data: &T,
[INFO] [stderr] 37 |     scrubs: &HashMap<String, String, S>,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:70:34
[INFO] [stderr]    |
[INFO] [stderr] 70 |                     dst.to_str().ok_or(err_msg("PathNotUtf8"))?,
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:71:38
[INFO] [stderr]    |
[INFO] [stderr] 71 |                     dst_tmp.to_str().ok_or(err_msg("PathNotUtf8"))?,
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:78:22
[INFO] [stderr]    |
[INFO] [stderr] 78 |                     .ok_or(err_msg("PathNotUtf8"))?,
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:81:22
[INFO] [stderr]    |
[INFO] [stderr] 81 |                     .ok_or(err_msg("PathNotUtf8"))?
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:86:35
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let parent = dst.parent().ok_or(err_msg("TestFailed"))?;
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("TestFailed"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:88:43
[INFO] [stderr]    |
[INFO] [stderr] 88 |             .args(&["-p", parent.to_str().ok_or(err_msg("PathNotUtf8"))?])
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:99:34
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 dst_tmp.to_str().ok_or(err_msg("PathNotUtf8"))?,
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/assert_snapshot.rs:106:18
[INFO] [stderr]     |
[INFO] [stderr] 106 |                 .ok_or(err_msg("PathNotUtf8"))?,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/assert_snapshot.rs:109:18
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 .ok_or(err_msg("PathNotUtf8"))?
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/function.rs:6:44
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let lines: Vec<String> = content.split("\n").map(|s| s.to_string()).collect();
[INFO] [stderr]   |                                            ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/assert_snapshot.rs:37:14
[INFO] [stderr]    |
[INFO] [stderr] 37 |     scrubs: &HashMap<String, String>,
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 32 | pub fn assert_snapshot_<T, S: ::std::hash::BuildHasher>(
[INFO] [stderr] 33 |     file: &'static str,
[INFO] [stderr] 34 |     line: u32,
[INFO] [stderr] 35 |     extra: &str,
[INFO] [stderr] 36 |     data: &T,
[INFO] [stderr] 37 |     scrubs: &HashMap<String, String, S>,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:70:34
[INFO] [stderr]    |
[INFO] [stderr] 70 |                     dst.to_str().ok_or(err_msg("PathNotUtf8"))?,
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:71:38
[INFO] [stderr]    |
[INFO] [stderr] 71 |                     dst_tmp.to_str().ok_or(err_msg("PathNotUtf8"))?,
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:78:22
[INFO] [stderr]    |
[INFO] [stderr] 78 |                     .ok_or(err_msg("PathNotUtf8"))?,
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:81:22
[INFO] [stderr]    |
[INFO] [stderr] 81 |                     .ok_or(err_msg("PathNotUtf8"))?
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:86:35
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let parent = dst.parent().ok_or(err_msg("TestFailed"))?;
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("TestFailed"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:88:43
[INFO] [stderr]    |
[INFO] [stderr] 88 |             .args(&["-p", parent.to_str().ok_or(err_msg("PathNotUtf8"))?])
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/assert_snapshot.rs:99:34
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 dst_tmp.to_str().ok_or(err_msg("PathNotUtf8"))?,
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/assert_snapshot.rs:106:18
[INFO] [stderr]     |
[INFO] [stderr] 106 |                 .ok_or(err_msg("PathNotUtf8"))?,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/assert_snapshot.rs:109:18
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 .ok_or(err_msg("PathNotUtf8"))?
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("PathNotUtf8"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/function.rs:6:44
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let lines: Vec<String> = content.split("\n").map(|s| s.to_string()).collect();
[INFO] [stderr]   |                                            ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.31s
[INFO] running `"docker" "inspect" "312dd49fc14732ef8f0de4380d3d833c4b5875b304ccc36b460805928aae0ff5"`
[INFO] running `"docker" "rm" "-f" "312dd49fc14732ef8f0de4380d3d833c4b5875b304ccc36b460805928aae0ff5"`
[INFO] [stdout] 312dd49fc14732ef8f0de4380d3d833c4b5875b304ccc36b460805928aae0ff5