[INFO] crate assert-json-diff 0.2.1 is already in cache [INFO] extracting crate assert-json-diff 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/assert-json-diff/0.2.1 [INFO] extracting crate assert-json-diff 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/assert-json-diff/0.2.1 [INFO] validating manifest of assert-json-diff-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of assert-json-diff-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing assert-json-diff-0.2.1 [INFO] finished frobbing assert-json-diff-0.2.1 [INFO] frobbed toml for assert-json-diff-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/assert-json-diff/0.2.1/Cargo.toml [INFO] started frobbing assert-json-diff-0.2.1 [INFO] finished frobbing assert-json-diff-0.2.1 [INFO] frobbed toml for assert-json-diff-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/assert-json-diff/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting assert-json-diff-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/assert-json-diff/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7488cf69d093ec23beb00c634e80445b7a260d2382f201e09e297102389ae3ed [INFO] running `"docker" "start" "-a" "7488cf69d093ec23beb00c634e80445b7a260d2382f201e09e297102389ae3ed"` [INFO] [stderr] Checking assert-json-diff v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:351:12 [INFO] [stderr] | [INFO] [stderr] 351 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 352 | | if expected.0 != actual.0 { [INFO] [stderr] 353 | | errors.push(ErrorType::NotEq( [INFO] [stderr] 354 | | Either::Left((actual.clone(), expected.clone())), [INFO] [stderr] ... | [INFO] [stderr] 357 | | } [INFO] [stderr] 358 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 351 | } else if expected.0 != actual.0 { [INFO] [stderr] 352 | errors.push(ErrorType::NotEq( [INFO] [stderr] 353 | Either::Left((actual.clone(), expected.clone())), [INFO] [stderr] 354 | path, [INFO] [stderr] 355 | )); [INFO] [stderr] 356 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:415:12 [INFO] [stderr] | [INFO] [stderr] 415 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 416 | | if lhs != rhs { [INFO] [stderr] 417 | | errors.push(ErrorType::NotEq( [INFO] [stderr] 418 | | Either::Right((lhs.clone(), rhs.clone())), [INFO] [stderr] ... | [INFO] [stderr] 421 | | } [INFO] [stderr] 422 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 415 | } else if lhs != rhs { [INFO] [stderr] 416 | errors.push(ErrorType::NotEq( [INFO] [stderr] 417 | Either::Right((lhs.clone(), rhs.clone())), [INFO] [stderr] 418 | path, [INFO] [stderr] 419 | )); [INFO] [stderr] 420 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:351:12 [INFO] [stderr] | [INFO] [stderr] 351 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 352 | | if expected.0 != actual.0 { [INFO] [stderr] 353 | | errors.push(ErrorType::NotEq( [INFO] [stderr] 354 | | Either::Left((actual.clone(), expected.clone())), [INFO] [stderr] ... | [INFO] [stderr] 357 | | } [INFO] [stderr] 358 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 351 | } else if expected.0 != actual.0 { [INFO] [stderr] 352 | errors.push(ErrorType::NotEq( [INFO] [stderr] 353 | Either::Left((actual.clone(), expected.clone())), [INFO] [stderr] 354 | path, [INFO] [stderr] 355 | )); [INFO] [stderr] 356 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:415:12 [INFO] [stderr] | [INFO] [stderr] 415 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 416 | | if lhs != rhs { [INFO] [stderr] 417 | | errors.push(ErrorType::NotEq( [INFO] [stderr] 418 | | Either::Right((lhs.clone(), rhs.clone())), [INFO] [stderr] ... | [INFO] [stderr] 421 | | } [INFO] [stderr] 422 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 415 | } else if lhs != rhs { [INFO] [stderr] 416 | errors.push(ErrorType::NotEq( [INFO] [stderr] 417 | Either::Right((lhs.clone(), rhs.clone())), [INFO] [stderr] 418 | path, [INFO] [stderr] 419 | )); [INFO] [stderr] 420 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an exclusive range would be more readable [INFO] [stderr] --> src/core_ext.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | (0..=self.len() - 1).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..self.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_minus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_minus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:408:20 [INFO] [stderr] | [INFO] [stderr] 408 | let keys = lhs_keys [INFO] [stderr] | ____________________^ [INFO] [stderr] 409 | | .iter() [INFO] [stderr] 410 | | .chain(rhs_keys.iter()) [INFO] [stderr] 411 | | .map(|s| s.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 408 | let keys = lhs_keys [INFO] [stderr] 409 | .iter() [INFO] [stderr] 410 | .chain(rhs_keys.iter()).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:411:22 [INFO] [stderr] | [INFO] [stderr] 411 | .map(|s| s.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:441:21 [INFO] [stderr] | [INFO] [stderr] 441 | lhs.clone().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `lhs.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:442:21 [INFO] [stderr] | [INFO] [stderr] 442 | rhs.clone().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `rhs.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:484:30 [INFO] [stderr] | [INFO] [stderr] 484 | <[Value]>::get(self, index.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:500:28 [INFO] [stderr] | [INFO] [stderr] 500 | ::get(self, index.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:567:36 [INFO] [stderr] | [INFO] [stderr] 567 | let comp = PathComp::Index(next.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:598:18 [INFO] [stderr] | [INFO] [stderr] 598 | fn to_output(self) -> Result<(), String> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: an exclusive range would be more readable [INFO] [stderr] --> src/core_ext.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | (0..=self.len() - 1).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..self.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_minus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_minus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:408:20 [INFO] [stderr] | [INFO] [stderr] 408 | let keys = lhs_keys [INFO] [stderr] | ____________________^ [INFO] [stderr] 409 | | .iter() [INFO] [stderr] 410 | | .chain(rhs_keys.iter()) [INFO] [stderr] 411 | | .map(|s| s.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 408 | let keys = lhs_keys [INFO] [stderr] 409 | .iter() [INFO] [stderr] 410 | .chain(rhs_keys.iter()).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:411:22 [INFO] [stderr] | [INFO] [stderr] 411 | .map(|s| s.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:441:21 [INFO] [stderr] | [INFO] [stderr] 441 | lhs.clone().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `lhs.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:442:21 [INFO] [stderr] | [INFO] [stderr] 442 | rhs.clone().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `rhs.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:484:30 [INFO] [stderr] | [INFO] [stderr] 484 | <[Value]>::get(self, index.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:500:28 [INFO] [stderr] | [INFO] [stderr] 500 | ::get(self, index.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:567:36 [INFO] [stderr] | [INFO] [stderr] 567 | let comp = PathComp::Index(next.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:598:18 [INFO] [stderr] | [INFO] [stderr] 598 | fn to_output(self) -> Result<(), String> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/lib.rs:667:5 [INFO] [stderr] | [INFO] [stderr] 667 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.92s [INFO] running `"docker" "inspect" "7488cf69d093ec23beb00c634e80445b7a260d2382f201e09e297102389ae3ed"` [INFO] running `"docker" "rm" "-f" "7488cf69d093ec23beb00c634e80445b7a260d2382f201e09e297102389ae3ed"` [INFO] [stdout] 7488cf69d093ec23beb00c634e80445b7a260d2382f201e09e297102389ae3ed