[INFO] crate asnom 0.1.0 is already in cache [INFO] extracting crate asnom 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/asnom/0.1.0 [INFO] extracting crate asnom 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/asnom/0.1.0 [INFO] validating manifest of asnom-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asnom-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asnom-0.1.0 [INFO] finished frobbing asnom-0.1.0 [INFO] frobbed toml for asnom-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/asnom/0.1.0/Cargo.toml [INFO] started frobbing asnom-0.1.0 [INFO] finished frobbing asnom-0.1.0 [INFO] frobbed toml for asnom-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/asnom/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asnom-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/asnom/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 191a16fa6c871bc0f82590b5837ce00d892445bb7ebb3f61dec73508b266e823 [INFO] running `"docker" "start" "-a" "191a16fa6c871bc0f82590b5837ce00d892445bb7ebb3f61dec73508b266e823"` [INFO] [stderr] Checking asnom v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `TagStructure` [INFO] [stderr] --> src/parse.rs:118:28 [INFO] [stderr] | [INFO] [stderr] 118 | use common::{TagClass, TagStructure}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/write.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::string` [INFO] [stderr] --> src/write.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | use std::string; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BigEndian`, `WriteBytesExt` [INFO] [stderr] --> src/write.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | use byteorder::{BigEndian, WriteBytesExt}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TagStructure` [INFO] [stderr] --> src/structure.rs:53:28 [INFO] [stderr] | [INFO] [stderr] 53 | use common::{TagClass, TagStructure}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/write.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn write_type(mut w: &mut Write, class: TagClass, structure: TagStructure, id: u64) { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/write.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn write_length(mut w: &mut Write, length: usize) { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_structure` [INFO] [stderr] --> src/structures/sequence.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | fn into_structure(self) -> structure::StructureTag { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parse.rs:69:36 [INFO] [stderr] | [INFO] [stderr] 69 | 1 => nom::be_u8(i).map(|x| x as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parse.rs:70:37 [INFO] [stderr] | [INFO] [stderr] 70 | 2 => nom::be_u16(i).map(|x| x as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parse.rs:71:37 [INFO] [stderr] | [INFO] [stderr] 71 | 3 => nom::be_u32(i).map(|x| x as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/structures/integer.rs:20:69 [INFO] [stderr] | [INFO] [stderr] 20 | let mut rem: i64 = if self.inner >= 0 { self.inner } else { self.inner * -1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/write.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn write_type(mut w: &mut Write, class: TagClass, structure: TagStructure, id: u64) { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/write.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn write_length(mut w: &mut Write, length: usize) { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_structure` [INFO] [stderr] --> src/structures/sequence.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | fn into_structure(self) -> structure::StructureTag { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parse.rs:69:36 [INFO] [stderr] | [INFO] [stderr] 69 | 1 => nom::be_u8(i).map(|x| x as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parse.rs:70:37 [INFO] [stderr] | [INFO] [stderr] 70 | 2 => nom::be_u16(i).map(|x| x as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parse.rs:71:37 [INFO] [stderr] | [INFO] [stderr] 71 | 3 => nom::be_u32(i).map(|x| x as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/write.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | super::encode_into(&mut buf, tag.into_structure()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/write.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | super::encode_into(&mut buf, tag.into_structure()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/write.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | super::encode_into(&mut buf, tag.into_structure()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/structures/integer.rs:20:69 [INFO] [stderr] | [INFO] [stderr] 20 | let mut rem: i64 = if self.inner >= 0 { self.inner } else { self.inner * -1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.52s [INFO] running `"docker" "inspect" "191a16fa6c871bc0f82590b5837ce00d892445bb7ebb3f61dec73508b266e823"` [INFO] running `"docker" "rm" "-f" "191a16fa6c871bc0f82590b5837ce00d892445bb7ebb3f61dec73508b266e823"` [INFO] [stdout] 191a16fa6c871bc0f82590b5837ce00d892445bb7ebb3f61dec73508b266e823