[INFO] crate asn1_der 0.6.0 is already in cache [INFO] extracting crate asn1_der 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/asn1_der/0.6.0 [INFO] extracting crate asn1_der 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/asn1_der/0.6.0 [INFO] validating manifest of asn1_der-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asn1_der-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asn1_der-0.6.0 [INFO] finished frobbing asn1_der-0.6.0 [INFO] frobbed toml for asn1_der-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/asn1_der/0.6.0/Cargo.toml [INFO] started frobbing asn1_der-0.6.0 [INFO] finished frobbing asn1_der-0.6.0 [INFO] frobbed toml for asn1_der-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/asn1_der/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asn1_der-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/asn1_der/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14bcdf5a6bebcca76fb75dd99af9604c7a41be1a457f6b279b42c5a0e4a8db7f [INFO] running `"docker" "start" "-a" "14bcdf5a6bebcca76fb75dd99af9604c7a41be1a457f6b279b42c5a0e4a8db7f"` [INFO] [stderr] Compiling asn1_der_derive v0.1.1 [INFO] [stderr] Checking asn1_der v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/boolean.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | _ => return Err(Asn1DerError::InvalidEncoding) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Asn1DerError::InvalidEncoding)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/boolean.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | _ => return Err(Asn1DerError::InvalidEncoding) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Asn1DerError::InvalidEncoding)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/der/tag.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn serialized_len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/der/tag.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn serialize<'a>(&self, mut buf: impl Iterator) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/der/length.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn serialized_len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/der/length.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn serialize<'a>(&self, mut buf: impl Iterator) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/boolean.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | match der_object.value.data.as_slice() { [INFO] [stderr] | _________^ [INFO] [stderr] 9 | | &[0x00u8] => Ok(false), [INFO] [stderr] 10 | | &[0xffu8] => Ok(true), [INFO] [stderr] 11 | | _ => return Err(Asn1DerError::InvalidEncoding) [INFO] [stderr] 12 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 8 | match *der_object.value.data.as_slice() { [INFO] [stderr] 9 | [0x00u8] => Ok(false), [INFO] [stderr] 10 | [0xffu8] => Ok(true), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/types/boolean.rs:17:35 [INFO] [stderr] | [INFO] [stderr] 17 | DerObject::new(DerTag::Boolean, match self { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 18 | | true => vec![0xffu8], [INFO] [stderr] 19 | | false => vec![0x00u8] [INFO] [stderr] 20 | | }.into()) [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self { vec![0xffu8] } else { vec![0x00u8] }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/types/integer.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | if self > $uint::max_value() as u128 { Err(Asn1DerError::Unsupported) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from($uint::max_value())` [INFO] [stderr] ... [INFO] [stderr] 28 | impl_conv!(impl: u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u128 may become silently lossy if types change [INFO] [stderr] --> src/types/integer.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | if self > $uint::max_value() as u128 { Err(Asn1DerError::Unsupported) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from($uint::max_value())` [INFO] [stderr] ... [INFO] [stderr] 29 | impl_conv!(impl: u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u128 may become silently lossy if types change [INFO] [stderr] --> src/types/integer.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | if self > $uint::max_value() as u128 { Err(Asn1DerError::Unsupported) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from($uint::max_value())` [INFO] [stderr] ... [INFO] [stderr] 30 | impl_conv!(impl: u16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change [INFO] [stderr] --> src/types/integer.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | if self > $uint::max_value() as u128 { Err(Asn1DerError::Unsupported) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from($uint::max_value())` [INFO] [stderr] ... [INFO] [stderr] 31 | impl_conv!(impl: u8); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/types/integer.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | while let Some(b) = data.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for b in data { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change [INFO] [stderr] --> src/types/integer.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | value += (*b as u128) << (shl * 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u128::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/der/tag.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn serialized_len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/der/tag.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn serialize<'a>(&self, mut buf: impl Iterator) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/der/length.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn serialized_len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/der/length.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn serialize<'a>(&self, mut buf: impl Iterator) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/boolean.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | match der_object.value.data.as_slice() { [INFO] [stderr] | _________^ [INFO] [stderr] 9 | | &[0x00u8] => Ok(false), [INFO] [stderr] 10 | | &[0xffu8] => Ok(true), [INFO] [stderr] 11 | | _ => return Err(Asn1DerError::InvalidEncoding) [INFO] [stderr] 12 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 8 | match *der_object.value.data.as_slice() { [INFO] [stderr] 9 | [0x00u8] => Ok(false), [INFO] [stderr] 10 | [0xffu8] => Ok(true), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/types/boolean.rs:17:35 [INFO] [stderr] | [INFO] [stderr] 17 | DerObject::new(DerTag::Boolean, match self { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 18 | | true => vec![0xffu8], [INFO] [stderr] 19 | | false => vec![0x00u8] [INFO] [stderr] 20 | | }.into()) [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self { vec![0xffu8] } else { vec![0x00u8] }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/types/integer.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | if self > $uint::max_value() as u128 { Err(Asn1DerError::Unsupported) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from($uint::max_value())` [INFO] [stderr] ... [INFO] [stderr] 28 | impl_conv!(impl: u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u128 may become silently lossy if types change [INFO] [stderr] --> src/types/integer.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | if self > $uint::max_value() as u128 { Err(Asn1DerError::Unsupported) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from($uint::max_value())` [INFO] [stderr] ... [INFO] [stderr] 29 | impl_conv!(impl: u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u128 may become silently lossy if types change [INFO] [stderr] --> src/types/integer.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | if self > $uint::max_value() as u128 { Err(Asn1DerError::Unsupported) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from($uint::max_value())` [INFO] [stderr] ... [INFO] [stderr] 30 | impl_conv!(impl: u16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change [INFO] [stderr] --> src/types/integer.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | if self > $uint::max_value() as u128 { Err(Asn1DerError::Unsupported) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from($uint::max_value())` [INFO] [stderr] ... [INFO] [stderr] 31 | impl_conv!(impl: u8); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/types/integer.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | while let Some(b) = data.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for b in data { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change [INFO] [stderr] --> src/types/integer.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | value += (*b as u128) << (shl * 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u128::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/types_boolean.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | assert_eq!(*boolean, deserialized.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `deserialized` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/types_integer.rs:31:42 [INFO] [stderr] | [INFO] [stderr] 31 | (b"\x02\x04\x7f\xf7\xd3\x17".as_ref(), 2146947863), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_146_947_863` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/types_integer.rs:32:46 [INFO] [stderr] | [INFO] [stderr] 32 | (b"\x02\x05\x00\x80\xa5\x4c\x7f".as_ref(), 2158316671), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_158_316_671` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/types_integer.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | (b"\x02\x05\x00\xff\xff\xff\xff".as_ref(), 4294967295), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/types_integer.rs:35:58 [INFO] [stderr] | [INFO] [stderr] 35 | (b"\x02\x08\x7f\xf7\xd3\x17\xce\xf1\xa7\x26".as_ref(), 9221070861274031910), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_221_070_861_274_031_910` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/types_integer.rs:36:62 [INFO] [stderr] | [INFO] [stderr] 36 | (b"\x02\x09\x00\x80\xa5\x4c\x7f\xe5\x0d\x84\xa0".as_ref(), 9269899520199460000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_269_899_520_199_460_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/types_integer.rs:37:62 [INFO] [stderr] | [INFO] [stderr] 37 | (b"\x02\x09\x00\xff\xff\xff\xff\xff\xff\xff\xff".as_ref(), 18446744073709551615), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/types_integer.rs:39:90 [INFO] [stderr] | [INFO] [stderr] 39 | (b"\x02\x10\x7f\xc8\xa3\xa5\x32\x49\xcc\xf2\x73\xb3\xe9\x4d\xe1\xb6\x33\x61".as_ref(), 169853733957366961371495358725388383073), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `169_853_733_957_366_961_371_495_358_725_388_383_073` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/types_integer.rs:40:94 [INFO] [stderr] | [INFO] [stderr] 40 | (b"\x02\x11\x00\x80\xc8\xa3\xa5\x32\x49\xcc\xf2\x73\xb3\xe9\x4d\xe1\xb6\x33\x61".as_ref(), 171182961953151877244399165785668727649), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `171_182_961_953_151_877_244_399_165_785_668_727_649` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/types_integer.rs:41:94 [INFO] [stderr] | [INFO] [stderr] 41 | (b"\x02\x11\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff".as_ref(), 340282366920938463463374607431768211455) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `340_282_366_920_938_463_463_374_607_431_768_211_455` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/types_integer.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | assert_eq!(*boolean, deserialized.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `deserialized` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let deserialized =` [INFO] [stderr] --> tests/types_null.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | let deserialized: () = <()>::deserialize(bytes.iter()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/types_null.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | assert_eq!(deserialized.serialized_len(), bytes.len()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 12 | assert_eq!(().serialized_len(), bytes.len()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/types_null.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | deserialized.serialize(target.iter_mut()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 16 | ().serialize(target.iter_mut()).unwrap(); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.76s [INFO] running `"docker" "inspect" "14bcdf5a6bebcca76fb75dd99af9604c7a41be1a457f6b279b42c5a0e4a8db7f"` [INFO] running `"docker" "rm" "-f" "14bcdf5a6bebcca76fb75dd99af9604c7a41be1a457f6b279b42c5a0e4a8db7f"` [INFO] [stdout] 14bcdf5a6bebcca76fb75dd99af9604c7a41be1a457f6b279b42c5a0e4a8db7f