[INFO] crate asmuth_bloom_secret_sharing 0.2.2 is already in cache [INFO] extracting crate asmuth_bloom_secret_sharing 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/asmuth_bloom_secret_sharing/0.2.2 [INFO] extracting crate asmuth_bloom_secret_sharing 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/asmuth_bloom_secret_sharing/0.2.2 [INFO] validating manifest of asmuth_bloom_secret_sharing-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asmuth_bloom_secret_sharing-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asmuth_bloom_secret_sharing-0.2.2 [INFO] finished frobbing asmuth_bloom_secret_sharing-0.2.2 [INFO] frobbed toml for asmuth_bloom_secret_sharing-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/asmuth_bloom_secret_sharing/0.2.2/Cargo.toml [INFO] started frobbing asmuth_bloom_secret_sharing-0.2.2 [INFO] finished frobbing asmuth_bloom_secret_sharing-0.2.2 [INFO] frobbed toml for asmuth_bloom_secret_sharing-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/asmuth_bloom_secret_sharing/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asmuth_bloom_secret_sharing-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/asmuth_bloom_secret_sharing/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f26f4a70199f1bf9c482aa5e6fdeaa6e4b81e7bef72d286288a4139d69beac2a [INFO] running `"docker" "start" "-a" "f26f4a70199f1bf9c482aa5e6fdeaa6e4b81e7bef72d286288a4139d69beac2a"` [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Compiling git2 v0.6.11 [INFO] [stderr] Compiling built v0.2.3 [INFO] [stderr] Compiling asmuth_bloom_secret_sharing v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let a = rng.gen_biguint_range(&two, &n1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ops.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | let mut x = modular_pow(&a,&d,n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let a = rng.gen_biguint_range(&two, &n1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ops.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | let mut x = modular_pow(&a,&d,n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 135 | | if n0_tmp != *n0.as_ref().unwrap() { [INFO] [stderr] 136 | | return Err(Error::N0NotSameInAllShares) [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 134 | } else if n0_tmp != *n0.as_ref().unwrap() { [INFO] [stderr] 135 | return Err(Error::N0NotSameInAllShares) [INFO] [stderr] 136 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | return low < high; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low < high` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 135 | | if n0_tmp != *n0.as_ref().unwrap() { [INFO] [stderr] 136 | | return Err(Error::N0NotSameInAllShares) [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 134 | } else if n0_tmp != *n0.as_ref().unwrap() { [INFO] [stderr] 135 | return Err(Error::N0NotSameInAllShares) [INFO] [stderr] 136 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | return low < high; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low < high` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lib.rs:311:20 [INFO] [stderr] | [INFO] [stderr] 311 | assert_eq!((&share).shares.len(), 5); [INFO] [stderr] | ^^^^^^^^ help: try this: `share.shares` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lib.rs:329:20 [INFO] [stderr] | [INFO] [stderr] 329 | assert_eq!((&share).shares.len(), 7); [INFO] [stderr] | ^^^^^^^^ help: try this: `share.shares` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:379:44 [INFO] [stderr] | [INFO] [stderr] 379 | let gen = BigPrimesGenerator::new(&961748940.to_biguint().unwrap(), 1e-9); [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_748_940` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:382:23 [INFO] [stderr] | [INFO] [stderr] 382 | let v = vec![ 961748941, 961748947, 961748951, 961748969, 961748987, 961748993, 961749023, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_748_941` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:382:34 [INFO] [stderr] | [INFO] [stderr] 382 | let v = vec![ 961748941, 961748947, 961748951, 961748969, 961748987, 961748993, 961749023, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_748_947` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:382:45 [INFO] [stderr] | [INFO] [stderr] 382 | let v = vec![ 961748941, 961748947, 961748951, 961748969, 961748987, 961748993, 961749023, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_748_951` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:382:56 [INFO] [stderr] | [INFO] [stderr] 382 | let v = vec![ 961748941, 961748947, 961748951, 961748969, 961748987, 961748993, 961749023, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_748_969` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:382:67 [INFO] [stderr] | [INFO] [stderr] 382 | let v = vec![ 961748941, 961748947, 961748951, 961748969, 961748987, 961748993, 961749023, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_748_987` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:382:78 [INFO] [stderr] | [INFO] [stderr] 382 | let v = vec![ 961748941, 961748947, 961748951, 961748969, 961748987, 961748993, 961749023, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_748_993` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:382:89 [INFO] [stderr] | [INFO] [stderr] 382 | let v = vec![ 961748941, 961748947, 961748951, 961748969, 961748987, 961748993, 961749023, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_749_023` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:383:9 [INFO] [stderr] | [INFO] [stderr] 383 | 961749037, 961749043, 961749067, 961749079, 961749091, 961749097, 961749101, 961749121, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_749_037` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:383:20 [INFO] [stderr] | [INFO] [stderr] 383 | 961749037, 961749043, 961749067, 961749079, 961749091, 961749097, 961749101, 961749121, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_749_043` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:383:31 [INFO] [stderr] | [INFO] [stderr] 383 | 961749037, 961749043, 961749067, 961749079, 961749091, 961749097, 961749101, 961749121, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_749_067` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:383:42 [INFO] [stderr] | [INFO] [stderr] 383 | 961749037, 961749043, 961749067, 961749079, 961749091, 961749097, 961749101, 961749121, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_749_079` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:383:53 [INFO] [stderr] | [INFO] [stderr] 383 | 961749037, 961749043, 961749067, 961749079, 961749091, 961749097, 961749101, 961749121, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_749_091` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:383:64 [INFO] [stderr] | [INFO] [stderr] 383 | 961749037, 961749043, 961749067, 961749079, 961749091, 961749097, 961749101, 961749121, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_749_097` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:383:75 [INFO] [stderr] | [INFO] [stderr] 383 | 961749037, 961749043, 961749067, 961749079, 961749091, 961749097, 961749101, 961749121, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_749_101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:383:86 [INFO] [stderr] | [INFO] [stderr] 383 | 961749037, 961749043, 961749067, 961749079, 961749091, 961749097, 961749101, 961749121, [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_749_121` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | 961749157, ]; [INFO] [stderr] | ^^^^^^^^^ help: consider: `961_749_157` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | r = r + one; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `r += one` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | d = d / two; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `d /= two` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | count= count - one; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `count -= one` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | e = e >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `e >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | acc= acc * &base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `acc *= &base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | e = e / 2.to_biguint().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `e /= 2.to_biguint().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | acc = acc * base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `acc *= base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/zero_rle.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | assert!(n.len() > 0 && n.len() <= 2); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!n.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/zero_rle.rs:55:31 [INFO] [stderr] | [INFO] [stderr] 55 | Some(mut s) => if s.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:121:44 [INFO] [stderr] | [INFO] [stderr] 121 | let parts: Vec<_> = line.split(":").take(3).map(|s| s.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:161:38 [INFO] [stderr] | [INFO] [stderr] 161 | fn test_primes(n0: &BigUint, primes: &Vec, k: u16) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[BigUint]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `c`. [INFO] [stderr] --> src/lib.rs:270:14 [INFO] [stderr] | [INFO] [stderr] 270 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 270 | for in c.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | r = r + one; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `r += one` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | d = d / two; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `d /= two` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | count= count - one; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `count -= one` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | e = e >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `e >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | acc= acc * &base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `acc *= &base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | e = e / 2.to_biguint().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `e /= 2.to_biguint().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | acc = acc * base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `acc *= base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/zero_rle.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | assert!(n.len() > 0 && n.len() <= 2); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!n.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/zero_rle.rs:55:31 [INFO] [stderr] | [INFO] [stderr] 55 | Some(mut s) => if s.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:121:44 [INFO] [stderr] | [INFO] [stderr] 121 | let parts: Vec<_> = line.split(":").take(3).map(|s| s.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:161:38 [INFO] [stderr] | [INFO] [stderr] 161 | fn test_primes(n0: &BigUint, primes: &Vec, k: u16) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[BigUint]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `c`. [INFO] [stderr] --> src/lib.rs:270:14 [INFO] [stderr] | [INFO] [stderr] 270 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 270 | for in c.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | pub const PKG_VERSION: &'static str = "0.2.2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | pub const PKG_VERSION_MAJOR: &'static str = "0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:11:31 [INFO] [stderr] | [INFO] [stderr] 11 | pub const PKG_VERSION_MINOR: &'static str = "2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub const PKG_VERSION_PATCH: &'static str = "2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | pub const PKG_VERSION_PRE: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | pub const PKG_AUTHORS: &'static str = "Ivan Zderadicka "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | pub const PKG_NAME: &'static str = "asmuth_bloom_secret_sharing"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | pub const PKG_DESCRIPTION: &'static str = "Asmuth Bloom secret sharing algorithm based on Chinese Reminder Theorem"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | pub const PKG_HOMEPAGE: &'static str = "https://github.com/izderadicka/asmuth_bloom_secret_sharing"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | pub const TARGET: &'static str = "x86_64-unknown-linux-gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | pub const HOST: &'static str = "x86_64-unknown-linux-gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | pub const PROFILE: &'static str = "debug"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | pub const RUSTC: &'static str = "rustc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | pub const RUSTDOC: &'static str = "rustdoc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | pub const FEATURES: [&'static str; 0] = []; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | pub const FEATURES_STR: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | pub const RUSTC_VERSION: &'static str = "rustc 1.32.0 (9fda7c223 2019-01-16)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | pub const RUSTDOC_VERSION: &'static str = "rustdoc 1.32.0 (9fda7c223 2019-01-16)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | pub const BUILT_TIME_UTC: &'static str = "Tue, 29 Jan 2019 18:08:56 GMT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | pub const CFG_TARGET_ARCH: &'static str = "x86_64"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | pub const CFG_ENDIAN: &'static str = "little"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | pub const CFG_ENV: &'static str = "gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | pub const CFG_FAMILY: &'static str = "unix"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | pub const CFG_OS: &'static str = "linux"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:63:31 [INFO] [stderr] | [INFO] [stderr] 63 | pub const CFG_POINTER_WIDTH: &'static str = "64"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | pub const PKG_VERSION: &'static str = "0.2.2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | pub const PKG_VERSION_MAJOR: &'static str = "0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:11:31 [INFO] [stderr] | [INFO] [stderr] 11 | pub const PKG_VERSION_MINOR: &'static str = "2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub const PKG_VERSION_PATCH: &'static str = "2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | pub const PKG_VERSION_PRE: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | pub const PKG_AUTHORS: &'static str = "Ivan Zderadicka "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | pub const PKG_NAME: &'static str = "asmuth_bloom_secret_sharing"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | pub const PKG_DESCRIPTION: &'static str = "Asmuth Bloom secret sharing algorithm based on Chinese Reminder Theorem"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | pub const PKG_HOMEPAGE: &'static str = "https://github.com/izderadicka/asmuth_bloom_secret_sharing"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | pub const TARGET: &'static str = "x86_64-unknown-linux-gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | pub const HOST: &'static str = "x86_64-unknown-linux-gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | pub const PROFILE: &'static str = "debug"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | pub const RUSTC: &'static str = "rustc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | pub const RUSTDOC: &'static str = "rustdoc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | pub const FEATURES: [&'static str; 0] = []; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | pub const FEATURES_STR: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | pub const RUSTC_VERSION: &'static str = "rustc 1.32.0 (9fda7c223 2019-01-16)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | pub const RUSTDOC_VERSION: &'static str = "rustdoc 1.32.0 (9fda7c223 2019-01-16)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | pub const BUILT_TIME_UTC: &'static str = "Tue, 29 Jan 2019 18:08:56 GMT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | pub const CFG_TARGET_ARCH: &'static str = "x86_64"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | pub const CFG_ENDIAN: &'static str = "little"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | pub const CFG_ENV: &'static str = "gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | pub const CFG_FAMILY: &'static str = "unix"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | pub const CFG_OS: &'static str = "linux"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/asmuth_bloom_secret_sharing-de2f987a12bcd436/out/built.rs:63:31 [INFO] [stderr] | [INFO] [stderr] 63 | pub const CFG_POINTER_WIDTH: &'static str = "64"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | if secret.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `secret.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match e.cause() { [INFO] [stderr] 95 | | Some(err) => println!("Caused by {}", err ), [INFO] [stderr] 96 | | None => () [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(err) = e.cause() { println!("Caused by {}", err ) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | if secret.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `secret.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match e.cause() { [INFO] [stderr] 95 | | Some(err) => println!("Caused by {}", err ), [INFO] [stderr] 96 | | None => () [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(err) = e.cause() { println!("Caused by {}", err ) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.94s [INFO] running `"docker" "inspect" "f26f4a70199f1bf9c482aa5e6fdeaa6e4b81e7bef72d286288a4139d69beac2a"` [INFO] running `"docker" "rm" "-f" "f26f4a70199f1bf9c482aa5e6fdeaa6e4b81e7bef72d286288a4139d69beac2a"` [INFO] [stdout] f26f4a70199f1bf9c482aa5e6fdeaa6e4b81e7bef72d286288a4139d69beac2a