[INFO] crate askama_derive 0.7.2 is already in cache [INFO] extracting crate askama_derive 0.7.2 into work/ex/clippy-test-run/sources/stable/reg/askama_derive/0.7.2 [INFO] extracting crate askama_derive 0.7.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/askama_derive/0.7.2 [INFO] validating manifest of askama_derive-0.7.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of askama_derive-0.7.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing askama_derive-0.7.2 [INFO] finished frobbing askama_derive-0.7.2 [INFO] frobbed toml for askama_derive-0.7.2 written to work/ex/clippy-test-run/sources/stable/reg/askama_derive/0.7.2/Cargo.toml [INFO] started frobbing askama_derive-0.7.2 [INFO] finished frobbing askama_derive-0.7.2 [INFO] frobbed toml for askama_derive-0.7.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/askama_derive/0.7.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting askama_derive-0.7.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/askama_derive/0.7.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e215634e2cb5ffe7b3d5e92ffff2b960177edfb275e9622b8ab6d44f4997d0be [INFO] running `"docker" "start" "-a" "e215634e2cb5ffe7b3d5e92ffff2b960177edfb275e9622b8ab6d44f4997d0be"` [INFO] [stderr] Checking askama_shared v0.7.2 [INFO] [stderr] Checking askama_derive v0.7.2 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/parser.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/parser.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/generator.rs:337:5 [INFO] [stderr] | [INFO] [stderr] 337 | / fn write_match( [INFO] [stderr] 338 | | &mut self, [INFO] [stderr] 339 | | ctx: &'a Context, [INFO] [stderr] 340 | | buf: &mut Buffer, [INFO] [stderr] ... | [INFO] [stderr] 386 | | self.handle_ws(buf, ws2); [INFO] [stderr] 387 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/generator.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | / fn write_loop( [INFO] [stderr] 390 | | &mut self, [INFO] [stderr] 391 | | ctx: &'a Context, [INFO] [stderr] 392 | | buf: &mut Buffer, [INFO] [stderr] ... | [INFO] [stderr] 417 | | self.locals.pop(); [INFO] [stderr] 418 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/input.rs:135:16 [INFO] [stderr] | [INFO] [stderr] 135 | || config.syntaxes.get(config.default_syntax).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.syntaxes[config.default_syntax]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/input.rs:140:22 [INFO] [stderr] | [INFO] [stderr] 140 | .expect(&format!("attribute syntax {} not exist", s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("attribute syntax {} not exist", s))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser.rs:106:30 [INFO] [stderr] | [INFO] [stderr] 106 | (&s[..start], &s[start..end + 1], &s[end + 1..]) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/generator.rs:337:5 [INFO] [stderr] | [INFO] [stderr] 337 | / fn write_match( [INFO] [stderr] 338 | | &mut self, [INFO] [stderr] 339 | | ctx: &'a Context, [INFO] [stderr] 340 | | buf: &mut Buffer, [INFO] [stderr] ... | [INFO] [stderr] 386 | | self.handle_ws(buf, ws2); [INFO] [stderr] 387 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/generator.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | / fn write_loop( [INFO] [stderr] 390 | | &mut self, [INFO] [stderr] 391 | | ctx: &'a Context, [INFO] [stderr] 392 | | buf: &mut Buffer, [INFO] [stderr] ... | [INFO] [stderr] 417 | | self.locals.pop(); [INFO] [stderr] 418 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/input.rs:135:16 [INFO] [stderr] | [INFO] [stderr] 135 | || config.syntaxes.get(config.default_syntax).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.syntaxes[config.default_syntax]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/input.rs:140:22 [INFO] [stderr] | [INFO] [stderr] 140 | .expect(&format!("attribute syntax {} not exist", s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("attribute syntax {} not exist", s))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | Err(_) => panic!( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser.rs:106:30 [INFO] [stderr] | [INFO] [stderr] 106 | (&s[..start], &s[start..end + 1], &s[end + 1..]) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | Err(_) => panic!( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.14s [INFO] running `"docker" "inspect" "e215634e2cb5ffe7b3d5e92ffff2b960177edfb275e9622b8ab6d44f4997d0be"` [INFO] running `"docker" "rm" "-f" "e215634e2cb5ffe7b3d5e92ffff2b960177edfb275e9622b8ab6d44f4997d0be"` [INFO] [stdout] e215634e2cb5ffe7b3d5e92ffff2b960177edfb275e9622b8ab6d44f4997d0be