[INFO] crate askalono 0.3.0 is already in cache [INFO] extracting crate askalono 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/askalono/0.3.0 [INFO] extracting crate askalono 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/askalono/0.3.0 [INFO] validating manifest of askalono-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of askalono-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing askalono-0.3.0 [INFO] finished frobbing askalono-0.3.0 [INFO] frobbed toml for askalono-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/askalono/0.3.0/Cargo.toml [INFO] started frobbing askalono-0.3.0 [INFO] finished frobbing askalono-0.3.0 [INFO] frobbed toml for askalono-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/askalono/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting askalono-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/askalono/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 671d62f076412c517e0d1df21c0e679d8942b6ed719cb8f8570860988de79161 [INFO] running `"docker" "start" "-a" "671d62f076412c517e0d1df21c0e679d8942b6ed719cb8f8570860988de79161"` [INFO] [stderr] Checking askalono v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `match_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:10:45 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(match_bool, useless_format))] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::match_bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_format` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:10:57 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(match_bool, useless_format))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::useless_format` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:10:45 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(match_bool, useless_format))] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::match_bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_format` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:10:57 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(match_bool, useless_format))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::useless_format` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:10:45 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(match_bool, useless_format))] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::match_bool` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:10:45 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(match_bool, useless_format))] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::match_bool` [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/license.rs:240:16 [INFO] [stderr] | [INFO] [stderr] 240 | if let None = self.lines_normalized { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 241 | | return Err(format_err!("TextData does not have original text")); [INFO] [stderr] 242 | | }; [INFO] [stderr] | |_________- help: try this: `if self.lines_normalized.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/license.rs:240:16 [INFO] [stderr] | [INFO] [stderr] 240 | if let None = self.lines_normalized { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 241 | | return Err(format_err!("TextData does not have original text")); [INFO] [stderr] 242 | | }; [INFO] [stderr] | |_________- help: try this: `if self.lines_normalized.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/license.rs:389:9 [INFO] [stderr] | [INFO] [stderr] 389 | assert_eq!(x, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/license.rs:389:9 [INFO] [stderr] | [INFO] [stderr] 389 | assert_eq!(x, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/license.rs:401:9 [INFO] [stderr] | [INFO] [stderr] 401 | assert_eq!(x, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/license.rs:401:9 [INFO] [stderr] | [INFO] [stderr] 401 | assert_eq!(x, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ngram.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | assert_eq!(0f32, score); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ngram.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | assert_eq!(0f32, score); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ngram.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | assert_eq!(1f32, score); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ngram.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | assert_eq!(1f32, score); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `askalono`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/annotate-text.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | let a = annotations.get(&i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&annotations[&i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/store_sanity.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | assert!(store.len() > 0, "store should have licenses"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!store.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/store_sanity.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | .expect(&format!("couldn't open license file '{}'", license)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't open license file '{}'", license))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/store_sanity.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / assert_eq!( [INFO] [stderr] 39 | | matched.score, 1f32, [INFO] [stderr] 40 | | "license {} must have confidence 1 against itself, it was {}", [INFO] [stderr] 41 | | license, matched.score [INFO] [stderr] 42 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/store_sanity.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / assert_eq!( [INFO] [stderr] 39 | | matched.score, 1f32, [INFO] [stderr] 40 | | "license {} must have confidence 1 against itself, it was {}", [INFO] [stderr] 41 | | license, matched.score [INFO] [stderr] 42 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/store_sanity.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(0f32, matched.score); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/store_sanity.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(0f32, matched.score); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `askalono`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "671d62f076412c517e0d1df21c0e679d8942b6ed719cb8f8570860988de79161"` [INFO] running `"docker" "rm" "-f" "671d62f076412c517e0d1df21c0e679d8942b6ed719cb8f8570860988de79161"` [INFO] [stdout] 671d62f076412c517e0d1df21c0e679d8942b6ed719cb8f8570860988de79161