[INFO] crate asi_opengl 0.6.2 is already in cache [INFO] extracting crate asi_opengl 0.6.2 into work/ex/clippy-test-run/sources/stable/reg/asi_opengl/0.6.2 [INFO] extracting crate asi_opengl 0.6.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/asi_opengl/0.6.2 [INFO] validating manifest of asi_opengl-0.6.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asi_opengl-0.6.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asi_opengl-0.6.2 [INFO] finished frobbing asi_opengl-0.6.2 [INFO] frobbed toml for asi_opengl-0.6.2 written to work/ex/clippy-test-run/sources/stable/reg/asi_opengl/0.6.2/Cargo.toml [INFO] started frobbing asi_opengl-0.6.2 [INFO] finished frobbing asi_opengl-0.6.2 [INFO] frobbed toml for asi_opengl-0.6.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/asi_opengl/0.6.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asi_opengl-0.6.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/asi_opengl/0.6.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a5203a06d6144c27cfb9a0128dc060f28a4c7752e2408710357f8b0b7b72f842 [INFO] running `"docker" "start" "-a" "a5203a06d6144c27cfb9a0128dc060f28a4c7752e2408710357f8b0b7b72f842"` [INFO] [stderr] Checking dl_api v0.2.0 [INFO] [stderr] Checking asi_opengl v0.6.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/texture.rs:31:47 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn set(&self, w: u16, h: u16, px: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/texture.rs:40:50 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn update(&self, w: u16, h: u16, px: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:29:42 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn set_mat4(&self, mat4: [f32; 16]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn set_int1(&self, int1: i32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn set_vec1(&self, vec1: f32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:51:41 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn set_vec2(&self, vec: &[f32; 2]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn set_vec3(&self, vec: &[f32; 3]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:67:41 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn set_vec4(&self, vec: &[f32; 4]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:223:32 [INFO] [stderr] | [INFO] [stderr] 223 | gl!(self, (self.get().clear)(0x00000100 | 0x00004000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:223:45 [INFO] [stderr] | [INFO] [stderr] 223 | gl!(self, (self.get().clear)(0x00000100 | 0x00004000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:259:4 [INFO] [stderr] | [INFO] [stderr] 259 | 0xffffffff // Mask [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/texture.rs:31:47 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn set(&self, w: u16, h: u16, px: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/texture.rs:40:50 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn update(&self, w: u16, h: u16, px: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:29:42 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn set_mat4(&self, mat4: [f32; 16]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn set_int1(&self, int1: i32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn set_vec1(&self, vec1: f32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:51:41 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn set_vec2(&self, vec: &[f32; 2]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn set_vec3(&self, vec: &[f32; 3]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/uniform_data.rs:67:41 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn set_vec4(&self, vec: &[f32; 4]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:223:32 [INFO] [stderr] | [INFO] [stderr] 223 | gl!(self, (self.get().clear)(0x00000100 | 0x00004000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:223:45 [INFO] [stderr] | [INFO] [stderr] 223 | gl!(self, (self.get().clear)(0x00000100 | 0x00004000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:259:4 [INFO] [stderr] | [INFO] [stderr] 259 | 0xffffffff // Mask [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | GL_RGBA as i32, w as i32, h as i32, 0, GL_RGBA, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | GL_RGBA as i32, w as i32, h as i32, 0, GL_RGBA, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | 0, 0, 0, w as i32, h as i32, GL_RGBA, GL_UNSIGNED_BYTE, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | 0, 0, 0, w as i32, h as i32, GL_RGBA, GL_UNSIGNED_BYTE, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/uniform_data.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn set_vec2(&self, vec: &[f32; 2]) -> () { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn to_opengl(mut self, window: EGLNativeWindowType) -> OpenGL { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:270:39 [INFO] [stderr] | [INFO] [stderr] 270 | gl!(self, (self.get().viewport)(0,0,w as GLsizei,h as GLsizei)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:270:52 [INFO] [stderr] | [INFO] [stderr] 270 | gl!(self, (self.get().viewport)(0,0,w as GLsizei,h as GLsizei)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | GL_RGBA as i32, w as i32, h as i32, 0, GL_RGBA, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | GL_RGBA as i32, w as i32, h as i32, 0, GL_RGBA, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | 0, 0, 0, w as i32, h as i32, GL_RGBA, GL_UNSIGNED_BYTE, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | 0, 0, 0, w as i32, h as i32, GL_RGBA, GL_UNSIGNED_BYTE, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/uniform_data.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn set_vec2(&self, vec: &[f32; 2]) -> () { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[f32; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn to_opengl(mut self, window: EGLNativeWindowType) -> OpenGL { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:270:39 [INFO] [stderr] | [INFO] [stderr] 270 | gl!(self, (self.get().viewport)(0,0,w as GLsizei,h as GLsizei)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:270:52 [INFO] [stderr] | [INFO] [stderr] 270 | gl!(self, (self.get().viewport)(0,0,w as GLsizei,h as GLsizei)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.72s [INFO] running `"docker" "inspect" "a5203a06d6144c27cfb9a0128dc060f28a4c7752e2408710357f8b0b7b72f842"` [INFO] running `"docker" "rm" "-f" "a5203a06d6144c27cfb9a0128dc060f28a4c7752e2408710357f8b0b7b72f842"` [INFO] [stdout] a5203a06d6144c27cfb9a0128dc060f28a4c7752e2408710357f8b0b7b72f842